[INFO] fetching crate readfish-tools 0.1.0... [INFO] checking readfish-tools-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate readfish-tools 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate readfish-tools 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate readfish-tools 0.1.0 [INFO] finished tweaking crates.io crate readfish-tools 0.1.0 [INFO] tweaked toml for crates.io crate readfish-tools 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 124 packages to latest compatible versions [INFO] [stderr] Adding flume v0.10.14 (available: v0.11.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding indoc v1.0.9 (available: v2.0.5) [INFO] [stderr] Adding itertools v0.11.0 (available: v0.13.0) [INFO] [stderr] Adding libdeflate-sys v0.12.0 (available: v1.21.0) [INFO] [stderr] Adding libdeflater v0.12.0 (available: v1.21.0) [INFO] [stderr] Adding ndarray v0.15.6 (available: v0.16.1) [INFO] [stderr] Adding pyo3 v0.19.2 (available: v0.22.3) [INFO] [stderr] Adding pyo3-build-config v0.19.2 (available: v0.22.3) [INFO] [stderr] Adding pyo3-ffi v0.19.2 (available: v0.22.3) [INFO] [stderr] Adding pyo3-macros v0.19.2 (available: v0.22.3) [INFO] [stderr] Adding pyo3-macros-backend v0.19.2 (available: v0.22.3) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding term v0.7.0 (available: v1.0.0) [INFO] [stderr] Adding toml v0.7.8 (available: v0.8.19) [INFO] [stderr] Adding toml_edit v0.19.15 (available: v0.22.22) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding unindent v0.1.11 (available: v0.2.3) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (available: v0.6.20) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 06416453898ba3b22acb4c27e731cca4beb4620a3e3bc1d0e751cd64b3b9b6ec [INFO] running `Command { std: "docker" "start" "-a" "06416453898ba3b22acb4c27e731cca4beb4620a3e3bc1d0e751cd64b3b9b6ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "06416453898ba3b22acb4c27e731cca4beb4620a3e3bc1d0e751cd64b3b9b6ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06416453898ba3b22acb4c27e731cca4beb4620a3e3bc1d0e751cd64b3b9b6ec", kill_on_drop: false }` [INFO] [stdout] 06416453898ba3b22acb4c27e731cca4beb4620a3e3bc1d0e751cd64b3b9b6ec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 921dd4ad8c916e9c35140cfc2106a509587de05be3bcea68099b28a9f4a15364 [INFO] running `Command { std: "docker" "start" "-a" "921dd4ad8c916e9c35140cfc2106a509587de05be3bcea68099b28a9f4a15364", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling cc v1.1.22 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling pyo3-build-config v0.19.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling cmake v0.1.51 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking winnow v0.5.40 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking core_affinity v0.8.1 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking unindent v0.1.11 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Compiling libdeflate-sys v0.12.0 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling pyo3-macros-backend v0.19.2 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Compiling pyo3-ffi v0.19.2 [INFO] [stderr] Compiling pyo3 v0.19.2 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking natord v1.0.9 [INFO] [stderr] Checking libdeflater v0.12.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking flate2 v1.0.34 [INFO] [stderr] Compiling pyo3-macros v0.19.2 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking gzp v0.11.3 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking prettytable v0.10.0 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking readfish-tools v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/readfish_io.rs:304:26 [INFO] [stdout] | [INFO] [stdout] 296 | filename: impl AsRef, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let file = match File::open(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:989:1 [INFO] [stdout] | [INFO] [stdout] 989 | #[pymethods] [INFO] [stdout] | -^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `PyClassImplCollector` is not local [INFO] [stdout] | `PyClassNewTextSignature` is not local [INFO] [stdout] | move the `impl` block outside of this function `trampoline` and up 4 bodies [INFO] [stdout] 990 | impl ReadfishSummary { [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | `ReadfishSummary` is not local [INFO] [stdout] | `ReadfishSummary` is not local [INFO] [stdout] | [INFO] [stdout] = note: the attribute macro `pymethods` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the attribute macro `pymethods` may come from an old version of the `pyo3_macros` crate, try updating your dependency with `cargo update -p pyo3_macros` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the attribute macro `pymethods` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `readfish-tools` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/readfish_io.rs:304:26 [INFO] [stdout] | [INFO] [stdout] 296 | filename: impl AsRef, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 304 | let file = match File::open(&path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:989:1 [INFO] [stdout] | [INFO] [stdout] 989 | #[pymethods] [INFO] [stdout] | -^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `PyClassImplCollector` is not local [INFO] [stdout] | `PyClassNewTextSignature` is not local [INFO] [stdout] | move the `impl` block outside of this function `trampoline` and up 4 bodies [INFO] [stdout] 990 | impl ReadfishSummary { [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | `ReadfishSummary` is not local [INFO] [stdout] | `ReadfishSummary` is not local [INFO] [stdout] | [INFO] [stdout] = note: the attribute macro `pymethods` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the attribute macro `pymethods` may come from an old version of the `pyo3_macros` crate, try updating your dependency with `cargo update -p pyo3_macros` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the attribute macro `pymethods` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `readfish-tools` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "921dd4ad8c916e9c35140cfc2106a509587de05be3bcea68099b28a9f4a15364", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "921dd4ad8c916e9c35140cfc2106a509587de05be3bcea68099b28a9f4a15364", kill_on_drop: false }` [INFO] [stdout] 921dd4ad8c916e9c35140cfc2106a509587de05be3bcea68099b28a9f4a15364