[INFO] fetching crate ra_ap_hir_expand 0.0.236... [INFO] checking ra_ap_hir_expand-0.0.236 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate ra_ap_hir_expand 0.0.236 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ra_ap_hir_expand 0.0.236 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ra_ap_hir_expand 0.0.236 [INFO] finished tweaking crates.io crate ra_ap_hir_expand 0.0.236 [INFO] tweaked toml for crates.io crate ra_ap_hir_expand 0.0.236 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 94 packages to latest compatible versions [INFO] [stderr] Adding dashmap v5.5.3 (available: v6.1.0) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] [stderr] Adding ra-ap-rustc_lexer v0.63.0 (available: v0.68.0) [INFO] [stderr] Adding rowan v0.15.15 (available: v0.15.16) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f96218a581c5a29c77b33c61a561df8b097df6db2ab7ff75a15d7749d0e56baa [INFO] running `Command { std: "docker" "start" "-a" "f96218a581c5a29c77b33c61a561df8b097df6db2ab7ff75a15d7749d0e56baa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f96218a581c5a29c77b33c61a561df8b097df6db2ab7ff75a15d7749d0e56baa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f96218a581c5a29c77b33c61a561df8b097df6db2ab7ff75a15d7749d0e56baa", kill_on_drop: false }` [INFO] [stdout] f96218a581c5a29c77b33c61a561df8b097df6db2ab7ff75a15d7749d0e56baa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1d5c3abb8ff24f456aae82a6871903167248496b9911baad005d1833c5ac9491 [INFO] running `Command { std: "docker" "start" "-a" "1d5c3abb8ff24f456aae82a6871903167248496b9911baad005d1833c5ac9491", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking unicode-properties v0.1.2 [INFO] [stderr] Checking unicode-xid v0.2.6 [INFO] [stderr] Checking jod-thread v0.1.2 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking ra-ap-rustc_lexer v0.63.0 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling fst v0.4.7 [INFO] [stderr] Checking ra_ap_limit v0.0.236 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking sptr v0.3.2 [INFO] [stderr] Checking drop_bomb v0.1.5 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking cov-mark v2.0.0 [INFO] [stderr] Checking smol_str v0.3.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking la-arena v0.3.1 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking dissimilar v1.0.9 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking expect-test v1.5.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking ra_ap_paths v0.0.236 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking rowan v0.15.15 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking ra_ap_text_edit v0.0.236 [INFO] [stderr] Checking triomphe v0.1.13 [INFO] [stderr] Checking ra_ap_intern v0.0.236 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling ra_ap_salsa-macros v0.0.236 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking always-assert v0.2.0 [INFO] [stderr] Checking ra_ap_parser v0.0.236 [INFO] [stderr] Checking ra_ap_salsa v0.0.236 [INFO] [stderr] Checking ra_ap_stdx v0.0.236 [INFO] [stderr] Checking ra_ap_vfs v0.0.236 [INFO] [stderr] Checking ra_ap_tt v0.0.236 [INFO] [stderr] Checking ra_ap_syntax v0.0.236 [INFO] [stderr] Checking ra_ap_cfg v0.0.236 [INFO] [stderr] Checking ra_ap_span v0.0.236 [INFO] [stderr] Checking ra_ap_syntax-bridge v0.0.236 [INFO] [stderr] Checking ra_ap_base_db v0.0.236 [INFO] [stderr] Checking ra_ap_mbe v0.0.236 [INFO] [stderr] Checking ra_ap_hir_expand v0.0.236 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `InFileWrapper>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:218:37 [INFO] [stdout] | [INFO] [stdout] 205 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | std::iter::successors(succ(&self.borrow().cloned()), succ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `InFileWrapper>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:218:37 [INFO] [stdout] | [INFO] [stdout] 205 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | std::iter::successors(succ(&self.borrow().cloned()), succ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attrs.rs:96:15 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn merge(&self, other: Self) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | match (&self.entries, other.entries) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attrs.rs:96:15 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn merge(&self, other: Self) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | match (&self.entries, other.entries) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ExpansionInfo` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 306 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | self.file_id.expansion_info(db).map_range_up_once(db, self.value.text_range()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FilterMap, fn(NodeOrToken, rowan::api::SyntaxToken>) -> Option> {NodeOrToken::, rowan::api::SyntaxToken>::into_token}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prettify_macro_expansion_.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 53 | let parent = replacement.parent().unwrap().clone_subtree().clone_for_update(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / parent [INFO] [stdout] 55 | | .children_with_tokens() [INFO] [stdout] 56 | | .filter_map(NodeOrToken::into_token) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ExpansionInfo` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/files.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 306 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | self.file_id.expansion_info(db).map_range_up_once(db, self.value.text_range()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:562:21 [INFO] [stdout] | [INFO] [stdout] 561 | ast_id.with_value(ast_id.to_node(db)).map(|it| { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 562 | collect_attrs(&it) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:575:25 [INFO] [stdout] | [INFO] [stdout] 574 | ast_id.with_value(ast_id.to_node(db)).map(|it| { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 575 | collect_attrs(&it) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FilterMap, fn(NodeOrToken, rowan::api::SyntaxToken>) -> Option> {NodeOrToken::, rowan::api::SyntaxToken>::into_token}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/prettify_macro_expansion_.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 53 | let parent = replacement.parent().unwrap().clone_subtree().clone_for_update(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / parent [INFO] [stdout] 55 | | .children_with_tokens() [INFO] [stdout] 56 | | .filter_map(NodeOrToken::into_token) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ra_ap_hir_expand` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `impl Iterator)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:562:21 [INFO] [stdout] | [INFO] [stdout] 561 | ast_id.with_value(ast_id.to_node(db)).map(|it| { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 562 | collect_attrs(&it) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl Iterator)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:575:25 [INFO] [stdout] | [INFO] [stdout] 574 | ast_id.with_value(ast_id.to_node(db)).map(|it| { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 575 | collect_attrs(&it) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ra_ap_hir_expand` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "1d5c3abb8ff24f456aae82a6871903167248496b9911baad005d1833c5ac9491", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d5c3abb8ff24f456aae82a6871903167248496b9911baad005d1833c5ac9491", kill_on_drop: false }` [INFO] [stdout] 1d5c3abb8ff24f456aae82a6871903167248496b9911baad005d1833c5ac9491