[INFO] fetching crate ra_ap_assists 0.0.39... [INFO] checking ra_ap_assists-0.0.39 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate ra_ap_assists 0.0.39 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ra_ap_assists 0.0.39 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ra_ap_assists 0.0.39 [INFO] finished tweaking crates.io crate ra_ap_assists 0.0.39 [INFO] tweaked toml for crates.io crate ra_ap_assists 0.0.39 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 137 packages to latest compatible versions [INFO] [stderr] Adding always-assert v0.1.3 (available: v0.2.0) [INFO] [stderr] Adding arrayvec v0.5.2 (available: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding chalk-derive v0.58.0 (available: v0.98.0) [INFO] [stderr] Adding chalk-ir v0.58.0 (available: v0.98.0) [INFO] [stderr] Adding chalk-recursive v0.58.0 (available: v0.98.0) [INFO] [stderr] Adding chalk-solve v0.58.0 (available: v0.98.0) [INFO] [stderr] Adding countme v2.0.4 (available: v3.0.1) [INFO] [stderr] Adding dashmap v4.0.2 (available: v6.1.0) [INFO] [stderr] Adding fixedbitset v0.2.0 (available: v0.5.7) [INFO] [stderr] Adding hashbrown v0.9.1 (available: v0.14.5) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding heck v0.3.3 (available: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.9.0 (available: v0.13.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding matchers v0.0.1 (available: v0.2.0) [INFO] [stderr] Adding memoffset v0.6.5 (available: v0.9.1) [INFO] [stderr] Adding parking_lot v0.11.2 (available: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (available: v0.9.10) [INFO] [stderr] Adding petgraph v0.5.1 (available: v0.6.5) [INFO] [stderr] Adding ra_ap_base_db v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_cfg v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_hir v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_hir_def v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_hir_expand v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_hir_ty v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_ide_db v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_la-arena v0.0.39 (available: v0.0.149) [INFO] [stderr] Adding ra_ap_mbe v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_parser v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_paths v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_profile v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_stdx v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_syntax v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_test_utils v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_text_edit v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_tt v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding ra_ap_vfs v0.0.39 (available: v0.0.236) [INFO] [stderr] Adding redox_syscall v0.2.16 (available: v0.5.6) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding rowan v0.12.6 (available: v0.15.16) [INFO] [stderr] Adding rustc-ap-rustc_lexer v707.0.0 (available: v727.0.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding smol_str v0.1.24 (available: v0.3.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding synstructure v0.12.6 (available: v0.13.1) [INFO] [stderr] Adding tracing-log v0.1.4 (available: v0.2.0) [INFO] [stderr] Adding tracing-subscriber v0.2.25 (available: v0.3.18) [INFO] [stderr] Adding tracing-tree v0.1.11 (available: v0.4.0) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5ef8ecbce309cec75b09109e6c06b06ea6e0ebd1e84a3c4a0bc031c9471e9b21 [INFO] running `Command { std: "docker" "start" "-a" "5ef8ecbce309cec75b09109e6c06b06ea6e0ebd1e84a3c4a0bc031c9471e9b21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5ef8ecbce309cec75b09109e6c06b06ea6e0ebd1e84a3c4a0bc031c9471e9b21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ef8ecbce309cec75b09109e6c06b06ea6e0ebd1e84a3c4a0bc031c9471e9b21", kill_on_drop: false }` [INFO] [stdout] 5ef8ecbce309cec75b09109e6c06b06ea6e0ebd1e84a3c4a0bc031c9471e9b21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a348a9d7c6f29ab5b5bf760df88eeef62c8b1f999ee9c7610e61a46260393dcb [INFO] running `Command { std: "docker" "start" "-a" "a348a9d7c6f29ab5b5bf760df88eeef62c8b1f999ee9c7610e61a46260393dcb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking ra_ap_la-arena v0.0.39 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling fst v0.4.7 [INFO] [stderr] Checking always-assert v0.1.3 [INFO] [stderr] Checking drop_bomb v0.1.5 [INFO] [stderr] Checking ra_ap_stdx v0.0.39 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking unicode-xid v0.2.6 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking dissimilar v1.0.9 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking rustc-ap-rustc_lexer v707.0.0 [INFO] [stderr] Checking ra_ap_parser v0.0.39 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking ra_ap_text_edit v0.0.39 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking ra_ap_paths v0.0.39 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking fixedbitset v0.2.0 [INFO] [stderr] Checking ena v0.14.3 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking anymap v0.12.1 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking petgraph v0.5.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking perf-event-open-sys v4.0.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking ra_ap_vfs v0.0.39 [INFO] [stderr] Checking perf-event v0.4.8 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking dashmap v4.0.2 [INFO] [stderr] Checking countme v2.0.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking ra_ap_profile v0.0.39 [INFO] [stderr] Checking rowan v0.12.6 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling salsa-macros v0.16.0 [INFO] [stderr] Compiling chalk-derive v0.58.0 [INFO] [stderr] Checking chalk-ir v0.58.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking salsa v0.16.1 [INFO] [stderr] Checking smol_str v0.1.24 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking ra_ap_tt v0.0.39 [INFO] [stderr] Checking ra_ap_cfg v0.0.39 [INFO] [stderr] Checking ra_ap_test_utils v0.0.39 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking ra_ap_syntax v0.0.39 [INFO] [stderr] Checking tracing-tree v0.1.11 [INFO] [stderr] Checking chalk-solve v0.58.0 [INFO] [stderr] Checking ra_ap_mbe v0.0.39 [INFO] [stderr] Checking ra_ap_base_db v0.0.39 [INFO] [stderr] Checking ra_ap_hir_expand v0.0.39 [INFO] [stderr] Checking ra_ap_hir_def v0.0.39 [INFO] [stderr] Checking chalk-recursive v0.58.0 [INFO] [stderr] Checking ra_ap_hir_ty v0.0.39 [INFO] [stderr] Checking ra_ap_hir v0.0.39 [INFO] [stderr] Checking ra_ap_ide_db v0.0.39 [INFO] [stderr] Checking ra_ap_assists v0.0.39 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `TreeDiff` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assist_context.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 234 | pub(crate) fn replace_ast(&mut self, old: N, new: N) { [INFO] [stdout] | --- --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | algo::diff(old.syntax(), new.syntax()).into_text_edit(&mut self.edit) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assist_context.rs:238:29 [INFO] [stdout] | [INFO] [stdout] 237 | pub(crate) fn rewrite(&mut self, rewriter: SyntaxRewriter) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | if let Some(node) = rewriter.rewrite_root() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option, rowan::api::SyntaxToken>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 33 | let mut non_trivial_children = [INFO] [stdout] | ------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | non_trivial_children.next().is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:153:15 [INFO] [stdout] | [INFO] [stdout] 152 | fn add_body(fn_def: ast::Fn) -> ast::Fn { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | match fn_def.body() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `rowan::api::SyntaxToken` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/add_turbo_fish.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 29 | let arg_list = ctx.find_node_at_offset::()?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | arg_list.l_paren_token()?.prev_token().filter(|it| it.kind() == SyntaxKind::IDENT) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ra_ap_syntax::ast::IfExpr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/early_return.rs:180:25 [INFO] [stdout] | [INFO] [stdout] 162 | let then_block_items = then_block.dedent(IndentLevel(1)); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let end_of_then = then_block_items.syntax().last_child_or_token().unwrap(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | let end_of_then = [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let mut then_statements = new_expr.children_with_tokens().chain( [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | if_expr.clone().syntax().clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/extract_function.rs:1275:11 [INFO] [stdout] | [INFO] [stdout] 1274 | fn with_default_tail_expr(block: ast::BlockExpr, tail_expr: ast::Expr) -> ast::BlockExpr { [INFO] [stdout] | ----- --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1275 | match block.tail_expr() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option, std::option::Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/fill_match_arms.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 112 | let new_arm_list = match_arm_list.remove_placeholder(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let n_old_arms = new_arm_list.arms().count(); [INFO] [stdout] 114 | let new_arm_list = new_arm_list.append_arms(missing_arms); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | match (first_new_arm, ctx.config.snippet_cap) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&Expr, Expr)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/inline_local_variable.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 73 | let usage_node = ctx [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let usage_parent_option = [INFO] [stdout] | ------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | (&initializer_expr, usage_parent), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/introduce_named_lifetime.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 38 | let lifetime = [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ctx.find_node_at_offset::().filter(|lifetime| lifetime.text() == "'_")?; [INFO] [stdout] 40 | if let Some(fn_def) = lifetime.syntax().ancestors().find_map(ast::Fn::cast) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Expr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/move_guard.rs:101:34 [INFO] [stdout] | [INFO] [stdout] 100 | let block_expr = BlockExpr::cast(arm_body.syntax().clone())?; [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | if let Expr::IfExpr(e) = block_expr.tail_expr()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Expr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pull_assignment_up.rs:82:50 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|arm| { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | if let ast::Expr::BlockExpr(block) = arm.expr()? { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/replace_qualified_name_with_use.rs:46:45 [INFO] [stdout] | [INFO] [stdout] 44 | let mut rewriter = SyntaxRewriter::default(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | shorten_paths(&mut rewriter, syntax.clone(), &path); [INFO] [stdout] 46 | if let Some(ref import_scope) = ImportScope::from(syntax.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/toggle_ignore.rs:31:11 [INFO] [stdout] | [INFO] [stdout] 27 | let attr: ast::Attr = ctx.find_node_at_offset()?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let func = attr.syntax().parent().and_then(ast::Fn::cast)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let attr = test_related_attribute(&func)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | match has_ignore_attribute(&func) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ra_ap_assists` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `TreeDiff` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assist_context.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 234 | pub(crate) fn replace_ast(&mut self, old: N, new: N) { [INFO] [stdout] | --- --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | algo::diff(old.syntax(), new.syntax()).into_text_edit(&mut self.edit) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assist_context.rs:238:29 [INFO] [stdout] | [INFO] [stdout] 237 | pub(crate) fn rewrite(&mut self, rewriter: SyntaxRewriter) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | if let Some(node) = rewriter.rewrite_root() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option, rowan::api::SyntaxToken>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 33 | let mut non_trivial_children = [INFO] [stdout] | ------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | non_trivial_children.next().is_some() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:153:15 [INFO] [stdout] | [INFO] [stdout] 152 | fn add_body(fn_def: ast::Fn) -> ast::Fn { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | match fn_def.body() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `rowan::api::SyntaxToken` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/add_turbo_fish.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 29 | let arg_list = ctx.find_node_at_offset::()?; [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | arg_list.l_paren_token()?.prev_token().filter(|it| it.kind() == SyntaxKind::IDENT) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ra_ap_syntax::ast::IfExpr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/early_return.rs:180:25 [INFO] [stdout] | [INFO] [stdout] 162 | let then_block_items = then_block.dedent(IndentLevel(1)); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let end_of_then = then_block_items.syntax().last_child_or_token().unwrap(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | let end_of_then = [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | let mut then_statements = new_expr.children_with_tokens().chain( [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | if_expr.clone().syntax().clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/extract_function.rs:1275:11 [INFO] [stdout] | [INFO] [stdout] 1274 | fn with_default_tail_expr(block: ast::BlockExpr, tail_expr: ast::Expr) -> ast::BlockExpr { [INFO] [stdout] | ----- --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1275 | match block.tail_expr() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option, std::option::Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/fill_match_arms.rs:117:19 [INFO] [stdout] | [INFO] [stdout] 112 | let new_arm_list = match_arm_list.remove_placeholder(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let n_old_arms = new_arm_list.arms().count(); [INFO] [stdout] 114 | let new_arm_list = new_arm_list.append_arms(missing_arms); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | match (first_new_arm, ctx.config.snippet_cap) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&Expr, Expr)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/inline_local_variable.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 73 | let usage_node = ctx [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let usage_parent_option = [INFO] [stdout] | ------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | (&initializer_expr, usage_parent), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/introduce_named_lifetime.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 38 | let lifetime = [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | ctx.find_node_at_offset::().filter(|lifetime| lifetime.text() == "'_")?; [INFO] [stdout] 40 | if let Some(fn_def) = lifetime.syntax().ancestors().find_map(ast::Fn::cast) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Expr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/move_guard.rs:101:34 [INFO] [stdout] | [INFO] [stdout] 100 | let block_expr = BlockExpr::cast(arm_body.syntax().clone())?; [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | if let Expr::IfExpr(e) = block_expr.tail_expr()? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Expr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/pull_assignment_up.rs:82:50 [INFO] [stdout] | [INFO] [stdout] 81 | .map(|arm| { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | if let ast::Expr::BlockExpr(block) = arm.expr()? { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/replace_qualified_name_with_use.rs:46:45 [INFO] [stdout] | [INFO] [stdout] 44 | let mut rewriter = SyntaxRewriter::default(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | shorten_paths(&mut rewriter, syntax.clone(), &path); [INFO] [stdout] 46 | if let Some(ref import_scope) = ImportScope::from(syntax.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handlers/toggle_ignore.rs:31:11 [INFO] [stdout] | [INFO] [stdout] 27 | let attr: ast::Attr = ctx.find_node_at_offset()?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let func = attr.syntax().parent().and_then(ast::Fn::cast)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let attr = test_related_attribute(&func)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | [INFO] [stdout] 31 | match has_ignore_attribute(&func) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ra_ap_assists` (lib test) due to 15 previous errors [INFO] running `Command { std: "docker" "inspect" "a348a9d7c6f29ab5b5bf760df88eeef62c8b1f999ee9c7610e61a46260393dcb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a348a9d7c6f29ab5b5bf760df88eeef62c8b1f999ee9c7610e61a46260393dcb", kill_on_drop: false }` [INFO] [stdout] a348a9d7c6f29ab5b5bf760df88eeef62c8b1f999ee9c7610e61a46260393dcb