[INFO] fetching crate polars-parquet 0.43.1... [INFO] checking polars-parquet-0.43.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate polars-parquet 0.43.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate polars-parquet 0.43.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate polars-parquet 0.43.1 [INFO] finished tweaking crates.io crate polars-parquet 0.43.1 [INFO] tweaked toml for crates.io crate polars-parquet 0.43.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 135 packages to latest compatible versions [INFO] [stderr] Adding atoi_simd v0.15.6 (available: v0.16.0) [INFO] [stderr] Adding memmap2 v0.7.1 (available: v0.9.5) [INFO] [stderr] Adding planus v0.3.1 (available: v0.4.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4d38bec593d93609dafabaf3aa9d28b8ab2b6248aadf4337326d8e728703af5c [INFO] running `Command { std: "docker" "start" "-a" "4d38bec593d93609dafabaf3aa9d28b8ab2b6248aadf4337326d8e728703af5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4d38bec593d93609dafabaf3aa9d28b8ab2b6248aadf4337326d8e728703af5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d38bec593d93609dafabaf3aa9d28b8ab2b6248aadf4337326d8e728703af5c", kill_on_drop: false }` [INFO] [stdout] 4d38bec593d93609dafabaf3aa9d28b8ab2b6248aadf4337326d8e728703af5c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb2944d427f09fcc0720490ac17e3ddb56174c433cf674595d7627d2569fd065 [INFO] running `Command { std: "docker" "start" "-a" "fb2944d427f09fcc0720490ac17e3ddb56174c433cf674595d7627d2569fd065", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling psm v0.1.23 [INFO] [stderr] Compiling target-features v0.1.6 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking array-init-cursor v0.2.0 [INFO] [stderr] Compiling stacker v0.1.17 [INFO] [stderr] Checking planus v0.3.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling polars-utils v0.43.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Compiling polars-schema v0.43.1 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling polars-arrow v0.43.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling polars-compute v0.43.1 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Checking atoi_simd v0.15.6 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking fast-float v0.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking parquet-format-safe v0.2.4 [INFO] [stderr] Checking streaming-decompression v0.1.2 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling multiversion-macros v0.7.4 [INFO] [stderr] Checking polars-arrow-format v0.1.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking multiversion v0.7.4 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking polars-error v0.43.1 [INFO] [stderr] Checking polars-parquet v0.43.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/read/deserialize/nested.rs:403:34 [INFO] [stdout] | [INFO] [stdout] 12 | mut columns: Vec, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | mut types: Vec<&PrimitiveType>, [INFO] [stdout] 14 | field: Field, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | mut init: Vec, [INFO] [stdout] 16 | filter: Option, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | let (mut nested, last_array) = [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `arrow::read::deserialize::utils::filter::Filter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/read/deserialize/utils/mod.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 126 | filter: Option, [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Some(filter) => match filter { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(&dyn polars_arrow::array::Array, BitmapState)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/write/pages.rs:391:51 [INFO] [stdout] | [INFO] [stdout] 387 | let mut array_stack: Vec<(&dyn Array, BitmapState)> = Vec::new(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | while let Some((array, inherited_validity)) = array_stack.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `PlSmallStr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/write/schema.rs:235:13 [INFO] [stdout] | [INFO] [stdout] 81 | let name = field.name.clone(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | name, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parquet_type::ParquetType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parquet/metadata/schema_descriptor.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 60 | pub(crate) fn into_thrift(self) -> Vec { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | / ParquetType::GroupType { [INFO] [stdout] 62 | | field_info: FieldInfo { [INFO] [stdout] 63 | | name: self.name, [INFO] [stdout] 64 | | repetition: Repetition::Optional, [INFO] [stdout] ... | [INFO] [stdout] 69 | | fields: self.fields, [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/read/deserialize/nested.rs:403:34 [INFO] [stdout] | [INFO] [stdout] 12 | mut columns: Vec, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | mut types: Vec<&PrimitiveType>, [INFO] [stdout] 14 | field: Field, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | mut init: Vec, [INFO] [stdout] 16 | filter: Option, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | let (mut nested, last_array) = [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parquet/write/statistics.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 7 | fn reduce_single T>(lhs: Option, rhs: Option, op: F) -> Option { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `arrow::read::deserialize::utils::filter::Filter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/read/deserialize/utils/mod.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 126 | filter: Option, [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Some(filter) => match filter { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polars-parquet` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option<(&dyn polars_arrow::array::Array, BitmapState)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/write/pages.rs:391:51 [INFO] [stdout] | [INFO] [stdout] 387 | let mut array_stack: Vec<(&dyn Array, BitmapState)> = Vec::new(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | while let Some((array, inherited_validity)) = array_stack.pop() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `polars_utils::pl_str::PlSmallStr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/write/schema.rs:235:13 [INFO] [stdout] | [INFO] [stdout] 81 | let name = field.name.clone(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | name, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parquet_type::ParquetType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parquet/metadata/schema_descriptor.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 60 | pub(crate) fn into_thrift(self) -> Vec { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | / ParquetType::GroupType { [INFO] [stdout] 62 | | field_info: FieldInfo { [INFO] [stdout] 63 | | name: self.name, [INFO] [stdout] 64 | | repetition: Repetition::Optional, [INFO] [stdout] ... | [INFO] [stdout] 69 | | fields: self.fields, [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parquet/write/statistics.rs:8:11 [INFO] [stdout] | [INFO] [stdout] 7 | fn reduce_single T>(lhs: Option, rhs: Option, op: F) -> Option { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polars-parquet` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "fb2944d427f09fcc0720490ac17e3ddb56174c433cf674595d7627d2569fd065", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb2944d427f09fcc0720490ac17e3ddb56174c433cf674595d7627d2569fd065", kill_on_drop: false }` [INFO] [stdout] fb2944d427f09fcc0720490ac17e3ddb56174c433cf674595d7627d2569fd065