[INFO] fetching crate polars-arrow 0.43.1... [INFO] checking polars-arrow-0.43.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate polars-arrow 0.43.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate polars-arrow 0.43.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate polars-arrow 0.43.1 [INFO] finished tweaking crates.io crate polars-arrow 0.43.1 [INFO] tweaked toml for crates.io crate polars-arrow 0.43.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 219 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding arrow2 v0.17.4 (available: v0.18.0) [INFO] [stderr] Adding atoi_simd v0.15.6 (available: v0.16.0) [INFO] [stderr] Adding chrono-tz v0.8.6 (available: v0.10.0) [INFO] [stderr] Adding chrono-tz-build v0.2.1 (available: v0.4.0) [INFO] [stderr] Adding crc v2.1.0 (available: v3.2.1) [INFO] [stderr] Adding crc-catalog v1.1.1 (available: v2.4.0) [INFO] [stderr] Adding env_logger v0.8.4 (available: v0.11.5) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding libflate v1.4.0 (available: v2.1.0) [INFO] [stderr] Adding libflate_lz77 v1.2.0 (available: v2.1.0) [INFO] [stderr] Adding planus v0.3.1 (available: v0.4.0) [INFO] [stderr] Adding prost v0.11.9 (available: v0.13.3) [INFO] [stderr] Adding prost-derive v0.11.9 (available: v0.13.3) [INFO] [stderr] Adding rand_regex v0.15.1 (available: v0.17.0) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9c6348545ed4b87e114ca6eaa772884f91384d7706d95225f5aeed6041a6f5f2 [INFO] running `Command { std: "docker" "start" "-a" "9c6348545ed4b87e114ca6eaa772884f91384d7706d95225f5aeed6041a6f5f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9c6348545ed4b87e114ca6eaa772884f91384d7706d95225f5aeed6041a6f5f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c6348545ed4b87e114ca6eaa772884f91384d7706d95225f5aeed6041a6f5f2", kill_on_drop: false }` [INFO] [stdout] 9c6348545ed4b87e114ca6eaa772884f91384d7706d95225f5aeed6041a6f5f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 473769ea789ac02e9ec76f37e96f97c36fb3ae62f96965e859078f04ee9a7822 [INFO] running `Command { std: "docker" "start" "-a" "473769ea789ac02e9ec76f37e96f97c36fb3ae62f96965e859078f04ee9a7822", kill_on_drop: false }` [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling psm v0.1.23 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling stacker v0.1.17 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling polars-utils v0.43.1 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Checking polars-error v0.43.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling polars-schema v0.43.1 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling arrow2 v0.17.4 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling polars-arrow v0.43.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking hash_hasher v2.0.3 [INFO] [stderr] Checking foreign_vec v0.1.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking streaming-iterator v0.1.9 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking rand_regex v0.15.1 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling casey v0.4.0 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking sample-std v0.2.1 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking sample-arrow2 v0.17.2 [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/legacy/kernels/take_agg/mod.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 102 | 'a, [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 110 | ) -> Option<&[u8]> { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/legacy/kernels/take_agg/mod.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 143 | 'a, [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 150 | ) -> Option<&[u8]> { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling sample-test-macros v0.2.1 [INFO] [stderr] Checking sample-test v0.2.1 [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/legacy/kernels/take_agg/mod.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 102 | 'a, [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 110 | ) -> Option<&[u8]> { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/legacy/kernels/take_agg/mod.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 143 | 'a, [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 150 | ) -> Option<&[u8]> { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `M` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/dictionary/mutable.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 23 | fn from(other: MutableDictionaryArray) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | other.map.into_values().as_box(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/primitive/mod.rs:291:33 [INFO] [stdout] | [INFO] [stdout] 290 | pub fn apply_validity Bitmap>(&mut self, f: F) { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | if let Some(validity) = std::mem::take(&mut self.validity) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `array::binview::BinaryViewArrayGeneric<[u8]>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/static_array.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 329 | fn full(length: usize, value: Self::ValueT<'_>, _dtype: ArrowDataType) -> Self { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | unsafe { [INFO] [stdout] 331 | BinaryViewArray::full(length, value.as_bytes(), ArrowDataType::BinaryView) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `datatypes::ArrowDataType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/static_array_collect.rs:870:27 [INFO] [stdout] | [INFO] [stdout] 860 | fn arr_from_iter_with_dtype>(dtype: ArrowDataType, iter: I) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 861 | let iter_values: Vec = iter.into_iter().collect(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 870 | .finish(Some(&inner.underlying_physical_type())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `datatypes::ArrowDataType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/static_array_collect.rs:897:27 [INFO] [stdout] | [INFO] [stdout] 885 | dtype: ArrowDataType, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 888 | let iter_values: Vec> = iter.into_iter().collect(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 897 | .finish(Some(&inner.underlying_physical_type())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `datatypes::ArrowDataType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/static_array_collect.rs:914:27 [INFO] [stdout] | [INFO] [stdout] 902 | dtype: ArrowDataType, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 905 | let iter_values = iter.into_iter().collect::, E>>()?; [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 914 | .finish(Some(&inner.underlying_physical_type())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/utf8/mod.rs:486:33 [INFO] [stdout] | [INFO] [stdout] 485 | pub fn apply_validity Bitmap>(&mut self, f: F) { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | if let Some(validity) = std::mem::take(&mut self.validity) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, SharedStorage>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitmap/immutable.rs:369:15 [INFO] [stdout] | [INFO] [stdout] 368 | pub fn into_mut(mut self) -> Either { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | match self.storage.try_into_vec() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, SharedStorage>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/immutable.rs:215:15 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn into_mut(mut self) -> Either> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | match self.storage.try_into_vec() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ffi/array.rs:107:22 [INFO] [stdout] | [INFO] [stdout] 107 | let (offset, mut buffers, children, dictionary) = [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `utf8view_to_timestamp_impl` is never used [INFO] [stdout] --> src/temporal_conversions.rs:319:4 [INFO] [stdout] | [INFO] [stdout] 319 | fn utf8view_to_timestamp_impl( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `chrono_tz_utf_to_timestamp` is never used [INFO] [stdout] --> src/temporal_conversions.rs:368:4 [INFO] [stdout] | [INFO] [stdout] 368 | fn chrono_tz_utf_to_timestamp( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `utf8view_to_timestamp` is never used [INFO] [stdout] --> src/temporal_conversions.rs:390:15 [INFO] [stdout] | [INFO] [stdout] 390 | pub(crate) fn utf8view_to_timestamp( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `utf8view_to_naive_timestamp` is never used [INFO] [stdout] --> src/temporal_conversions.rs:411:15 [INFO] [stdout] | [INFO] [stdout] 411 | pub(crate) fn utf8view_to_naive_timestamp( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polars-arrow` (lib) due to 10 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `M` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/dictionary/mutable.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 23 | fn from(other: MutableDictionaryArray) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | other.map.into_values().as_box(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/primitive/mod.rs:291:33 [INFO] [stdout] | [INFO] [stdout] 290 | pub fn apply_validity Bitmap>(&mut self, f: F) { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | if let Some(validity) = std::mem::take(&mut self.validity) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `array::binview::BinaryViewArrayGeneric<[u8]>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/static_array.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 329 | fn full(length: usize, value: Self::ValueT<'_>, _dtype: ArrowDataType) -> Self { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 330 | unsafe { [INFO] [stdout] 331 | BinaryViewArray::full(length, value.as_bytes(), ArrowDataType::BinaryView) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `datatypes::ArrowDataType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/static_array_collect.rs:870:27 [INFO] [stdout] | [INFO] [stdout] 860 | fn arr_from_iter_with_dtype>(dtype: ArrowDataType, iter: I) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 861 | let iter_values: Vec = iter.into_iter().collect(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 870 | .finish(Some(&inner.underlying_physical_type())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `datatypes::ArrowDataType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/static_array_collect.rs:897:27 [INFO] [stdout] | [INFO] [stdout] 885 | dtype: ArrowDataType, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 888 | let iter_values: Vec> = iter.into_iter().collect(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 897 | .finish(Some(&inner.underlying_physical_type())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `datatypes::ArrowDataType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/static_array_collect.rs:914:27 [INFO] [stdout] | [INFO] [stdout] 902 | dtype: ArrowDataType, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 905 | let iter_values = iter.into_iter().collect::, E>>()?; [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 914 | .finish(Some(&inner.underlying_physical_type())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/array/utf8/mod.rs:486:33 [INFO] [stdout] | [INFO] [stdout] 485 | pub fn apply_validity Bitmap>(&mut self, f: F) { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 486 | if let Some(validity) = std::mem::take(&mut self.validity) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, SharedStorage>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bitmap/immutable.rs:369:15 [INFO] [stdout] | [INFO] [stdout] 368 | pub fn into_mut(mut self) -> Either { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | match self.storage.try_into_vec() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, SharedStorage>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer/immutable.rs:215:15 [INFO] [stdout] | [INFO] [stdout] 210 | pub fn into_mut(mut self) -> Either> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | match self.storage.try_into_vec() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ffi/array.rs:107:22 [INFO] [stdout] | [INFO] [stdout] 107 | let (offset, mut buffers, children, dictionary) = [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/legacy/kernels/rolling/nulls/quantile.rs:221:17 [INFO] [stdout] | [INFO] [stdout] 202 | let values = &PrimitiveArray::new( [INFO] [stdout] | _______________________- [INFO] [stdout] 203 | | ArrowDataType::Float64, [INFO] [stdout] 204 | | buf, [INFO] [stdout] 205 | | Some(Bitmap::from(&[true, false, false, true, true])), [INFO] [stdout] 206 | | ); [INFO] [stdout] | |_________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | let out1 = rolling_min(values, 2, 1, false, None, None); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `utf8view_to_timestamp_impl` is never used [INFO] [stdout] --> src/temporal_conversions.rs:319:4 [INFO] [stdout] | [INFO] [stdout] 319 | fn utf8view_to_timestamp_impl( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `chrono_tz_utf_to_timestamp` is never used [INFO] [stdout] --> src/temporal_conversions.rs:368:4 [INFO] [stdout] | [INFO] [stdout] 368 | fn chrono_tz_utf_to_timestamp( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `utf8view_to_timestamp` is never used [INFO] [stdout] --> src/temporal_conversions.rs:390:15 [INFO] [stdout] | [INFO] [stdout] 390 | pub(crate) fn utf8view_to_timestamp( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `utf8view_to_naive_timestamp` is never used [INFO] [stdout] --> src/temporal_conversions.rs:411:15 [INFO] [stdout] | [INFO] [stdout] 411 | pub(crate) fn utf8view_to_naive_timestamp( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polars-arrow` (lib test) due to 11 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "473769ea789ac02e9ec76f37e96f97c36fb3ae62f96965e859078f04ee9a7822", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "473769ea789ac02e9ec76f37e96f97c36fb3ae62f96965e859078f04ee9a7822", kill_on_drop: false }` [INFO] [stdout] 473769ea789ac02e9ec76f37e96f97c36fb3ae62f96965e859078f04ee9a7822