[INFO] fetching crate piet-hardware 0.5.1... [INFO] checking piet-hardware-0.5.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate piet-hardware 0.5.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate piet-hardware 0.5.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate piet-hardware 0.5.1 [INFO] finished tweaking crates.io crate piet-hardware 0.5.1 [INFO] tweaked toml for crates.io crate piet-hardware 0.5.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate piet-hardware 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a435f2a5e9dae6e19aa88bf3547dbdb74da032cedb5e6e3605dcedc941bcc0a1 [INFO] running `Command { std: "docker" "start" "-a" "a435f2a5e9dae6e19aa88bf3547dbdb74da032cedb5e6e3605dcedc941bcc0a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a435f2a5e9dae6e19aa88bf3547dbdb74da032cedb5e6e3605dcedc941bcc0a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a435f2a5e9dae6e19aa88bf3547dbdb74da032cedb5e6e3605dcedc941bcc0a1", kill_on_drop: false }` [INFO] [stdout] a435f2a5e9dae6e19aa88bf3547dbdb74da032cedb5e6e3605dcedc941bcc0a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0239a2f574426a46ee62642a34c75ad18cbdd4a82ce655c31bda01a3a98dcde8 [INFO] running `Command { std: "docker" "start" "-a" "0239a2f574426a46ee62642a34c75ad18cbdd4a82ce655c31bda01a3a98dcde8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Compiling pkg-config v0.3.29 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking libloading v0.8.1 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling unicode-general-category v0.6.0 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking font-types v0.4.2 [INFO] [stderr] Checking ttf-parser v0.19.2 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking unic-ucd-bidi v0.9.0 [INFO] [stderr] Checking yazi v0.1.6 [INFO] [stderr] Checking zeno v0.2.3 [INFO] [stderr] Checking unicode-bidi-mirroring v0.1.0 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Checking unicode-ccc v0.1.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking unicode-script v0.5.5 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking unic-bidi v0.9.0 [INFO] [stderr] Checking kurbo v0.9.5 [INFO] [stderr] Checking read-fonts v0.15.4 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling wayland-sys v0.30.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Compiling glutin v0.30.10 [INFO] [stderr] Compiling ahash v0.8.8 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling piet-cosmic-text v0.3.4 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Checking rangemap v1.5.0 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking aliasable v0.1.3 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking memmap2 v0.6.2 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Compiling glutin_glx_sys v0.4.0 [INFO] [stderr] Compiling glutin_egl_sys v0.5.1 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking euclid v0.22.9 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Checking piet v0.6.2 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Compiling glutin-winit v0.3.0 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking svg_fmt v0.4.1 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking line-straddler v0.2.3 [INFO] [stderr] Checking float_next_after v1.0.0 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking png v0.17.11 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking web-time v0.2.4 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking lyon_geom v1.0.5 [INFO] [stderr] Checking etagere v0.2.10 [INFO] [stderr] Checking fontdb v0.14.1 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Compiling winit v0.28.7 [INFO] [stderr] Checking lyon_path v1.0.4 [INFO] [stderr] Checking lyon_tessellation v1.0.13 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Compiling bytemuck_derive v1.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking swash v0.1.12 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Checking rustybuzz v0.8.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking image v0.24.8 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking cosmic-text v0.9.0 [INFO] [stderr] Checking piet-hardware v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/brush.rs:64:33 [INFO] [stdout] | [INFO] [stdout] 60 | fn make_brush<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 64 | ) -> Cow<'a, as piet::RenderContext>::Brush> { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/brush.rs:64:37 [INFO] [stdout] | [INFO] [stdout] 60 | fn make_brush<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 64 | ) -> Cow<'a, as piet::RenderContext>::Brush> { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/brush.rs:64:41 [INFO] [stdout] | [INFO] [stdout] 60 | fn make_brush<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 64 | ) -> Cow<'a, as piet::RenderContext>::Brush> { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), piet::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:646:13 [INFO] [stdout] | [INFO] [stdout] 644 | let brush = brush.make_brush(self, || shape.bounding_box()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 645 | if let Err(e) = [INFO] [stdout] 646 | self.stroke_impl(shape, brush.as_ref(), width, &piet::StrokeStyle::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), piet::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:660:25 [INFO] [stdout] | [INFO] [stdout] 659 | let brush = brush.make_brush(self, || shape.bounding_box()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 660 | if let Err(e) = self.stroke_impl(shape, brush.as_ref(), width, style) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), piet::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:667:25 [INFO] [stdout] | [INFO] [stdout] 666 | let brush = brush.make_brush(self, || shape.bounding_box()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 667 | if let Err(e) = self.fill_impl(shape, brush.as_ref(), FillRule::NonZero) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), piet::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:674:25 [INFO] [stdout] | [INFO] [stdout] 673 | let brush = brush.make_brush(self, || shape.bounding_box()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 674 | if let Err(e) = self.fill_impl(shape, brush.as_ref(), FillRule::EvenOdd) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TinySkiaPathAsShape` is never constructed [INFO] [stdout] --> src/rasterizer.rs:356:8 [INFO] [stdout] | [INFO] [stdout] 356 | struct TinySkiaPathAsShape(tiny_skia::Path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `ugly_convert_to_bezpath` is never used [INFO] [stdout] --> src/rasterizer.rs:359:8 [INFO] [stdout] | [INFO] [stdout] 358 | impl TinySkiaPathAsShape { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] 359 | fn ugly_convert_to_bezpath(&self) -> BezPath { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `piet-hardware` (lib) due to 5 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0239a2f574426a46ee62642a34c75ad18cbdd4a82ce655c31bda01a3a98dcde8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0239a2f574426a46ee62642a34c75ad18cbdd4a82ce655c31bda01a3a98dcde8", kill_on_drop: false }` [INFO] [stdout] 0239a2f574426a46ee62642a34c75ad18cbdd4a82ce655c31bda01a3a98dcde8