[INFO] fetching crate pepper 0.31.0... [INFO] checking pepper-0.31.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate pepper 0.31.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate pepper 0.31.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pepper 0.31.0 [INFO] finished tweaking crates.io crate pepper 0.31.0 [INFO] tweaked toml for crates.io crate pepper 0.31.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate pepper 0.31.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 48d8645096eae24ee4131209a61135a1e9b84a350586b560ccbb7b67ca491909 [INFO] running `Command { std: "docker" "start" "-a" "48d8645096eae24ee4131209a61135a1e9b84a350586b560ccbb7b67ca491909", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "48d8645096eae24ee4131209a61135a1e9b84a350586b560ccbb7b67ca491909", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48d8645096eae24ee4131209a61135a1e9b84a350586b560ccbb7b67ca491909", kill_on_drop: false }` [INFO] [stdout] 48d8645096eae24ee4131209a61135a1e9b84a350586b560ccbb7b67ca491909 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f607aa16f1c121821bfaf9ee77d1f37ec335384c35576cb85dfd6da5074385a7 [INFO] running `Command { std: "docker" "start" "-a" "f607aa16f1c121821bfaf9ee77d1f37ec335384c35576cb85dfd6da5074385a7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Checking pepper v0.31.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:219:68 [INFO] [stdout] | [INFO] [stdout] 219 | static mut ORIGINAL_PANIC_HOOK: MaybeUninit> = [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:219:68 [INFO] [stdout] | [INFO] [stdout] 219 | static mut ORIGINAL_PANIC_HOOK: MaybeUninit> = [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `impl ExactSizeIterator + Iterator + '_` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platforms/linux.rs:201:56 [INFO] [stdout] | [INFO] [stdout] 153 | fn run_server(config: ApplicationConfig, listener: UnixListener) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let mut application = match ServerApplication::new(config) { [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let mut client_connections: Vec> = Vec::new(); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | let mut client_write_queue: Vec> = Vec::new(); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let mut processes: Vec> = Vec::new(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | [INFO] [stdout] 168 | let mut events = Vec::new(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let epoll = Epoll::new(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | for (event_read, event_write, source_index) in epoll_events { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:229:22 [INFO] [stdout] | [INFO] [stdout] 229 | let config = ON_PANIC_CONFIG.assume_init_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:245:20 [INFO] [stdout] | [INFO] [stdout] 245 | let hook = ORIGINAL_PANIC_HOOK.assume_init_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/events.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | std::mem::drop(range_deletes); [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut BufferRangeDeletesMutGuard<'_>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 201 - std::mem::drop(range_deletes); [INFO] [stdout] 201 + let _ = range_deletes; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/events.rs:220:17 [INFO] [stdout] | [INFO] [stdout] 220 | std::mem::drop(text_inserts); [INFO] [stdout] | ^^^^^^^^^^^^^^^------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut BufferTextInsertsMutGuard<'_>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 220 - std::mem::drop(text_inserts); [INFO] [stdout] 220 + let _ = text_inserts; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pepper` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `impl ExactSizeIterator + Iterator + '_` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/platforms/linux.rs:201:56 [INFO] [stdout] | [INFO] [stdout] 153 | fn run_server(config: ApplicationConfig, listener: UnixListener) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let mut application = match ServerApplication::new(config) { [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | let mut client_connections: Vec> = Vec::new(); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | let mut client_write_queue: Vec> = Vec::new(); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | let mut processes: Vec> = Vec::new(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | [INFO] [stdout] 168 | let mut events = Vec::new(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let epoll = Epoll::new(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | for (event_read, event_write, source_index) in epoll_events { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:229:22 [INFO] [stdout] | [INFO] [stdout] 229 | let config = ON_PANIC_CONFIG.assume_init_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:245:20 [INFO] [stdout] | [INFO] [stdout] 245 | let hook = ORIGINAL_PANIC_HOOK.assume_init_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/events.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | std::mem::drop(range_deletes); [INFO] [stdout] | ^^^^^^^^^^^^^^^-------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut BufferRangeDeletesMutGuard<'_>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 201 - std::mem::drop(range_deletes); [INFO] [stdout] 201 + let _ = range_deletes; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/events.rs:220:17 [INFO] [stdout] | [INFO] [stdout] 220 | std::mem::drop(text_inserts); [INFO] [stdout] | ^^^^^^^^^^^^^^^------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&mut BufferTextInsertsMutGuard<'_>` [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 220 - std::mem::drop(text_inserts); [INFO] [stdout] 220 + let _ = text_inserts; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pepper` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f607aa16f1c121821bfaf9ee77d1f37ec335384c35576cb85dfd6da5074385a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f607aa16f1c121821bfaf9ee77d1f37ec335384c35576cb85dfd6da5074385a7", kill_on_drop: false }` [INFO] [stdout] f607aa16f1c121821bfaf9ee77d1f37ec335384c35576cb85dfd6da5074385a7