[INFO] fetching crate package-json 0.4.0... [INFO] checking package-json-0.4.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate package-json 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate package-json 0.4.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate package-json 0.4.0 [INFO] finished tweaking crates.io crate package-json 0.4.0 [INFO] tweaked toml for crates.io crate package-json 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 41 packages to latest compatible versions [INFO] [stderr] Adding darling v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding derive_builder v0.12.0 (available: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.12.0 (available: v0.20.1) [INFO] [stderr] Adding derive_builder_macro v0.12.0 (available: v0.20.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding strsim v0.10.0 (available: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5025ae7a317acb5e47424e2f0a50466cabab7f284066622f3752c512b000f23 [INFO] running `Command { std: "docker" "start" "-a" "f5025ae7a317acb5e47424e2f0a50466cabab7f284066622f3752c512b000f23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5025ae7a317acb5e47424e2f0a50466cabab7f284066622f3752c512b000f23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5025ae7a317acb5e47424e2f0a50466cabab7f284066622f3752c512b000f23", kill_on_drop: false }` [INFO] [stdout] f5025ae7a317acb5e47424e2f0a50466cabab7f284066622f3752c512b000f23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d71e098ac488ab07509a2dc673ed548da8055558350221e2a6d313348c84395c [INFO] running `Command { std: "docker" "start" "-a" "d71e098ac488ab07509a2dc673ed548da8055558350221e2a6d313348c84395c", kill_on_drop: false }` [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking tempfile v3.13.0 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking package-json v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result<&schema::PackageJson, anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:276:25 [INFO] [stdout] | [INFO] [stdout] 249 | let dir = tempdir_in(current_dir().unwrap()).expect("create temp_dir failed!"); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | let mut valid_file = File::create(&file_path).expect("create file failed!"); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | if let Ok(json) = manager.read_ref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/manager.rs:327:15 [INFO] [stdout] | [INFO] [stdout] 327 | if let Ok(mut json) = file_writer { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/manager.rs:339:9 [INFO] [stdout] | [INFO] [stdout] 339 | let mut mutable_handler = manager.as_mut(); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `package-json` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d71e098ac488ab07509a2dc673ed548da8055558350221e2a6d313348c84395c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d71e098ac488ab07509a2dc673ed548da8055558350221e2a6d313348c84395c", kill_on_drop: false }` [INFO] [stdout] d71e098ac488ab07509a2dc673ed548da8055558350221e2a6d313348c84395c