[INFO] fetching crate p2p2 0.0.1... [INFO] checking p2p2-0.0.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate p2p2 0.0.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate p2p2 0.0.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate p2p2 0.0.1 [INFO] finished tweaking crates.io crate p2p2 0.0.1 [INFO] tweaked toml for crates.io crate p2p2 0.0.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 81 packages to latest compatible versions [INFO] [stderr] Adding ed25519 v1.5.3 (available: v2.2.3) [INFO] [stderr] Adding env_logger v0.9.3 (available: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding signature v1.6.4 (available: v2.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] acbfab79b1fbc44d96f9271244dfca695c65caf19bb91628b36e1c4ea9b5c0c5 [INFO] running `Command { std: "docker" "start" "-a" "acbfab79b1fbc44d96f9271244dfca695c65caf19bb91628b36e1c4ea9b5c0c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "acbfab79b1fbc44d96f9271244dfca695c65caf19bb91628b36e1c4ea9b5c0c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "acbfab79b1fbc44d96f9271244dfca695c65caf19bb91628b36e1c4ea9b5c0c5", kill_on_drop: false }` [INFO] [stdout] acbfab79b1fbc44d96f9271244dfca695c65caf19bb91628b36e1c4ea9b5c0c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19d6afb9ca2811391636cdd06789c8892c9865dc23d7d070b3204088a9f1b25d [INFO] running `Command { std: "docker" "start" "-a" "19d6afb9ca2811391636cdd06789c8892c9865dc23d7d070b3204088a9f1b25d", kill_on_drop: false }` [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling libsodium-sys v0.2.7 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking sodiumoxide v0.2.7 [INFO] [stderr] Checking p2p2 v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `SecureStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp/rendezvous_server.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 104 | pub async fn start(mut self) -> Result<(), RendezvousServerError> [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let mut stream = SecureStream::wrap(socket); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 117 | let msg = futures::select! { [INFO] [stdout] | _______________________- [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] 118 | | _ = &mut self.stop_channel => break, [INFO] [stdout] 119 | | msg = stream.recv_extra().fuse() => msg [INFO] [stdout] 120 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SecureStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp/rendezvous_server.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 104 | pub async fn start(mut self) -> Result<(), RendezvousServerError> [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let mut stream = SecureStream::wrap(socket); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 117 | let msg = futures::select! { [INFO] [stdout] | _______________________- [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] | |_______________________| [INFO] [stdout] 118 | | _ = &mut self.stop_channel => break, [INFO] [stdout] 119 | | msg = stream.recv_extra().fuse() => msg [INFO] [stdout] 120 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `sodiumoxide::crypto::sign::Signature::new`: use ed25519::Signature::from_bytes instead [INFO] [stdout] --> src/secure_stream/crypto/signing.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | sign::Signature::new(self.signature) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `sodiumoxide::crypto::sign::Signature::new`: use ed25519::Signature::from_bytes instead [INFO] [stdout] --> src/secure_stream/crypto/signing.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | sign::Signature::new(self.signature) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `p2p2` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `SecureStream>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secure_stream/stream.rs:344:17 [INFO] [stdout] | [INFO] [stdout] 319 | let (pk1, sk1) = KeyPair::gen().split(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | let (pk2, sk2) = KeyPair::gen().split(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | let mut stream = SecureStream::wrap_with_dec_context(reader, dc); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SecureStream>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/secure_stream/stream.rs:376:17 [INFO] [stdout] | [INFO] [stdout] 353 | let (pk1, sk1) = KeyPair::gen().split(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 354 | let (pk2, sk2) = KeyPair::gen().split(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | let mut stream = SecureStream::wrap_with_dec_context(reader, dc); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `p2p2` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "19d6afb9ca2811391636cdd06789c8892c9865dc23d7d070b3204088a9f1b25d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19d6afb9ca2811391636cdd06789c8892c9865dc23d7d070b3204088a9f1b25d", kill_on_drop: false }` [INFO] [stdout] 19d6afb9ca2811391636cdd06789c8892c9865dc23d7d070b3204088a9f1b25d