[INFO] fetching crate owasm-crypto 0.3.1... [INFO] checking owasm-crypto-0.3.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate owasm-crypto 0.3.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate owasm-crypto 0.3.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate owasm-crypto 0.3.1 [INFO] finished tweaking crates.io crate owasm-crypto 0.3.1 [INFO] tweaked toml for crates.io crate owasm-crypto 0.3.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 22 packages to latest compatible versions [INFO] [stderr] Adding block-buffer v0.9.0 (available: v0.10.4) [INFO] [stderr] Adding digest v0.9.0 (available: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding num-traits v0.1.43 (available: v0.2.19) [INFO] [stderr] Adding sha2 v0.9.9 (available: v0.10.8) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c47e8fab2bc68ae80f5a3166e2ad7358012e5a3d925533d36dbbb86aafb953c1 [INFO] running `Command { std: "docker" "start" "-a" "c47e8fab2bc68ae80f5a3166e2ad7358012e5a3d925533d36dbbb86aafb953c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c47e8fab2bc68ae80f5a3166e2ad7358012e5a3d925533d36dbbb86aafb953c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c47e8fab2bc68ae80f5a3166e2ad7358012e5a3d925533d36dbbb86aafb953c1", kill_on_drop: false }` [INFO] [stdout] c47e8fab2bc68ae80f5a3166e2ad7358012e5a3d925533d36dbbb86aafb953c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cc23d9a3175438ba40c7d53d3a0ea22d5a9506919c9c03ad0654ee5aed84bfa2 [INFO] running `Command { std: "docker" "start" "-a" "cc23d9a3175438ba40c7d53d3a0ea22d5a9506919c9c03ad0654ee5aed84bfa2", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking rust-gmp v0.5.0 [INFO] [stderr] Checking owasm-crypto v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `(Mpz, Mpz)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecvrf.rs:201:22 [INFO] [stdout] | [INFO] [stdout] 163 | let u = hash_to_field(&[y, alpha].concat()); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | [INFO] [stdout] 165 | let mut tv1 = &u * &u; [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let x1 = inverse(&(&tv1 + 1).modulus(&PRIME)); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let x1 = ((-&*A) * &x1).modulus(&PRIME); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | [INFO] [stdout] 175 | let gx1 = (&x1 + &*A).modulus(&PRIME); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let gx1 = (&gx1 * &x1).modulus(&PRIME); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let gx1 = (&gx1 + 1).modulus(&PRIME); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let gx1 = (&gx1 * &x1).modulus(&PRIME); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | [INFO] [stdout] 180 | let x2 = (-&x1 - &*A).modulus(&PRIME); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | [INFO] [stdout] 182 | let gx2 = (&tv1 * &gx1).modulus(&PRIME); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let (x, gx) = if e2 { (x1, gx1) } else { (x2, gx2) }; [INFO] [stdout] | - -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | [INFO] [stdout] 187 | let edwards_y = (Mpz::from(&x - 1) * inverse(&(&x + 1))).modulus(&PRIME); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let edwards_y_rev: Vec = Vec::from(&edwards_y).into_iter().rev().collect(); [INFO] [stdout] 189 | let mut h_prelim = decode_point(edwards_y_rev.as_slice())?; [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let y_coordinate = ((&*SQRT_MINUS_A_PLUS_2 * &x) * inverse(&h_prelim.0)).modulus(&PRIME); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(encode_point(&scalar_multiply(&h_prelim, &*COFACTOR))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `owasm-crypto` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `(gmp::mpz::Mpz, gmp::mpz::Mpz)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecvrf.rs:201:22 [INFO] [stdout] | [INFO] [stdout] 163 | let u = hash_to_field(&[y, alpha].concat()); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | [INFO] [stdout] 165 | let mut tv1 = &u * &u; [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let x1 = inverse(&(&tv1 + 1).modulus(&PRIME)); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let x1 = ((-&*A) * &x1).modulus(&PRIME); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | [INFO] [stdout] 175 | let gx1 = (&x1 + &*A).modulus(&PRIME); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let gx1 = (&gx1 * &x1).modulus(&PRIME); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let gx1 = (&gx1 + 1).modulus(&PRIME); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let gx1 = (&gx1 * &x1).modulus(&PRIME); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | [INFO] [stdout] 180 | let x2 = (-&x1 - &*A).modulus(&PRIME); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | [INFO] [stdout] 182 | let gx2 = (&tv1 * &gx1).modulus(&PRIME); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let (x, gx) = if e2 { (x1, gx1) } else { (x2, gx2) }; [INFO] [stdout] | - -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | [INFO] [stdout] 187 | let edwards_y = (Mpz::from(&x - 1) * inverse(&(&x + 1))).modulus(&PRIME); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | let edwards_y_rev: Vec = Vec::from(&edwards_y).into_iter().rev().collect(); [INFO] [stdout] 189 | let mut h_prelim = decode_point(edwards_y_rev.as_slice())?; [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let y_coordinate = ((&*SQRT_MINUS_A_PLUS_2 * &x) * inverse(&h_prelim.0)).modulus(&PRIME); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(encode_point(&scalar_multiply(&h_prelim, &*COFACTOR))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `owasm-crypto` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "cc23d9a3175438ba40c7d53d3a0ea22d5a9506919c9c03ad0654ee5aed84bfa2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cc23d9a3175438ba40c7d53d3a0ea22d5a9506919c9c03ad0654ee5aed84bfa2", kill_on_drop: false }` [INFO] [stdout] cc23d9a3175438ba40c7d53d3a0ea22d5a9506919c9c03ad0654ee5aed84bfa2