[INFO] fetching crate oro-common 0.3.34... [INFO] checking oro-common-0.3.34 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate oro-common 0.3.34 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate oro-common 0.3.34 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate oro-common 0.3.34 [INFO] finished tweaking crates.io crate oro-common 0.3.34 [INFO] tweaked toml for crates.io crate oro-common 0.3.34 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 58 packages to latest compatible versions [INFO] [stderr] Adding darling v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding derive_builder v0.11.2 (available: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.11.2 (available: v0.20.1) [INFO] [stderr] Adding derive_builder_macro v0.11.2 (available: v0.20.1) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding miette v5.10.0 (available: v7.2.0) [INFO] [stderr] Adding miette-derive v5.10.0 (available: v7.2.0) [INFO] [stderr] Adding strsim v0.10.0 (available: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8390ed105b92928e80f9506f77d94b55c01e914325fa23aa05c3c3e124182a2a [INFO] running `Command { std: "docker" "start" "-a" "8390ed105b92928e80f9506f77d94b55c01e914325fa23aa05c3c3e124182a2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8390ed105b92928e80f9506f77d94b55c01e914325fa23aa05c3c3e124182a2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8390ed105b92928e80f9506f77d94b55c01e914325fa23aa05c3c3e124182a2a", kill_on_drop: false }` [INFO] [stdout] 8390ed105b92928e80f9506f77d94b55c01e914325fa23aa05c3c3e124182a2a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d040cf33f20b5ebd9cdb33b71b8661ac46b3bb336281b43f8741ffe465f34843 [INFO] running `Command { std: "docker" "start" "-a" "d040cf33f20b5ebd9cdb33b71b8661ac46b3bb336281b43f8741ffe465f34843", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling miette-derive v5.10.0 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.11.2 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking miette v5.10.0 [INFO] [stderr] Compiling derive_builder_macro v0.11.2 [INFO] [stderr] Checking derive_builder v0.11.2 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking node-semver v2.1.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking oro-common v0.3.34 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `manifest::Manifest` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:210:15 [INFO] [stdout] | [INFO] [stdout] 201 | fn from(value: CorgiManifest) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Packument` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packument.rs:46:15 [INFO] [stdout] | [INFO] [stdout] 38 | fn from(value: CorgiPackument) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `packument::VersionMetadata` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packument.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 108 | fn from(value: CorgiVersionMetadata) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `manifest::Manifest` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest.rs:210:15 [INFO] [stdout] | [INFO] [stdout] 201 | fn from(value: CorgiManifest) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/manifest.rs:268:11 [INFO] [stdout] | [INFO] [stdout] 268 | Value(serde_json::Value), [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 268 | Value(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oro-common` (lib test) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Packument` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packument.rs:46:15 [INFO] [stdout] | [INFO] [stdout] 38 | fn from(value: CorgiPackument) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `packument::VersionMetadata` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/packument.rs:113:15 [INFO] [stdout] | [INFO] [stdout] 108 | fn from(value: CorgiVersionMetadata) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/manifest.rs:268:11 [INFO] [stdout] | [INFO] [stdout] 268 | Value(serde_json::Value), [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 268 | Value(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oro-common` (lib) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d040cf33f20b5ebd9cdb33b71b8661ac46b3bb336281b43f8741ffe465f34843", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d040cf33f20b5ebd9cdb33b71b8661ac46b3bb336281b43f8741ffe465f34843", kill_on_drop: false }` [INFO] [stdout] d040cf33f20b5ebd9cdb33b71b8661ac46b3bb336281b43f8741ffe465f34843