[INFO] fetching crate ori-core 0.1.0-alpha.1... [INFO] checking ori-core-0.1.0-alpha.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate ori-core 0.1.0-alpha.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ori-core 0.1.0-alpha.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ori-core 0.1.0-alpha.1 [INFO] finished tweaking crates.io crate ori-core 0.1.0-alpha.1 [INFO] tweaked toml for crates.io crate ori-core 0.1.0-alpha.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 87 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding glam v0.23.0 (available: v0.29.0) [INFO] [stderr] Adding image v0.24.9 (available: v0.25.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (available: v0.8.0) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (available: v3.2.0) [INFO] [stderr] Adding smol_str v0.2.2 (available: v0.3.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding toml_edit v0.19.15 (available: v0.22.22) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding winnow v0.5.40 (available: v0.6.20) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 633aff38b5bb47c5bc8a79fd584800675e12c082bfa50facfbc0de8321d14902 [INFO] running `Command { std: "docker" "start" "-a" "633aff38b5bb47c5bc8a79fd584800675e12c082bfa50facfbc0de8321d14902", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "633aff38b5bb47c5bc8a79fd584800675e12c082bfa50facfbc0de8321d14902", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "633aff38b5bb47c5bc8a79fd584800675e12c082bfa50facfbc0de8321d14902", kill_on_drop: false }` [INFO] [stdout] 633aff38b5bb47c5bc8a79fd584800675e12c082bfa50facfbc0de8321d14902 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 084d22d98993363f7162412f4f2ca15e829a1e3f66dd4d257b7e1fc73165943e [INFO] running `Command { std: "docker" "start" "-a" "084d22d98993363f7162412f4f2ca15e829a1e3f66dd4d257b7e1fc73165943e", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking fdeflate v0.3.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking flate2 v1.0.34 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking png v0.17.14 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling bytemuck_derive v1.7.1 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking pest v2.7.13 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Compiling syn-rsx v0.9.0 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking glam v0.23.0 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Compiling deref-derive v0.1.0 [INFO] [stderr] Compiling ori-macro v0.1.0-alpha.1 [INFO] [stderr] Compiling pest_meta v2.7.13 [INFO] [stderr] Compiling pest_generator v2.7.13 [INFO] [stderr] Compiling pest_derive v2.7.13 [INFO] [stderr] Checking ori-graphics v0.1.0-alpha.1 [INFO] [stderr] Checking ori-core v0.1.0-alpha.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reactive/signal.rs:247:31 [INFO] [stdout] | [INFO] [stdout] 246 | pub fn set(&self, value: T) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | if let Some(signal) = self.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reactive/signal.rs:253:31 [INFO] [stdout] | [INFO] [stdout] 252 | pub fn set_silent(&self, value: T) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | if let Some(signal) = self.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reactive/signal.rs:266:31 [INFO] [stdout] | [INFO] [stdout] 265 | pub fn set_arc(&self, value: Shared) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | if let Some(signal) = self.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reactive/signal.rs:272:31 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn set_arc_silent(&self, value: Shared) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | if let Some(signal) = self.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reactive/signal.rs:247:31 [INFO] [stdout] | [INFO] [stdout] 246 | pub fn set(&self, value: T) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 247 | if let Some(signal) = self.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reactive/signal.rs:253:31 [INFO] [stdout] | [INFO] [stdout] 252 | pub fn set_silent(&self, value: T) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | if let Some(signal) = self.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reactive/signal.rs:266:31 [INFO] [stdout] | [INFO] [stdout] 265 | pub fn set_arc(&self, value: Shared) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | if let Some(signal) = self.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reactive/signal.rs:272:31 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn set_arc_silent(&self, value: Shared) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | if let Some(signal) = self.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/reactive/callback.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | if callback.callback.as_ptr() == ptr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 28 | if std::ptr::addr_eq(callback.callback.as_ptr(), ptr) { [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 28 | if std::ptr::eq(callback.callback.as_ptr(), ptr) { [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/reactive/callback.rs:43:51 [INFO] [stdout] | [INFO] [stdout] 43 | let equals = |callback: &WeakCallback| callback.callback.as_ptr() != ptr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 43 | let equals = |callback: &WeakCallback| !std::ptr::addr_eq(callback.callback.as_ptr(), ptr); [INFO] [stdout] | +++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 43 | let equals = |callback: &WeakCallback| !std::ptr::eq(callback.callback.as_ptr(), ptr); [INFO] [stdout] | ++++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/reactive/scope.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | unsafe { Box::from_raw(item) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 54 | unsafe { let _ = Box::from_raw(item); }; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/reactive/callback.rs:28:16 [INFO] [stdout] | [INFO] [stdout] 28 | if callback.callback.as_ptr() == ptr { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 28 | if std::ptr::addr_eq(callback.callback.as_ptr(), ptr) { [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 28 | if std::ptr::eq(callback.callback.as_ptr(), ptr) { [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/reactive/callback.rs:43:51 [INFO] [stdout] | [INFO] [stdout] 43 | let equals = |callback: &WeakCallback| callback.callback.as_ptr() != ptr; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 43 | let equals = |callback: &WeakCallback| !std::ptr::addr_eq(callback.callback.as_ptr(), ptr); [INFO] [stdout] | +++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 43 | let equals = |callback: &WeakCallback| !std::ptr::eq(callback.callback.as_ptr(), ptr); [INFO] [stdout] | ++++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/reactive/scope.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | unsafe { Box::from_raw(item) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 54 | unsafe { let _ = Box::from_raw(item); }; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ori-core` (lib) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ori-core` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "084d22d98993363f7162412f4f2ca15e829a1e3f66dd4d257b7e1fc73165943e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "084d22d98993363f7162412f4f2ca15e829a1e3f66dd4d257b7e1fc73165943e", kill_on_drop: false }` [INFO] [stdout] 084d22d98993363f7162412f4f2ca15e829a1e3f66dd4d257b7e1fc73165943e