[INFO] fetching crate opt_struct 0.1.3... [INFO] checking opt_struct-0.1.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate opt_struct 0.1.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate opt_struct 0.1.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate opt_struct 0.1.3 [INFO] finished tweaking crates.io crate opt_struct 0.1.3 [INFO] tweaked toml for crates.io crate opt_struct 0.1.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b06e4ae5dea174b5e2bdf2ca0b1d647dba135f66f9b05e8927f24c14f9885983 [INFO] running `Command { std: "docker" "start" "-a" "b06e4ae5dea174b5e2bdf2ca0b1d647dba135f66f9b05e8927f24c14f9885983", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b06e4ae5dea174b5e2bdf2ca0b1d647dba135f66f9b05e8927f24c14f9885983", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b06e4ae5dea174b5e2bdf2ca0b1d647dba135f66f9b05e8927f24c14f9885983", kill_on_drop: false }` [INFO] [stdout] b06e4ae5dea174b5e2bdf2ca0b1d647dba135f66f9b05e8927f24c14f9885983 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f56b97243ae9ad9ad9ebb11a0e6b993d63993f325e8a7629cfe6514a0d59f363 [INFO] running `Command { std: "docker" "start" "-a" "f56b97243ae9ad9ad9ebb11a0e6b993d63993f325e8a7629cfe6514a0d59f363", kill_on_drop: false }` [INFO] [stderr] Checking opt_struct v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `OptVec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn push(&mut self, el: T) { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let mut tmp = OptVec::None; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `vec::OptVec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:120:21 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn push(&mut self, el: T) { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let mut tmp = OptVec::None; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `OptVec10` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/static_vec.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn push(&mut self, el: T) { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | let mut tmp = OptVec10::None; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `static_vec::OptVec10` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/static_vec.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 271 | pub fn push(&mut self, el: T) { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | let mut tmp = OptVec10::None; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `OptSet` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn insert(&mut self, el: T) -> bool { // true if new [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let mut tmp = OptSet::None; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `OptHashSet` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_set.rs:136:21 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn insert(&mut self, el: T) -> bool { // true if new [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let mut tmp = OptHashSet::None; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `OptSet` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/set.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn insert(&mut self, el: T) -> bool { // true if new [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let mut tmp = OptSet::None; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `OptHashMap` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:87:21 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn insert(&mut self, el: T, v: V) -> Option { // some if already present [INFO] [stdout] | -- - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let mut tmp = OptHashMap::None; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/hash_map.rs:215:32 [INFO] [stdout] | [INFO] [stdout] 215 | pub struct TupleMapper<'t,T,V>(&'t (T,V)); [INFO] [stdout] | ----------- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `OptHashSet` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_set.rs:136:21 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn insert(&mut self, el: T) -> bool { // true if new [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let mut tmp = OptHashSet::None; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `opt_struct` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `OptHashMap` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_map.rs:87:21 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn insert(&mut self, el: T, v: V) -> Option { // some if already present [INFO] [stdout] | -- - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let mut tmp = OptHashMap::None; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/hash_map.rs:215:32 [INFO] [stdout] | [INFO] [stdout] 215 | pub struct TupleMapper<'t,T,V>(&'t (T,V)); [INFO] [stdout] | ----------- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `opt_struct` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f56b97243ae9ad9ad9ebb11a0e6b993d63993f325e8a7629cfe6514a0d59f363", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f56b97243ae9ad9ad9ebb11a0e6b993d63993f325e8a7629cfe6514a0d59f363", kill_on_drop: false }` [INFO] [stdout] f56b97243ae9ad9ad9ebb11a0e6b993d63993f325e8a7629cfe6514a0d59f363