[INFO] fetching crate olympia_native 0.2.0... [INFO] checking olympia_native-0.2.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate olympia_native 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate olympia_native 0.2.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate olympia_native 0.2.0 [INFO] finished tweaking crates.io crate olympia_native 0.2.0 [INFO] tweaked toml for crates.io crate olympia_native 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate olympia_native 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d365ac76bedd73a92a9afabb2acae1bd05ad4c456b4b820e67a21961845f309d [INFO] running `Command { std: "docker" "start" "-a" "d365ac76bedd73a92a9afabb2acae1bd05ad4c456b4b820e67a21961845f309d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d365ac76bedd73a92a9afabb2acae1bd05ad4c456b4b820e67a21961845f309d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d365ac76bedd73a92a9afabb2acae1bd05ad4c456b4b820e67a21961845f309d", kill_on_drop: false }` [INFO] [stdout] d365ac76bedd73a92a9afabb2acae1bd05ad4c456b4b820e67a21961845f309d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3d474b94fffade99613e57057177bbef1abef24435e50057c66d3c8afd6cb0dd [INFO] running `Command { std: "docker" "start" "-a" "3d474b94fffade99613e57057177bbef1abef24435e50057c66d3c8afd6cb0dd", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling proc-macro2 v1.0.12 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.19 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling proc-macro-nested v0.1.4 [INFO] [stderr] Compiling proc-macro-hack v0.5.15 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Checking once_cell v1.3.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling gio v0.8.1 [INFO] [stderr] Compiling gdk-pixbuf v0.8.0 [INFO] [stderr] Compiling pango v0.8.0 [INFO] [stderr] Compiling cairo-rs v0.8.1 [INFO] [stderr] Checking futures-io v0.3.5 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling atk v0.8.0 [INFO] [stderr] Compiling gdk v0.12.1 [INFO] [stderr] Checking ahash v0.3.4 [INFO] [stderr] Compiling gtk v0.8.1 [INFO] [stderr] Checking futures-channel v0.3.5 [INFO] [stderr] Checking futures-task v0.3.5 [INFO] [stderr] Compiling hashbrown v0.7.2 [INFO] [stderr] Compiling glib-sys v0.9.1 [INFO] [stderr] Compiling gobject-sys v0.9.1 [INFO] [stderr] Compiling gio-sys v0.9.1 [INFO] [stderr] Compiling pango-sys v0.9.1 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.9.1 [INFO] [stderr] Compiling cairo-sys-rs v0.9.2 [INFO] [stderr] Compiling atk-sys v0.9.1 [INFO] [stderr] Compiling gdk-sys v0.9.1 [INFO] [stderr] Compiling gtk-sys v0.9.2 [INFO] [stderr] Compiling quote v1.0.4 [INFO] [stderr] Compiling pin-project-internal v0.4.14 [INFO] [stderr] Compiling futures-macro v0.3.5 [INFO] [stderr] Compiling derive_more v0.99.5 [INFO] [stderr] Checking pin-project v0.4.14 [INFO] [stderr] Checking futures-util v0.3.5 [INFO] [stderr] Compiling olympia_core v0.3.0 [INFO] [stderr] Compiling olympia_derive v0.3.0 [INFO] [stderr] Checking futures-executor v0.3.5 [INFO] [stderr] Checking glib v0.9.3 [INFO] [stderr] Checking olympia_engine v0.3.0 [INFO] [stderr] Checking olympia_native v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/memory_viewer.rs:270:29 [INFO] [stdout] | [INFO] [stdout] 269 | fn goto_address(self: Rc, address_entry: >k::Entry) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | if let Some(text) = address_entry.get_text() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `breakpoints` is never read [INFO] [stdout] --> src/emulator/emu_thread.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub(crate) struct EmulatorState { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 23 | pub gameboy: Option, [INFO] [stdout] 24 | pub breakpoints: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `context` is never read [INFO] [stdout] --> src/widgets/emulator_display.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 107 | pub struct EmulatorDisplay { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 108 | context: glib::MainContext, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `olympia_native` (bin "olympia_native") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/memory_viewer.rs:270:29 [INFO] [stdout] | [INFO] [stdout] 269 | fn goto_address(self: Rc, address_entry: >k::Entry) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | if let Some(text) = address_entry.get_text() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `glib::GString` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/memory_viewer.rs:319:28 [INFO] [stdout] | [INFO] [stdout] 311 | let (_, _, component) = setup_widget(16); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | assert_eq!(col.get_text().unwrap(), "--"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `glib::GString` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/memory_viewer.rs:344:21 [INFO] [stdout] | [INFO] [stdout] 326 | let (context, emu, component) = setup_widget(16); [INFO] [stdout] | ------- --- --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | col.get_text().unwrap().as_str(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `glib::GString` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/widgets/memory_viewer.rs:403:28 [INFO] [stdout] | [INFO] [stdout] 385 | let (context, emu, component) = setup_widget(16); [INFO] [stdout] | ------- --- --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | assert_eq!(col.get_text().unwrap().as_str(), "00"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `breakpoints` is never read [INFO] [stdout] --> src/emulator/emu_thread.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub(crate) struct EmulatorState { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 23 | pub gameboy: Option, [INFO] [stdout] 24 | pub breakpoints: Vec, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `context` is never read [INFO] [stdout] --> src/widgets/emulator_display.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 107 | pub struct EmulatorDisplay { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 108 | context: glib::MainContext, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `olympia_native` (bin "olympia_native" test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3d474b94fffade99613e57057177bbef1abef24435e50057c66d3c8afd6cb0dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d474b94fffade99613e57057177bbef1abef24435e50057c66d3c8afd6cb0dd", kill_on_drop: false }` [INFO] [stdout] 3d474b94fffade99613e57057177bbef1abef24435e50057c66d3c8afd6cb0dd