[INFO] fetching crate odbc 0.17.0... [INFO] checking odbc-0.17.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate odbc 0.17.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate odbc 0.17.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate odbc 0.17.0 [INFO] finished tweaking crates.io crate odbc 0.17.0 [INFO] tweaked toml for crates.io crate odbc 0.17.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate odbc 0.17.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1e61caea88efbd74f1e33e6d91d4e93e8df638bb7a9254014d9da4cc0a9345af [INFO] running `Command { std: "docker" "start" "-a" "1e61caea88efbd74f1e33e6d91d4e93e8df638bb7a9254014d9da4cc0a9345af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e61caea88efbd74f1e33e6d91d4e93e8df638bb7a9254014d9da4cc0a9345af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e61caea88efbd74f1e33e6d91d4e93e8df638bb7a9254014d9da4cc0a9345af", kill_on_drop: false }` [INFO] [stdout] 1e61caea88efbd74f1e33e6d91d4e93e8df638bb7a9254014d9da4cc0a9345af [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 50a2a8cdc55146fe388d250eba0196f3e449ef7d2beb9338ebf9f1086a800447 [INFO] running `Command { std: "docker" "start" "-a" "50a2a8cdc55146fe388d250eba0196f3e449ef7d2beb9338ebf9f1086a800447", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Compiling odbc-sys v0.8.2 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling encoding_rs v0.8.22 [INFO] [stderr] Compiling doc-comment v0.3.1 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.13 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking odbc-safe v0.5.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking odbc v0.17.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diagnostics.rs:96:58 [INFO] [stdout] | [INFO] [stdout] 96 | fn get_diag_rec(&self, record_number: i16) -> Option<(DiagnosticRecord)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 96 - fn get_diag_rec(&self, record_number: i16) -> Option<(DiagnosticRecord)> { [INFO] [stdout] 96 + fn get_diag_rec(&self, record_number: i16) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/statement/types.rs:714:9 [INFO] [stdout] | [INFO] [stdout] 714 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashSet` [INFO] [stdout] --> src/statement/types.rs:715:9 [INFO] [stdout] | [INFO] [stdout] 715 | use std::collections::HashSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::borrow::Cow` [INFO] [stdout] --> src/statement/types.rs:716:9 [INFO] [stdout] | [INFO] [stdout] 716 | use std::borrow::Cow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/connection.rs:48:31 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn disable_autocommit(mut self) -> std::result::Result, Self> { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/connection.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn enable_autocommit(mut self) -> std::result::Result, Self> { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex v1.3.3 [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/diagnostics.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | ::environment::OS_ENCODING.decode(&message[0..message_length as usize]).0.into_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/environment/list_data_sources.rs:166:21 [INFO] [stdout] | [INFO] [stdout] 166 | ::environment::DB_ENCODING.decode(&buf1[0..(len1 as usize)]).0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/environment/list_data_sources.rs:167:21 [INFO] [stdout] | [INFO] [stdout] 167 | ::environment::DB_ENCODING.decode(&buf2[0..(len2 as usize)]).0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/statement/mod.rs:299:27 [INFO] [stdout] | [INFO] [stdout] 299 | name: ::environment::DB_ENCODING.decode(&name_buffer[..(name_length as usize)]).0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/statement/mod.rs:319:27 [INFO] [stdout] | [INFO] [stdout] 319 | name: ::environment::DB_ENCODING.decode(&name_buffer[..(name_length as usize)]).0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/statement/types.rs:261:17 [INFO] [stdout] | [INFO] [stdout] 261 | unsafe {::environment::DB_ENCODING.decode(buffer).0} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/diagnostics.rs:96:58 [INFO] [stdout] | [INFO] [stdout] 96 | fn get_diag_rec(&self, record_number: i16) -> Option<(DiagnosticRecord)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 96 - fn get_diag_rec(&self, record_number: i16) -> Option<(DiagnosticRecord)> { [INFO] [stdout] 96 + fn get_diag_rec(&self, record_number: i16) -> Option { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `odbc::Environment` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/native_types.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let env = create_environment_v3().unwrap(); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 44 | test_type!(CString, A, CString::new(buf).unwrap()) [INFO] [stdout] | -------------------------------------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `test_type` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `odbc` (test "native_types") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> tests/libs.rs:196:6 [INFO] [stdout] | [INFO] [stdout] 196 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `odbc::Environment` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/input_parameter.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | let env = create_environment_v3().unwrap(); [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | let param = CString::new(buf).unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | test_type!(A, ¶m) [INFO] [stdout] | --------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `test_type` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `odbc` (test "input_parameter") due to 2 previous errors [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/connection.rs:48:31 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn disable_autocommit(mut self) -> std::result::Result, Self> { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/connection.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn enable_autocommit(mut self) -> std::result::Result, Self> { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/diagnostics.rs:113:25 [INFO] [stdout] | [INFO] [stdout] 113 | ::environment::OS_ENCODING.decode(&message[0..message_length as usize]).0.into_owned() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/environment/list_data_sources.rs:166:21 [INFO] [stdout] | [INFO] [stdout] 166 | ::environment::DB_ENCODING.decode(&buf1[0..(len1 as usize)]).0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/environment/list_data_sources.rs:167:21 [INFO] [stdout] | [INFO] [stdout] 167 | ::environment::DB_ENCODING.decode(&buf2[0..(len2 as usize)]).0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/statement/mod.rs:299:27 [INFO] [stdout] | [INFO] [stdout] 299 | name: ::environment::DB_ENCODING.decode(&name_buffer[..(name_length as usize)]).0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/statement/mod.rs:319:27 [INFO] [stdout] | [INFO] [stdout] 319 | name: ::environment::DB_ENCODING.decode(&name_buffer[..(name_length as usize)]).0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/statement/types.rs:261:17 [INFO] [stdout] | [INFO] [stdout] 261 | unsafe {::environment::DB_ENCODING.decode(buffer).0} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "50a2a8cdc55146fe388d250eba0196f3e449ef7d2beb9338ebf9f1086a800447", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50a2a8cdc55146fe388d250eba0196f3e449ef7d2beb9338ebf9f1086a800447", kill_on_drop: false }` [INFO] [stdout] 50a2a8cdc55146fe388d250eba0196f3e449ef7d2beb9338ebf9f1086a800447