[INFO] fetching crate observe 1.2.0... [INFO] checking observe-1.2.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate observe 1.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate observe 1.2.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate observe 1.2.0 [INFO] finished tweaking crates.io crate observe 1.2.0 [INFO] tweaked toml for crates.io crate observe 1.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding float-cmp v0.9.0 (available: v0.10.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding mockall v0.11.4 (available: v0.13.0) [INFO] [stderr] Adding mockall_derive v0.11.4 (available: v0.13.0) [INFO] [stderr] Adding predicates v2.1.5 (available: v3.1.2) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding termtree v0.4.1 (available: v0.5.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 46ba5b32701cb2f10493a2d11d315d4287e29f6ce2e48f5655273dc536e0e491 [INFO] running `Command { std: "docker" "start" "-a" "46ba5b32701cb2f10493a2d11d315d4287e29f6ce2e48f5655273dc536e0e491", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "46ba5b32701cb2f10493a2d11d315d4287e29f6ce2e48f5655273dc536e0e491", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46ba5b32701cb2f10493a2d11d315d4287e29f6ce2e48f5655273dc536e0e491", kill_on_drop: false }` [INFO] [stdout] 46ba5b32701cb2f10493a2d11d315d4287e29f6ce2e48f5655273dc536e0e491 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7848cfe918049420bc241abd1d10d1f41f79c6fa9d1b59ed835f6ef52d4799bf [INFO] running `Command { std: "docker" "start" "-a" "7848cfe918049420bc241abd1d10d1f41f79c6fa9d1b59ed835f6ef52d4799bf", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking enclose v1.2.0 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking observe v1.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `EvaluationInner` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluation.rs:46:3 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn take(self) -> Dependencies { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | self.inner.into_inner().dependencies [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:24:3 [INFO] [stdout] | [INFO] [stdout] 24 | Rc::as_ptr(&self.ptr).eq(&Rc::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 24 | std::ptr::addr_eq(Rc::as_ptr(&self.ptr), Rc::as_ptr(&other.ptr)) [INFO] [stdout] | ++++++++++++++++++ ~ [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 24 | std::ptr::eq(Rc::as_ptr(&self.ptr), Rc::as_ptr(&other.ptr)) [INFO] [stdout] | +++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | Rc::as_ptr(&self.ptr).cmp(&Rc::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 32 | Rc::as_ptr(&self.ptr).cast::<()>().cmp(&Rc::as_ptr(&other.ptr).cast::<()>()) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:38:8 [INFO] [stdout] | [INFO] [stdout] 38 | Some(Rc::as_ptr(&self.ptr).cmp(&Rc::as_ptr(&other.ptr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 38 | Some(Rc::as_ptr(&self.ptr).cast::<()>().cmp(&Rc::as_ptr(&other.ptr).cast::<()>())) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:61:3 [INFO] [stdout] | [INFO] [stdout] 61 | Weak::as_ptr(&self.ptr).eq(&Weak::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 61 | std::ptr::addr_eq(Weak::as_ptr(&self.ptr), Weak::as_ptr(&other.ptr)) [INFO] [stdout] | ++++++++++++++++++ ~ [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 61 | std::ptr::eq(Weak::as_ptr(&self.ptr), Weak::as_ptr(&other.ptr)) [INFO] [stdout] | +++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:69:3 [INFO] [stdout] | [INFO] [stdout] 69 | Weak::as_ptr(&self.ptr).cmp(&Weak::as_ptr(&other.ptr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 69 | Weak::as_ptr(&self.ptr).cast::<()>().cmp(&Weak::as_ptr(&other.ptr).cast::<()>()) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/addr.rs:75:8 [INFO] [stdout] | [INFO] [stdout] 75 | Some(Weak::as_ptr(&self.ptr).cmp(&Weak::as_ptr(&other.ptr))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 75 | Some(Weak::as_ptr(&self.ptr).cast::<()>().cmp(&Weak::as_ptr(&other.ptr).cast::<()>())) [INFO] [stdout] | +++++++++++++ +++++++++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/batch.rs:9:11 [INFO] [stdout] | [INFO] [stdout] 9 | unsafe { STARTED.get() } [INFO] [stdout] | ^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/batch.rs:26:7 [INFO] [stdout] | [INFO] [stdout] 26 | if !STARTED.get() { [INFO] [stdout] | ^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/batch.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | STARTED.set(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/batch.rs:39:7 [INFO] [stdout] | [INFO] [stdout] 39 | if !MICROTASK.get() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/batch.rs:40:4 [INFO] [stdout] | [INFO] [stdout] 40 | MICROTASK.set(true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/batch.rs:49:11 [INFO] [stdout] | [INFO] [stdout] 49 | unsafe { MICROTASK.get() } [INFO] [stdout] | ^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/batch.rs:54:3 [INFO] [stdout] | [INFO] [stdout] 54 | STARTED.set(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/batch.rs:61:30 [INFO] [stdout] | [INFO] [stdout] 61 | let mut borrow = unsafe { CHANGED.borrow_mut() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/reaction.rs:138:5 [INFO] [stdout] | [INFO] [stdout] 138 | / CHANGED [INFO] [stdout] 139 | | .borrow_mut() [INFO] [stdout] | |_________________________________^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `observe` (lib) due to 2 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "7848cfe918049420bc241abd1d10d1f41f79c6fa9d1b59ed835f6ef52d4799bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7848cfe918049420bc241abd1d10d1f41f79c6fa9d1b59ed835f6ef52d4799bf", kill_on_drop: false }` [INFO] [stdout] 7848cfe918049420bc241abd1d10d1f41f79c6fa9d1b59ed835f6ef52d4799bf