[INFO] fetching crate observables 0.1.0... [INFO] checking observables-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate observables 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate observables 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate observables 0.1.0 [INFO] finished tweaking crates.io crate observables 0.1.0 [INFO] tweaked toml for crates.io crate observables 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (available: v2.3.1) [INFO] [stderr] Adding event-listener v2.5.3 (available: v5.3.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 24d0cd3cd9806241dc8b6b91b97bcdb54e89fbb7d87491bc64dd0134e6eced3b [INFO] running `Command { std: "docker" "start" "-a" "24d0cd3cd9806241dc8b6b91b97bcdb54e89fbb7d87491bc64dd0134e6eced3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "24d0cd3cd9806241dc8b6b91b97bcdb54e89fbb7d87491bc64dd0134e6eced3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24d0cd3cd9806241dc8b6b91b97bcdb54e89fbb7d87491bc64dd0134e6eced3b", kill_on_drop: false }` [INFO] [stdout] 24d0cd3cd9806241dc8b6b91b97bcdb54e89fbb7d87491bc64dd0134e6eced3b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c6a33e35bc2a5d1d84a624dba0dd2470b9cc29353e73f41819c40fc3e1e1783 [INFO] running `Command { std: "docker" "start" "-a" "8c6a33e35bc2a5d1d84a624dba0dd2470b9cc29353e73f41819c40fc3e1e1783", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking discard v1.0.4 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling uuid v1.10.0 [INFO] [stderr] Compiling gensym v0.1.1 [INFO] [stderr] Checking futures-signals v0.3.34 [INFO] [stderr] Checking observables v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 29 | let mut recv = self.receiver.recv(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match Pin::new(&mut recv).poll(&mut cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll::Item>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 140 | let mut sig = this.signal.borrow_mut(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let sig = Pin::new(&mut *sig); [INFO] [stdout] 142 | match sig.poll_change(&mut cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&T` instead of dereferencing the inner type [INFO] [stdout] --> src/lib.rs:41:45 [INFO] [stdout] | [INFO] [stdout] 41 | ObservableBorrow::Borrow(x) => x.deref(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/async_channel.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 29 | let mut recv = self.receiver.recv(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match Pin::new(&mut recv).poll(&mut cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `observables` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Poll::Item>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures_signals.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 140 | let mut sig = this.signal.borrow_mut(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let sig = Pin::new(&mut *sig); [INFO] [stdout] 142 | match sig.poll_change(&mut cx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.deref()` on a double reference, which returns `&T` instead of dereferencing the inner type [INFO] [stdout] --> src/lib.rs:41:45 [INFO] [stdout] | [INFO] [stdout] 41 | ObservableBorrow::Borrow(x) => x.deref(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `observables` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "8c6a33e35bc2a5d1d84a624dba0dd2470b9cc29353e73f41819c40fc3e1e1783", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c6a33e35bc2a5d1d84a624dba0dd2470b9cc29353e73f41819c40fc3e1e1783", kill_on_drop: false }` [INFO] [stdout] 8c6a33e35bc2a5d1d84a624dba0dd2470b9cc29353e73f41819c40fc3e1e1783