[INFO] fetching crate nostr-relay-pool 0.35.0... [INFO] checking nostr-relay-pool-0.35.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate nostr-relay-pool 0.35.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate nostr-relay-pool 0.35.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nostr-relay-pool 0.35.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate nostr-relay-pool 0.35.0 [INFO] tweaked toml for crates.io crate nostr-relay-pool 0.35.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate nostr-relay-pool 0.35.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 958a353c9176dfbebea31d3abecdf080238251bc69805d50d49e342fc82a51c2 [INFO] running `Command { std: "docker" "start" "-a" "958a353c9176dfbebea31d3abecdf080238251bc69805d50d49e342fc82a51c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "958a353c9176dfbebea31d3abecdf080238251bc69805d50d49e342fc82a51c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "958a353c9176dfbebea31d3abecdf080238251bc69805d50d49e342fc82a51c2", kill_on_drop: false }` [INFO] [stdout] 958a353c9176dfbebea31d3abecdf080238251bc69805d50d49e342fc82a51c2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3e5e04302ae4f8097414fa543e42b67b5d805247a75bfb1628d13fdcfa6a798c [INFO] running `Command { std: "docker" "start" "-a" "3e5e04302ae4f8097414fa543e42b67b5d805247a75bfb1628d13fdcfa6a798c", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Compiling cc v1.1.16 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Compiling bitcoin-internals v0.3.0 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking tinyvec v1.6.1 [INFO] [stderr] Checking bitcoin-io v0.1.2 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling rustls v0.23.10 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking hex-conservative v0.2.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling bitcoin v0.32.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking bech32 v0.11.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking negentropy v0.4.3 [INFO] [stderr] Checking negentropy v0.3.1 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling secp256k1-sys v0.10.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking regex-automata v0.3.9 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.9.6 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.82 [INFO] [stderr] Checking rustls-webpki v0.102.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking atomic-destructor v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking tungstenite v0.24.0 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking async-utility v0.2.0 [INFO] [stderr] Checking tokio-socks v0.5.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-tungstenite v0.24.0 [INFO] [stderr] Checking bitcoin_hashes v0.14.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking bitcoin-units v0.1.2 [INFO] [stderr] Checking async-wsocket v0.9.0 [INFO] [stderr] Checking base58ck v0.1.0 [INFO] [stderr] Checking secp256k1 v0.29.0 [INFO] [stderr] Checking nostr v0.35.0 [INFO] [stderr] Checking nostr-database v0.35.0 [INFO] [stderr] Checking nostr-relay-builder v0.35.0 [INFO] [stderr] Checking nostr-relay-pool v0.35.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `tokio::sync::MutexGuard<'_, tokio::sync::mpsc::Receiver>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay/internal.rs:574:13 [INFO] [stdout] | [INFO] [stdout] 572 | async fn sender_message_handler(&self, mut ws_tx: Sink) { [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 573 | // Lock receivers [INFO] [stdout] 574 | let mut rx_nostr = self.channels.rx_nostr().await; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 579 | / tokio::select! { [INFO] [stdout] 580 | | // Nostr channel receiver [INFO] [stdout] 581 | | Some(NostrMessage { msgs, shot }) = rx_nostr.recv() => { [INFO] [stdout] 582 | | // Serialize messages to JSON and compose WebSocket text message [INFO] [stdout] ... | [INFO] [stdout] 671 | | else => break [INFO] [stdout] 672 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::MutexGuard<'_, tokio::sync::mpsc::Receiver>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/relay/internal.rs:574:13 [INFO] [stdout] | [INFO] [stdout] 572 | async fn sender_message_handler(&self, mut ws_tx: Sink) { [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 573 | // Lock receivers [INFO] [stdout] 574 | let mut rx_nostr = self.channels.rx_nostr().await; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 579 | / tokio::select! { [INFO] [stdout] 580 | | // Nostr channel receiver [INFO] [stdout] 581 | | Some(NostrMessage { msgs, shot }) = rx_nostr.recv() => { [INFO] [stdout] 582 | | // Serialize messages to JSON and compose WebSocket text message [INFO] [stdout] ... | [INFO] [stdout] 671 | | else => break [INFO] [stdout] 672 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nostr-relay-pool` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nostr-relay-pool` (lib test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "3e5e04302ae4f8097414fa543e42b67b5d805247a75bfb1628d13fdcfa6a798c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e5e04302ae4f8097414fa543e42b67b5d805247a75bfb1628d13fdcfa6a798c", kill_on_drop: false }` [INFO] [stdout] 3e5e04302ae4f8097414fa543e42b67b5d805247a75bfb1628d13fdcfa6a798c