[INFO] fetching crate nixpkgs-fmt 1.3.0... [INFO] checking nixpkgs-fmt-1.3.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate nixpkgs-fmt 1.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate nixpkgs-fmt 1.3.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nixpkgs-fmt 1.3.0 [INFO] finished tweaking crates.io crate nixpkgs-fmt 1.3.0 [INFO] tweaked toml for crates.io crate nixpkgs-fmt 1.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate nixpkgs-fmt 1.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 73f3929f630319af36a5542a4830513a507267cd2bf5c29644248fccf0bde931 [INFO] running `Command { std: "docker" "start" "-a" "73f3929f630319af36a5542a4830513a507267cd2bf5c29644248fccf0bde931", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "73f3929f630319af36a5542a4830513a507267cd2bf5c29644248fccf0bde931", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73f3929f630319af36a5542a4830513a507267cd2bf5c29644248fccf0bde931", kill_on_drop: false }` [INFO] [stdout] 73f3929f630319af36a5542a4830513a507267cd2bf5c29644248fccf0bde931 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4bb309aeb167692ba0e65145071998ba3ccec6384437ccbde5608da30754a3b5 [INFO] running `Command { std: "docker" "start" "-a" "4bb309aeb167692ba0e65145071998ba3ccec6384437ccbde5608da30754a3b5", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling libc v0.2.108 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking countme v2.0.4 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling serde_json v1.0.71 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking unindent v0.1.7 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking cbitset v0.2.0 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking globset v0.4.8 [INFO] [stderr] Checking text-size v1.1.0 [INFO] [stderr] Checking smol_str v0.1.21 [INFO] [stderr] Checking rowan v0.12.6 [INFO] [stderr] Checking ignore v0.4.18 [INFO] [stderr] Checking rnix v0.10.2 [INFO] [stderr] Checking nixpkgs-fmt v1.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `SyntaxNodeChildren` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rules.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 172 | let parent = match element.parent() { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | parent.children().all(|it| match it.kind() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter, rowan::api::SyntaxToken>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rules.rs:366:13 [INFO] [stdout] | [INFO] [stdout] 356 | .map(|x| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | nodes.into_iter().any(|child| match child { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SyntaxNodeChildren` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rules.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 172 | let parent = match element.parent() { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | parent.children().all(|it| match it.kind() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:90:10 [INFO] [stdout] | [INFO] [stdout] 90 | let (mut text, line_endings) = convert_to_unix_line_endings(text); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `indent_value` is never read [INFO] [stdout] --> src/dsl.rs:300:16 [INFO] [stdout] | [INFO] [stdout] 275 | pub(crate) struct IndentRule { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 300 | pub(crate) indent_value: IndentValue, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IndentRule` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter, rowan::api::SyntaxToken>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rules.rs:366:13 [INFO] [stdout] | [INFO] [stdout] 356 | .map(|x| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 366 | nodes.into_iter().any(|child| match child { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nixpkgs-fmt` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:90:10 [INFO] [stdout] | [INFO] [stdout] 90 | let (mut text, line_endings) = convert_to_unix_line_endings(text); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `indent_value` is never read [INFO] [stdout] --> src/dsl.rs:300:16 [INFO] [stdout] | [INFO] [stdout] 275 | pub(crate) struct IndentRule { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 300 | pub(crate) indent_value: IndentValue, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IndentRule` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nixpkgs-fmt` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4bb309aeb167692ba0e65145071998ba3ccec6384437ccbde5608da30754a3b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bb309aeb167692ba0e65145071998ba3ccec6384437ccbde5608da30754a3b5", kill_on_drop: false }` [INFO] [stdout] 4bb309aeb167692ba0e65145071998ba3ccec6384437ccbde5608da30754a3b5