[INFO] fetching crate nitox 0.1.9... [INFO] checking nitox-0.1.9 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate nitox 0.1.9 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate nitox 0.1.9 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nitox 0.1.9 [INFO] finished tweaking crates.io crate nitox 0.1.9 [INFO] tweaked toml for crates.io crate nitox 0.1.9 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 181 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding bytes v0.4.12 (available: v1.7.2) [INFO] [stderr] Adding cast v0.2.7 (available: v0.3.0) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding cloudabi v0.0.3 (available: v0.1.0) [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding criterion v0.2.11 (available: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.3.1 (available: v0.5.0) [INFO] [stderr] Adding crossbeam-deque v0.7.4 (available: v0.8.5) [INFO] [stderr] Adding crossbeam-epoch v0.8.2 (available: v0.9.18) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (available: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (available: v0.8.20) [INFO] [stderr] Adding darling v0.9.0 (available: v0.20.10) [INFO] [stderr] Adding darling_core v0.9.0 (available: v0.20.10) [INFO] [stderr] Adding darling_macro v0.9.0 (available: v0.20.10) [INFO] [stderr] Adding derive_builder v0.7.2 (available: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.5.0 (available: v0.20.1) [INFO] [stderr] Adding env_logger v0.6.2 (available: v0.11.5) [INFO] [stderr] Adding foreign-types v0.3.2 (available: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding futures v0.1.31 (available: v0.3.30) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (available: v2.1.0) [INFO] [stderr] Adding idna v0.1.5 (available: v1.0.2) [INFO] [stderr] Adding itertools v0.8.2 (available: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding lock_api v0.1.5 (available: v0.4.12) [INFO] [stderr] Adding lock_api v0.3.4 (available: v0.4.12) [INFO] [stderr] Adding memoffset v0.5.6 (available: v0.9.1) [INFO] [stderr] Adding mio v0.6.23 (available: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (available: v0.6.0) [INFO] [stderr] Adding parking_lot v0.6.4 (available: v0.12.3) [INFO] [stderr] Adding parking_lot v0.9.0 (available: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.3.1 (available: v0.9.10) [INFO] [stderr] Adding parking_lot_core v0.6.3 (available: v0.9.10) [INFO] [stderr] Adding percent-encoding v1.0.1 (available: v2.3.1) [INFO] [stderr] Adding proc-macro2 v0.4.30 (available: v1.0.86) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding quote v0.6.13 (available: v1.0.37) [INFO] [stderr] Adding rand v0.5.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rand_os v0.1.3 (available: v0.2.2) [INFO] [stderr] Adding rand_xoshiro v0.1.0 (available: v0.6.0) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.1.57 (available: v0.5.6) [INFO] [stderr] Adding rustc_version v0.2.3 (available: v0.4.1) [INFO] [stderr] Adding scopeguard v0.3.3 (available: v1.2.0) [INFO] [stderr] Adding security-framework v2.11.1 (available: v3.0.0) [INFO] [stderr] Adding semver v0.9.0 (available: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (available: v0.10.2) [INFO] [stderr] Adding smallvec v0.6.14 (available: v1.13.2) [INFO] [stderr] Adding strsim v0.7.0 (available: v0.11.1) [INFO] [stderr] Adding syn v0.15.44 (available: v2.0.79) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding synstructure v0.12.6 (available: v0.13.1) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding tokio v0.1.22 (available: v1.40.0) [INFO] [stderr] Adding tokio-tls v0.2.1 (available: v0.3.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding unicode-xid v0.1.0 (available: v0.2.6) [INFO] [stderr] Adding url v1.7.2 (available: v2.5.2) [INFO] [stderr] Adding winapi v0.2.8 (available: v0.3.9) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3a0ac271a16fe967e738d9ce048fca41d9d3f496d8cd1e8ce64eb616fc26b0cf [INFO] running `Command { std: "docker" "start" "-a" "3a0ac271a16fe967e738d9ce048fca41d9d3f496d8cd1e8ce64eb616fc26b0cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3a0ac271a16fe967e738d9ce048fca41d9d3f496d8cd1e8ce64eb616fc26b0cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a0ac271a16fe967e738d9ce048fca41d9d3f496d8cd1e8ce64eb616fc26b0cf", kill_on_drop: false }` [INFO] [stdout] 3a0ac271a16fe967e738d9ce048fca41d9d3f496d8cd1e8ce64eb616fc26b0cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7482758ac97232f09666bcbff4ff67d99ff02d7675f3bdbd1a33bdc4b3916597 [INFO] running `Command { std: "docker" "start" "-a" "7482758ac97232f09666bcbff4ff67d99ff02d7675f3bdbd1a33bdc4b3916597", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling derive_builder v0.7.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking openssl-sys v0.9.103 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking openssl v0.10.66 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stderr] Compiling darling_core v0.9.0 [INFO] [stderr] Checking native-tls v0.2.12 [INFO] [stderr] Compiling darling_macro v0.9.0 [INFO] [stderr] Checking tokio-tls v0.2.1 [INFO] [stderr] Compiling darling v0.9.0 [INFO] [stderr] Compiling derive_builder_core v0.5.0 [INFO] [stderr] Checking nitox v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/client.rs:297:25 [INFO] [stdout] | [INFO] [stdout] 297 | if let Some(mut s) = (*self.rx.subs_tx.write()).get_mut(&cmd.sid) { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/client.rs:297:25 [INFO] [stdout] | [INFO] [stdout] 297 | if let Some(mut s) = (*self.rx.subs_tx.write()).get_mut(&cmd.sid) { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection.rs:92:34 [INFO] [stdout] | [INFO] [stdout] 84 | fn start_send(&mut self, item: Self::SinkItem) -> StartSend { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | if let Some(mut inner) = self.inner.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `other_tx` is never read [INFO] [stdout] --> src/client.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 72 | struct NatsClientMultiplexer { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] 73 | other_tx: Arc>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NatsClientMultiplexer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_NatsError` [INFO] [stdout] 16 | pub enum NatsError { [INFO] [stdout] | --------- `NatsError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_NatsError` [INFO] [stdout] 16 | pub enum NatsError { [INFO] [stdout] | --------- `NatsError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/protocol/error.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_CommandError` [INFO] [stdout] 5 | pub enum CommandError { [INFO] [stdout] | ------------ `CommandError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/protocol/error.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_CommandError` [INFO] [stdout] 5 | pub enum CommandError { [INFO] [stdout] | ------------ `CommandError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/protocol/error.rs:53:39 [INFO] [stdout] | [INFO] [stdout] 53 | #[derive(Debug, Clone, Eq, PartialEq, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_ArgumentValidationError` [INFO] [stdout] 54 | pub enum ArgumentValidationError { [INFO] [stdout] | ----------------------- `ArgumentValidationError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/protocol/error.rs:53:39 [INFO] [stdout] | [INFO] [stdout] 53 | #[derive(Debug, Clone, Eq, PartialEq, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_ArgumentValidationError` [INFO] [stdout] 54 | pub enum ArgumentValidationError { [INFO] [stdout] | ----------------------- `ArgumentValidationError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nitox` (lib) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net/connection.rs:92:34 [INFO] [stdout] | [INFO] [stdout] 84 | fn start_send(&mut self, item: Self::SinkItem) -> StartSend { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | if let Some(mut inner) = self.inner.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `other_tx` is never read [INFO] [stdout] --> src/client.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 72 | struct NatsClientMultiplexer { [INFO] [stdout] | --------------------- field in this struct [INFO] [stdout] 73 | other_tx: Arc>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NatsClientMultiplexer` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_NatsError` [INFO] [stdout] 16 | pub enum NatsError { [INFO] [stdout] | --------- `NatsError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_NatsError` [INFO] [stdout] 16 | pub enum NatsError { [INFO] [stdout] | --------- `NatsError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/protocol/error.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_CommandError` [INFO] [stdout] 5 | pub enum CommandError { [INFO] [stdout] | ------------ `CommandError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/protocol/error.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Debug, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_CommandError` [INFO] [stdout] 5 | pub enum CommandError { [INFO] [stdout] | ------------ `CommandError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/protocol/error.rs:53:39 [INFO] [stdout] | [INFO] [stdout] 53 | #[derive(Debug, Clone, Eq, PartialEq, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_ArgumentValidationError` [INFO] [stdout] 54 | pub enum ArgumentValidationError { [INFO] [stdout] | ----------------------- `ArgumentValidationError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/protocol/error.rs:53:39 [INFO] [stdout] | [INFO] [stdout] 53 | #[derive(Debug, Clone, Eq, PartialEq, Fail)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_ArgumentValidationError` [INFO] [stdout] 54 | pub enum ArgumentValidationError { [INFO] [stdout] | ----------------------- `ArgumentValidationError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nitox` (lib test) due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7482758ac97232f09666bcbff4ff67d99ff02d7675f3bdbd1a33bdc4b3916597", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7482758ac97232f09666bcbff4ff67d99ff02d7675f3bdbd1a33bdc4b3916597", kill_on_drop: false }` [INFO] [stdout] 7482758ac97232f09666bcbff4ff67d99ff02d7675f3bdbd1a33bdc4b3916597