[INFO] fetching crate netty-rs 0.1.0... [INFO] checking netty-rs-0.1.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate netty-rs 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate netty-rs 0.1.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate netty-rs 0.1.0 [INFO] finished tweaking crates.io crate netty-rs 0.1.0 [INFO] tweaked toml for crates.io crate netty-rs 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 62 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef29956c63fb492a26e8c8ffd89f8d4027c6ee6a165baad38327a7b019915684 [INFO] running `Command { std: "docker" "start" "-a" "ef29956c63fb492a26e8c8ffd89f8d4027c6ee6a165baad38327a7b019915684", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef29956c63fb492a26e8c8ffd89f8d4027c6ee6a165baad38327a7b019915684", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef29956c63fb492a26e8c8ffd89f8d4027c6ee6a165baad38327a7b019915684", kill_on_drop: false }` [INFO] [stdout] ef29956c63fb492a26e8c8ffd89f8d4027c6ee6a165baad38327a7b019915684 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6ab3ecc305bfd3e14ccf00ea1530a966b3e26505a0d958bc066cf3f67c03581e [INFO] running `Command { std: "docker" "start" "-a" "6ab3ecc305bfd3e14ccf00ea1530a966b3e26505a0d958bc066cf3f67c03581e", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking netty-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender<(NetworkMessage, std::option::Option, bool, tokio::sync::oneshot::Sender>, Error>>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:597:10 [INFO] [stdout] | [INFO] [stdout] 586 | mut socket: TcpStream, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 587 | mut handle_handshake: H, [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 588 | handle_message: M, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 597 | let (handshake_tx, mut handshake_rx) = channel(CHANNEL_SIZE); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 662 | let r = tokio::select! { [INFO] [stdout] | _____________- [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] 663 | | Result::::Err(e) = listen_for_messages => return Err(e), [INFO] [stdout] 664 | | r = handle_handshake(msg, con) => { [INFO] [stdout] 665 | | match r { [INFO] [stdout] ... | [INFO] [stdout] 671 | | } [INFO] [stdout] 672 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<(NetworkMessage, std::option::Option, bool, tokio::sync::oneshot::Sender>, Error>>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:605:62 [INFO] [stdout] | [INFO] [stdout] 605 | if let Some((msg, timeout, want_reply, os_tx)) = handshake_rx.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 636 | tokio::pin!(timeout); [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 637 | / tokio::select! { [INFO] [stdout] 638 | | s = read_message(&mut socket) => { [INFO] [stdout] 639 | | match s { [INFO] [stdout] 640 | | Ok(s) => { [INFO] [stdout] ... | [INFO] [stdout] 656 | | } [INFO] [stdout] 657 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender<(NetworkMessage, std::option::Option, bool, tokio::sync::oneshot::Sender>, Error>>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:597:10 [INFO] [stdout] | [INFO] [stdout] 586 | mut socket: TcpStream, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 587 | mut handle_handshake: H, [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 588 | handle_message: M, [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 597 | let (handshake_tx, mut handshake_rx) = channel(CHANNEL_SIZE); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 662 | let r = tokio::select! { [INFO] [stdout] | _____________- [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________| [INFO] [stdout] 663 | | Result::::Err(e) = listen_for_messages => return Err(e), [INFO] [stdout] 664 | | r = handle_handshake(msg, con) => { [INFO] [stdout] 665 | | match r { [INFO] [stdout] ... | [INFO] [stdout] 671 | | } [INFO] [stdout] 672 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<(NetworkMessage, std::option::Option, bool, tokio::sync::oneshot::Sender>, Error>>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:605:62 [INFO] [stdout] | [INFO] [stdout] 605 | if let Some((msg, timeout, want_reply, os_tx)) = handshake_rx.recv().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 636 | tokio::pin!(timeout); [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 637 | / tokio::select! { [INFO] [stdout] 638 | | s = read_message(&mut socket) => { [INFO] [stdout] 639 | | match s { [INFO] [stdout] 640 | | Ok(s) => { [INFO] [stdout] ... | [INFO] [stdout] 656 | | } [INFO] [stdout] 657 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netty-rs` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netty-rs` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "6ab3ecc305bfd3e14ccf00ea1530a966b3e26505a0d958bc066cf3f67c03581e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ab3ecc305bfd3e14ccf00ea1530a966b3e26505a0d958bc066cf3f67c03581e", kill_on_drop: false }` [INFO] [stdout] 6ab3ecc305bfd3e14ccf00ea1530a966b3e26505a0d958bc066cf3f67c03581e