[INFO] fetching crate netmod-tcp 0.4.0... [INFO] checking netmod-tcp-0.4.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate netmod-tcp 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate netmod-tcp 0.4.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate netmod-tcp 0.4.0 [INFO] finished tweaking crates.io crate netmod-tcp 0.4.0 [INFO] tweaked toml for crates.io crate netmod-tcp 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 119 packages to latest compatible versions [INFO] [stderr] Adding as-slice v0.1.5 (available: v0.2.1) [INFO] [stderr] Adding async-channel v1.9.0 (available: v2.3.1) [INFO] [stderr] Adding blake2 v0.8.1 (available: v0.10.6) [INFO] [stderr] Adding crypto-mac v0.7.0 (available: v0.11.1) [INFO] [stderr] Adding digest v0.8.1 (available: v0.10.7) [INFO] [stderr] Adding event-listener v2.5.3 (available: v5.3.1) [INFO] [stderr] Adding generic-array v0.12.4 (available: v1.1.0) [INFO] [stderr] Adding generic-array v0.13.3 (available: v1.1.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (available: v0.2.15) [INFO] [stderr] Adding hash32 v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding heapless v0.5.6 (available: v0.8.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding opaque-debug v0.2.3 (available: v0.3.1) [INFO] [stderr] Adding postcard v0.4.3 (available: v1.0.10) [INFO] [stderr] Adding postcard-cobs v0.1.5-pre (available: v0.2.0) [INFO] [stderr] Adding rand v0.7.3 (available: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (available: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (available: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (available: v0.3.2) [INFO] [stderr] Adding subtle v1.0.0 (available: v2.6.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7dee5702b3311eb42bc9797c83ca5a35a63a1ebe1b2bb0a55e75d935c9def69f [INFO] running `Command { std: "docker" "start" "-a" "7dee5702b3311eb42bc9797c83ca5a35a63a1ebe1b2bb0a55e75d935c9def69f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7dee5702b3311eb42bc9797c83ca5a35a63a1ebe1b2bb0a55e75d935c9def69f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7dee5702b3311eb42bc9797c83ca5a35a63a1ebe1b2bb0a55e75d935c9def69f", kill_on_drop: false }` [INFO] [stdout] 7dee5702b3311eb42bc9797c83ca5a35a63a1ebe1b2bb0a55e75d935c9def69f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b1d37c0bb867e5049bc53899674f2b2fbe45d59d19dbd73a25c2b209a8c5a83d [INFO] running `Command { std: "docker" "start" "-a" "b1d37c0bb867e5049bc53899674f2b2fbe45d59d19dbd73a25c2b209a8c5a83d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Compiling heapless v0.5.6 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Checking postcard-cobs v0.1.5-pre [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking hash32 v0.1.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking generic-array v0.13.3 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking blake2 v0.8.1 [INFO] [stderr] Checking as-slice v0.1.5 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-process v2.3.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking async-std v1.13.0 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking ratman-identity v0.6.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking postcard v0.4.3 [INFO] [stderr] Checking conjoiner-engine v1.2.3 [INFO] [stderr] Checking ratman-netmod v0.5.1 [INFO] [stderr] Checking netmod-tcp v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | let mut parts: Vec<_> = p.split(|x| x == ' ').collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:102:17 [INFO] [stdout] | [INFO] [stdout] 102 | let mut parts: Vec<_> = p.split(|x| x == ' ').collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/server.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/server.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 150 | (_, Frame(f)) => self.handle_frame(peer.id, f).await, [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] 151 | (state, Hello { port, _type }) => { [INFO] [stdout] | ------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 155 | (_, Ack) => trace!("Received ACK packet on wrong i/o stream. woops"), [INFO] [stdout] | -------- matches some of the same values [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:124:17 [INFO] [stdout] | [INFO] [stdout] 102 | async fn accept_connection(self: Arc, stream: LockedStream) { [INFO] [stdout] | ---- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let peer = self.routes.get_peer(pid).await.unwrap(); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/server.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/server.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 150 | (_, Frame(f)) => self.handle_frame(peer.id, f).await, [INFO] [stdout] | ------------- matches some of the same values [INFO] [stdout] 151 | (state, Hello { port, _type }) => { [INFO] [stdout] | ------------------------------ matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 155 | (_, Ack) => trace!("Received ACK packet on wrong i/o stream. woops"), [INFO] [stdout] | -------- matches some of the same values [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ collectively making this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:124:17 [INFO] [stdout] | [INFO] [stdout] 102 | async fn accept_connection(self: Arc, stream: LockedStream) { [INFO] [stdout] | ---- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let peer = self.routes.get_peer(pid).await.unwrap(); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 183 | stream: LockedStream, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let s = match _type { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 183 | stream: LockedStream, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | let s = match _type { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/server.rs:156:43 [INFO] [stdout] | [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 156 - (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] 156 + (state, packet) => panic!("state={:?}, packet={:?}", state, packet), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/server.rs:156:43 [INFO] [stdout] | [INFO] [stdout] 156 | (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 156 - (state, packet) => panic!(format!("state={:?}, packet={:?}", state, packet)), [INFO] [stdout] 156 + (state, packet) => panic!("state={:?}, packet={:?}", state, packet), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netmod-tcp` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `netmod-tcp` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b1d37c0bb867e5049bc53899674f2b2fbe45d59d19dbd73a25c2b209a8c5a83d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b1d37c0bb867e5049bc53899674f2b2fbe45d59d19dbd73a25c2b209a8c5a83d", kill_on_drop: false }` [INFO] [stdout] b1d37c0bb867e5049bc53899674f2b2fbe45d59d19dbd73a25c2b209a8c5a83d