[INFO] fetching crate nativeshell_core 0.1.3... [INFO] checking nativeshell_core-0.1.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate nativeshell_core 0.1.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate nativeshell_core 0.1.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nativeshell_core 0.1.3 [INFO] finished tweaking crates.io crate nativeshell_core 0.1.3 [INFO] tweaked toml for crates.io crate nativeshell_core 0.1.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding malloc_buf v0.0.6 (available: v1.0.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3938f906c9c5bda83dda00dec903458acd100ad4c63b1b735b7eb1f98c8c7293 [INFO] running `Command { std: "docker" "start" "-a" "3938f906c9c5bda83dda00dec903458acd100ad4c63b1b735b7eb1f98c8c7293", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3938f906c9c5bda83dda00dec903458acd100ad4c63b1b735b7eb1f98c8c7293", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3938f906c9c5bda83dda00dec903458acd100ad4c63b1b735b7eb1f98c8c7293", kill_on_drop: false }` [INFO] [stdout] 3938f906c9c5bda83dda00dec903458acd100ad4c63b1b735b7eb1f98c8c7293 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 471652aded534de2176465e183974a717b836f009fc024332bc71664b2734d3e [INFO] running `Command { std: "docker" "start" "-a" "471652aded534de2176465e183974a717b836f009fc024332bc71664b2734d3e", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking nativeshell_core v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel/async_method_handler.rs:218:29 [INFO] [stdout] | [INFO] [stdout] 216 | reply: Box bool>, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | ) { [INFO] [stdout] 218 | if let Some(call) = unpack_method_call(message, isolate) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel/method_handler.rs:238:29 [INFO] [stdout] | [INFO] [stdout] 236 | reply: Box bool>, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | ) { [INFO] [stdout] 238 | if let Some(call) = unpack_method_call(message, isolate) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel/message_channel.rs:215:30 [INFO] [stdout] | [INFO] [stdout] 214 | fn handle_reply(&self, reply_id: i64, value: Value) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | if let Some(reply) = self.pending_replies.borrow_mut().remove(&reply_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel/message_channel.rs:290:17 [INFO] [stdout] | [INFO] [stdout] 288 | fn on_nativeport_value_received(&self, v: DartValue) { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | if let DartValue::Array(value) = v { [INFO] [stdout] 290 | let mut iter = value.into_iter(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `CString::from_raw` that must be used [INFO] [stdout] --> src/ffi/value.rs:308:30 [INFO] [stdout] | [INFO] [stdout] 308 | unsafe { CString::from_raw(self.value.as_string) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 308 | unsafe { let _ = CString::from_raw(self.value.as_string); }; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/finalizable_handle.rs:314:14 [INFO] [stdout] | [INFO] [stdout] 314 | unsafe { COUNTER.fetch_add(1, Ordering::SeqCst) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/run_loop.rs:147:14 [INFO] [stdout] | [INFO] [stdout] 147 | unsafe { COUNTER.fetch_add(1, Ordering::SeqCst) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/util/capsule.rs:133:14 [INFO] [stdout] | [INFO] [stdout] 133 | unsafe { COUNTER.fetch_add(1, Ordering::SeqCst) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nativeshell_core` (lib) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel/async_method_handler.rs:218:29 [INFO] [stdout] | [INFO] [stdout] 216 | reply: Box bool>, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | ) { [INFO] [stdout] 218 | if let Some(call) = unpack_method_call(message, isolate) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel/method_handler.rs:238:29 [INFO] [stdout] | [INFO] [stdout] 236 | reply: Box bool>, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | ) { [INFO] [stdout] 238 | if let Some(call) = unpack_method_call(message, isolate) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel/message_channel.rs:215:30 [INFO] [stdout] | [INFO] [stdout] 214 | fn handle_reply(&self, reply_id: i64, value: Value) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | if let Some(reply) = self.pending_replies.borrow_mut().remove(&reply_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel/message_channel.rs:290:17 [INFO] [stdout] | [INFO] [stdout] 288 | fn on_nativeport_value_received(&self, v: DartValue) { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 289 | if let DartValue::Array(value) = v { [INFO] [stdout] 290 | let mut iter = value.into_iter(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `CString::from_raw` that must be used [INFO] [stdout] --> src/ffi/value.rs:308:30 [INFO] [stdout] | [INFO] [stdout] 308 | unsafe { CString::from_raw(self.value.as_string) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 308 | unsafe { let _ = CString::from_raw(self.value.as_string); }; [INFO] [stdout] | +++++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/finalizable_handle.rs:314:14 [INFO] [stdout] | [INFO] [stdout] 314 | unsafe { COUNTER.fetch_add(1, Ordering::SeqCst) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/run_loop.rs:147:14 [INFO] [stdout] | [INFO] [stdout] 147 | unsafe { COUNTER.fetch_add(1, Ordering::SeqCst) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/util/capsule.rs:133:14 [INFO] [stdout] | [INFO] [stdout] 133 | unsafe { COUNTER.fetch_add(1, Ordering::SeqCst) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nativeshell_core` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "471652aded534de2176465e183974a717b836f009fc024332bc71664b2734d3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "471652aded534de2176465e183974a717b836f009fc024332bc71664b2734d3e", kill_on_drop: false }` [INFO] [stdout] 471652aded534de2176465e183974a717b836f009fc024332bc71664b2734d3e