[INFO] fetching crate nakamoto-client 0.4.0... [INFO] checking nakamoto-client-0.4.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate nakamoto-client 0.4.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate nakamoto-client 0.4.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate nakamoto-client 0.4.0 [INFO] finished tweaking crates.io crate nakamoto-client 0.4.0 [INFO] tweaked toml for crates.io crate nakamoto-client 0.4.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 66 packages to latest compatible versions [INFO] [stderr] Adding bech32 v0.9.1 (available: v0.11.0) [INFO] [stderr] Adding bitcoin v0.29.2 (available: v0.32.3) [INFO] [stderr] Adding bitcoin_hashes v0.11.0 (available: v0.14.0) [INFO] [stderr] Adding colored v1.9.4 (available: v2.1.0) [INFO] [stderr] Adding fastrand v1.9.0 (available: v2.1.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding nonempty v0.7.0 (available: v0.10.0) [INFO] [stderr] Adding popol v2.2.0 (available: v3.0.0) [INFO] [stderr] Adding secp256k1 v0.24.3 (available: v0.29.1) [INFO] [stderr] Adding secp256k1-sys v0.6.1 (available: v0.10.1) [INFO] [stderr] Adding socket2 v0.4.10 (available: v0.5.7) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d874566125568456e036114ee1714454456fd200e08cdb26b07c7fd4da3ea5be [INFO] running `Command { std: "docker" "start" "-a" "d874566125568456e036114ee1714454456fd200e08cdb26b07c7fd4da3ea5be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d874566125568456e036114ee1714454456fd200e08cdb26b07c7fd4da3ea5be", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d874566125568456e036114ee1714454456fd200e08cdb26b07c7fd4da3ea5be", kill_on_drop: false }` [INFO] [stdout] d874566125568456e036114ee1714454456fd200e08cdb26b07c7fd4da3ea5be [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] feccaae55a4a8272d481ecf3ddd3853e87b17597a583ecc1001665405d4ad041 [INFO] running `Command { std: "docker" "start" "-a" "feccaae55a4a8272d481ecf3ddd3853e87b17597a583ecc1001665405d4ad041", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking nonempty v0.7.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking popol v2.2.0 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking nakamoto-net v0.4.0 [INFO] [stderr] Checking nakamoto-net-poll v0.4.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tempfile v3.13.0 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Compiling microserde-derive v0.1.13 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Checking microserde v0.1.13 [INFO] [stderr] Checking nakamoto-common v0.4.0 [INFO] [stderr] Checking nakamoto-p2p v0.4.0 [INFO] [stderr] Checking nakamoto-chain v0.4.0 [INFO] [stderr] Checking nakamoto-test v0.4.0 [INFO] [stderr] Checking nakamoto-client v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | mod event; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `event` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use client::*; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | mod event; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/peer.rs:89:55 [INFO] [stdout] | [INFO] [stdout] 89 | fn iter<'a>(&'a self) -> Box + 'a> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/peer.rs:89:69 [INFO] [stdout] | [INFO] [stdout] 89 | fn iter<'a>(&'a self) -> Box + 'a> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | mod event; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `event` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use client::*; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | mod event; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/peer.rs:89:55 [INFO] [stdout] | [INFO] [stdout] 89 | fn iter<'a>(&'a self) -> Box + 'a> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/peer.rs:89:69 [INFO] [stdout] | [INFO] [stdout] 89 | fn iter<'a>(&'a self) -> Box + 'a> { [INFO] [stdout] | -- lifetime `'a` declared here ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `nakamoto_p2p::Config` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 33 | config: Config, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | ..p2p::Config::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nakamoto-client` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `peer::Cache` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/peer.rs:171:17 [INFO] [stdout] | [INFO] [stdout] 142 | let tmp = tempfile::tempdir().unwrap(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let cache = Cache::open(&path).unwrap(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `nakamoto_p2p::Config` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service.rs:52:23 [INFO] [stdout] | [INFO] [stdout] 33 | config: Config, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | ..p2p::Config::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter<(client::Handle, std::net::SocketAddr, JoinHandle<()>)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:108:34 [INFO] [stdout] | [INFO] [stdout] 85 | let cfgs = vec![ [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | for (mut node, _, thread) in nodes.into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `blocks`, `filters`, `commands`, and `loading` are never read [INFO] [stdout] --> src/tests/mock.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct Client { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 37 | pub blocks: chan::Sender<(Block, Height)>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 38 | pub filters: chan::Sender<(BlockFilter, BlockHash, Height)>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 39 | pub subscriber: event::Broadcast, [INFO] [stdout] 40 | pub commands: chan::Receiver, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 41 | pub loading: event::Emitter, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nakamoto-client` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "feccaae55a4a8272d481ecf3ddd3853e87b17597a583ecc1001665405d4ad041", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "feccaae55a4a8272d481ecf3ddd3853e87b17597a583ecc1001665405d4ad041", kill_on_drop: false }` [INFO] [stdout] feccaae55a4a8272d481ecf3ddd3853e87b17597a583ecc1001665405d4ad041