[INFO] fetching crate mycorrh 0.1.1... [INFO] checking mycorrh-0.1.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate mycorrh 0.1.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mycorrh 0.1.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mycorrh 0.1.1 [INFO] finished tweaking crates.io crate mycorrh 0.1.1 [INFO] tweaked toml for crates.io crate mycorrh 0.1.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b57ef87e35a27350d6384c6fabc1c3e21d491875375e06cb70283632041e2c79 [INFO] running `Command { std: "docker" "start" "-a" "b57ef87e35a27350d6384c6fabc1c3e21d491875375e06cb70283632041e2c79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b57ef87e35a27350d6384c6fabc1c3e21d491875375e06cb70283632041e2c79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b57ef87e35a27350d6384c6fabc1c3e21d491875375e06cb70283632041e2c79", kill_on_drop: false }` [INFO] [stdout] b57ef87e35a27350d6384c6fabc1c3e21d491875375e06cb70283632041e2c79 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1d730d2ef3b24e89c72e8c9e191f83733d6e54bc3fc1c611179695b58f0bc4d0 [INFO] running `Command { std: "docker" "start" "-a" "1d730d2ef3b24e89c72e8c9e191f83733d6e54bc3fc1c611179695b58f0bc4d0", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Checking mycorrh v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> src/lib.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | let (res_1) = tokio::join!(task_1); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 289 - let (res_1) = tokio::join!(task_1); [INFO] [stdout] 289 + let res_1 = tokio::join!(task_1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn new(mut message_tx: Sender>) -> Self { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `UnboundedSender>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn callback_ok(self, data: R) -> Result<(), MessageError, E>> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | / self.callback [INFO] [stdout] 344 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `UnboundedSender>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:367:9 [INFO] [stdout] | [INFO] [stdout] 366 | pub fn callback_err(self, err: E) -> Result<(), MessageError, E>> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | / self.callback [INFO] [stdout] 368 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mycorrh` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:109:29 [INFO] [stdout] | [INFO] [stdout] 101 | let mut message_rx = message_rx; [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | / tokio::select! { [INFO] [stdout] 108 | | [INFO] [stdout] 109 | | m = message_rx.recv() => { [INFO] [stdout] | | ^ [INFO] [stdout] 110 | | if let Some(m) = m { [INFO] [stdout] ... | [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________________| [INFO] [stdout] | |_________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:92:30 [INFO] [stdout] | [INFO] [stdout] 92 | let (message_tx, mut message_rx) = mpsc::channel::(256); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/message.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn new(mut message_tx: Sender>) -> Self { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `UnboundedSender>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 342 | pub fn callback_ok(self, data: R) -> Result<(), MessageError, E>> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | / self.callback [INFO] [stdout] 344 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `UnboundedSender>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message.rs:367:9 [INFO] [stdout] | [INFO] [stdout] 366 | pub fn callback_err(self, err: E) -> Result<(), MessageError, E>> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | / self.callback [INFO] [stdout] 368 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `res_1` [INFO] [stdout] --> src/lib.rs:289:14 [INFO] [stdout] | [INFO] [stdout] 289 | let (res_1) = tokio::join!(task_1); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_res_1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Decrement` is never constructed [INFO] [stdout] --> src/lib.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 26 | enum TestMessage { [INFO] [stdout] | ----------- variant in this enum [INFO] [stdout] 27 | Increment, [INFO] [stdout] 28 | Decrement, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestMessage` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `FailedToDecrement` is never constructed [INFO] [stdout] --> src/lib.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 49 | enum TestError { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 52 | FailedToDecrement, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `decrement` is never used [INFO] [stdout] --> src/lib.rs:172:22 [INFO] [stdout] | [INFO] [stdout] 90 | impl TestEventLoop { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 172 | pub async fn decrement(&self) -> Result<(), TestError> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mycorrh` (lib test) due to 4 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1d730d2ef3b24e89c72e8c9e191f83733d6e54bc3fc1c611179695b58f0bc4d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d730d2ef3b24e89c72e8c9e191f83733d6e54bc3fc1c611179695b58f0bc4d0", kill_on_drop: false }` [INFO] [stdout] 1d730d2ef3b24e89c72e8c9e191f83733d6e54bc3fc1c611179695b58f0bc4d0