[INFO] fetching crate mssf-core 0.0.10... [INFO] checking mssf-core-0.0.10 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate mssf-core 0.0.10 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate mssf-core 0.0.10 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mssf-core 0.0.10 [INFO] finished tweaking crates.io crate mssf-core 0.0.10 [INFO] tweaked toml for crates.io crate mssf-core 0.0.10 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 57 packages to latest compatible versions [INFO] [stderr] Adding mssf-com v0.0.10 (available: v0.0.11) [INFO] [stderr] Adding mssf-pal v0.0.10 (available: v0.0.11) [INFO] [stderr] Adding windows v0.57.0 (available: v0.58.0) [INFO] [stderr] Adding windows-core v0.57.0 (available: v0.58.0) [INFO] [stderr] Adding windows-implement v0.57.0 (available: v0.58.0) [INFO] [stderr] Adding windows-interface v0.57.0 (available: v0.58.0) [INFO] [stderr] Adding windows-result v0.1.2 (available: v0.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5902f1d33c29e23fa657b8395c829cfe86b70ffc56087622619f689daff66d2 [INFO] running `Command { std: "docker" "start" "-a" "a5902f1d33c29e23fa657b8395c829cfe86b70ffc56087622619f689daff66d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5902f1d33c29e23fa657b8395c829cfe86b70ffc56087622619f689daff66d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5902f1d33c29e23fa657b8395c829cfe86b70ffc56087622619f689daff66d2", kill_on_drop: false }` [INFO] [stdout] a5902f1d33c29e23fa657b8395c829cfe86b70ffc56087622619f689daff66d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 30be1bf7796b5e3581a234eafbde6ab4bd9742a2b0c7be66d41081143bac3300 [INFO] running `Command { std: "docker" "start" "-a" "30be1bf7796b5e3581a234eafbde6ab4bd9742a2b0c7be66d41081143bac3300", kill_on_drop: false }` [INFO] [stderr] Compiling windows_x86_64_gnu v0.52.6 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling mssf-com v0.0.10 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling windows-implement v0.57.0 [INFO] [stderr] Compiling windows-interface v0.57.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling trait-variant v0.1.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking windows-targets v0.52.6 [INFO] [stderr] Checking windows-result v0.1.2 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking windows-core v0.57.0 [INFO] [stderr] Checking windows v0.57.0 [INFO] [stderr] Checking ctrlc v3.4.5 [INFO] [stderr] Checking config v0.14.0 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking mssf-pal v0.0.10 [INFO] [stderr] Checking mssf-core v0.0.10 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `(Option, bool)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/cancel.rs:488:19 [INFO] [stdout] | [INFO] [stdout] 488 | match (token, ignore_cancel) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 489 | (Some(t), false) => { [INFO] [stdout] 490 | / select! { [INFO] [stdout] 491 | | _ = t.cancelled() => { [INFO] [stdout] 492 | | // The token was cancelled [INFO] [stdout] 493 | | Err(FabricErrorCode::OperationCanceled.into()) [INFO] [stdout] ... | [INFO] [stdout] 497 | | } [INFO] [stdout] 498 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio_util::sync::CancellationToken` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/cancel.rs:518:22 [INFO] [stdout] | [INFO] [stdout] 512 | token: Option, [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | Some(t) => { [INFO] [stdout] | ^ [INFO] [stdout] 519 | / select! { [INFO] [stdout] 520 | | _ = t.cancelled() => { [INFO] [stdout] 521 | | // The token was cancelled [INFO] [stdout] 522 | | Err(FabricErrorCode::OperationCanceled.into()) [INFO] [stdout] ... | [INFO] [stdout] 526 | | } [INFO] [stdout] 527 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `HSTRING` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/error.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 14 | let sf_err = unsafe { FabricGetLastErrorMessage() }.unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Error::new(code, HSTRING::from_wide(err_str).unwrap().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `IFabricPrimaryReplicator` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/stateful_bridge.rs:534:17 [INFO] [stdout] | [INFO] [stdout] 532 | let bridge: IFabricPrimaryReplicator = [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | IFabricPrimaryReplicatorBridge::create(s, rt_cp).into(); [INFO] [stdout] 534 | bridge.clone().cast::().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client/tests.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 22 | let c = FabricClient::new(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | let qc = c.get_query_manager(); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let smgr = c.get_service_manager(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | let res = smgr [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `HSTRING` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/error.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 14 | let sf_err = unsafe { FabricGetLastErrorMessage() }.unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Error::new(code, HSTRING::from_wide(err_str).unwrap().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio_util::sync::CancellationToken` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/cancel.rs:300:25 [INFO] [stdout] | [INFO] [stdout] 291 | pub fn send(self, data: T) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | let e = self.tx.send(data); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | if let Some(t) = self.token { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `IFabricPrimaryReplicator` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/stateful_bridge.rs:534:17 [INFO] [stdout] | [INFO] [stdout] 532 | let bridge: IFabricPrimaryReplicator = [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | IFabricPrimaryReplicatorBridge::create(s, rt_cp).into(); [INFO] [stdout] 534 | bridge.clone().cast::().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mssf-core` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `tokio_util::sync::CancellationToken` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/cancel.rs:300:25 [INFO] [stdout] | [INFO] [stdout] 291 | pub fn send(self, data: T) { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | let e = self.tx.send(data); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | if let Some(t) = self.token { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mssf-core` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "30be1bf7796b5e3581a234eafbde6ab4bd9742a2b0c7be66d41081143bac3300", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30be1bf7796b5e3581a234eafbde6ab4bd9742a2b0c7be66d41081143bac3300", kill_on_drop: false }` [INFO] [stdout] 30be1bf7796b5e3581a234eafbde6ab4bd9742a2b0c7be66d41081143bac3300