[INFO] fetching crate mser_macro 1.0.10... [INFO] checking mser_macro-1.0.10 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate mser_macro 1.0.10 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate mser_macro 1.0.10 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mser_macro 1.0.10 [INFO] finished tweaking crates.io crate mser_macro 1.0.10 [INFO] tweaked toml for crates.io crate mser_macro 1.0.10 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 81204e7c6adeb8fbb7836d2ce2344f3055a1999d76e53896e9e4a03c51cf2ffe [INFO] running `Command { std: "docker" "start" "-a" "81204e7c6adeb8fbb7836d2ce2344f3055a1999d76e53896e9e4a03c51cf2ffe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "81204e7c6adeb8fbb7836d2ce2344f3055a1999d76e53896e9e4a03c51cf2ffe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "81204e7c6adeb8fbb7836d2ce2344f3055a1999d76e53896e9e4a03c51cf2ffe", kill_on_drop: false }` [INFO] [stdout] 81204e7c6adeb8fbb7836d2ce2344f3055a1999d76e53896e9e4a03c51cf2ffe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f21bc1a36bfe6b3beefb3afebf8720c24859f5ede398190307dc645fe7bcfdfd [INFO] running `Command { std: "docker" "start" "-a" "f21bc1a36bfe6b3beefb3afebf8720c24859f5ede398190307dc645fe7bcfdfd", kill_on_drop: false }` [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking syn v2.0.79 [INFO] [stderr] Checking mser v1.2.3 [INFO] [stderr] Checking mser_macro v1.0.10 (/opt/rustwide/workdir) [INFO] [stdout] error[E0603]: tuple struct constructor `UnsafeWriter` is private [INFO] [stdout] --> src/lib.rs:28:44 [INFO] [stdout] | [INFO] [stdout] 28 | mser::Write::write(&output, &mut mser::UnsafeWriter(data.as_mut_ptr())); [INFO] [stdout] | ^^^^^^^^^^^^ private tuple struct constructor [INFO] [stdout] | [INFO] [stdout] ::: /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/mser-1.2.3/src/writer.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct UnsafeWriter(pub(crate) *mut u8); [INFO] [stdout] | ------------------ a constructor is private if any of the fields is private [INFO] [stdout] | [INFO] [stdout] note: the tuple struct constructor `UnsafeWriter` is defined here [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/mser-1.2.3/src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub use self::writer::UnsafeWriter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0603]: tuple struct constructor `UnsafeWriter` is private [INFO] [stdout] --> src/lib.rs:28:44 [INFO] [stdout] | [INFO] [stdout] 28 | mser::Write::write(&output, &mut mser::UnsafeWriter(data.as_mut_ptr())); [INFO] [stdout] | ^^^^^^^^^^^^ private tuple struct constructor [INFO] [stdout] | [INFO] [stdout] ::: /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/mser-1.2.3/src/writer.rs:1:25 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct UnsafeWriter(pub(crate) *mut u8); [INFO] [stdout] | ------------------ a constructor is private if any of the fields is private [INFO] [stdout] | [INFO] [stdout] note: the tuple struct constructor `UnsafeWriter` is defined here [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/mser-1.2.3/src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | pub use self::writer::UnsafeWriter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0782]: trait objects must include the `dyn` keyword [INFO] [stdout] --> src/lib.rs:26:15 [INFO] [stdout] | [INFO] [stdout] 26 | let len = mser::Write::len(&output); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: add `dyn` keyword before this trait [INFO] [stdout] | [INFO] [stdout] 26 | let len = ::len(&output); [INFO] [stdout] | ++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0782]: trait objects must include the `dyn` keyword [INFO] [stdout] --> src/lib.rs:26:15 [INFO] [stdout] | [INFO] [stdout] 26 | let len = mser::Write::len(&output); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: add `dyn` keyword before this trait [INFO] [stdout] | [INFO] [stdout] 26 | let len = ::len(&output); [INFO] [stdout] | ++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0599]: the function or associated item `len` exists for trait object `Write`, but its trait bounds were not satisfied [INFO] [stdout] --> src/lib.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 26 | let len = mser::Write::len(&output); [INFO] [stdout] | ^^^ function or associated item cannot be called on `Write` due to unsatisfied trait bounds [INFO] [stdout] | [INFO] [stdout] ::: /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/mser-1.2.3/src/lib.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | pub trait Write { [INFO] [stdout] | --------------- doesn't satisfy `dyn mser::Write: ExactSizeIterator` [INFO] [stdout] | [INFO] [stdout] = note: the following trait bounds were not satisfied: [INFO] [stdout] `dyn mser::Write: ExactSizeIterator` [INFO] [stdout] which is required by `&mut dyn mser::Write: ExactSizeIterator` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error[E0599]: the function or associated item `len` exists for trait object `Write`, but its trait bounds were not satisfied [INFO] [stdout] --> src/lib.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 26 | let len = mser::Write::len(&output); [INFO] [stdout] | ^^^ function or associated item cannot be called on `Write` due to unsatisfied trait bounds [INFO] [stdout] | [INFO] [stdout] ::: /opt/rustwide/cargo-home/registry/src/index.crates.io-6f17d22bba15001f/mser-1.2.3/src/lib.rs:28:1 [INFO] [stdout] | [INFO] [stdout] 28 | pub trait Write { [INFO] [stdout] | --------------- doesn't satisfy `dyn mser::Write: ExactSizeIterator` [INFO] [stdout] | [INFO] [stdout] = note: the following trait bounds were not satisfied: [INFO] [stdout] `dyn mser::Write: ExactSizeIterator` [INFO] [stdout] which is required by `&mut dyn mser::Write: ExactSizeIterator` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ToplevelStructAttributes` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn impl_writable(input: syn::DeriveInput) -> Result { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let name = &input.ident; [INFO] [stdout] 13 | let mut types = Vec::new(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let attrs = collect_toplevel_struct_attributes(attrs)?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 41 | quote!(::mser::Write::write(&#x, w);), [INFO] [stdout] | ------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | quote!(::mser::Write::len(&#x) #(+ #needed)*), [INFO] [stdout] | --------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ), [INFO] [stdout] 44 | None => (quote!(), quote!(#(#needed)+*)), [INFO] [stdout] | -------- -------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(quote! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 50 | | #[automatically_derived] [INFO] [stdout] 51 | | impl<#impl_params> ::mser::Write for #name #ty_params #where_clause { [INFO] [stdout] 52 | | #[inline] [INFO] [stdout] ... | [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ToplevelStructAttributes` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writable.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn impl_writable(input: syn::DeriveInput) -> Result { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | let name = &input.ident; [INFO] [stdout] 13 | let mut types = Vec::new(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | let attrs = collect_toplevel_struct_attributes(attrs)?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 41 | quote!(::mser::Write::write(&#x, w);), [INFO] [stdout] | ------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | quote!(::mser::Write::len(&#x) #(+ #needed)*), [INFO] [stdout] | --------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ), [INFO] [stdout] 44 | None => (quote!(), quote!(#(#needed)+*)), [INFO] [stdout] | -------- -------------------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(quote! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 50 | | #[automatically_derived] [INFO] [stdout] 51 | | impl<#impl_params> ::mser::Write for #name #ty_params #where_clause { [INFO] [stdout] 52 | | #[inline] [INFO] [stdout] ... | [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0599, E0603, E0782. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0599`. [INFO] [stdout] [INFO] [stderr] error: could not compile `mser_macro` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] Some errors have detailed explanations: E0599, E0603, E0782. [INFO] [stdout] [INFO] [stdout] For more information about an error, try `rustc --explain E0599`. [INFO] [stdout] [INFO] [stderr] error: could not compile `mser_macro` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "f21bc1a36bfe6b3beefb3afebf8720c24859f5ede398190307dc645fe7bcfdfd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f21bc1a36bfe6b3beefb3afebf8720c24859f5ede398190307dc645fe7bcfdfd", kill_on_drop: false }` [INFO] [stdout] f21bc1a36bfe6b3beefb3afebf8720c24859f5ede398190307dc645fe7bcfdfd