[INFO] fetching crate mp4parse 0.17.0... [INFO] checking mp4parse-0.17.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate mp4parse 0.17.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate mp4parse 0.17.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mp4parse 0.17.0 [INFO] finished tweaking crates.io crate mp4parse 0.17.0 [INFO] tweaked toml for crates.io crate mp4parse 0.17.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 85 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (available: v4.5.18) [INFO] [stderr] Adding clap_lex v0.2.4 (available: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (available: v0.5.1) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hashbrown v0.13.2 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (available: v7.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 60d1221c787032a59e0a78c3deb3ed1bf2c1acb82dc723e135ff0dda14ba0d76 [INFO] running `Command { std: "docker" "start" "-a" "60d1221c787032a59e0a78c3deb3ed1bf2c1acb82dc723e135ff0dda14ba0d76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "60d1221c787032a59e0a78c3deb3ed1bf2c1acb82dc723e135ff0dda14ba0d76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60d1221c787032a59e0a78c3deb3ed1bf2c1acb82dc723e135ff0dda14ba0d76", kill_on_drop: false }` [INFO] [stdout] 60d1221c787032a59e0a78c3deb3ed1bf2c1acb82dc723e135ff0dda14ba0d76 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc43b47361e1c5327452bfc1959f21ae1eba1033596679e2ca428ae2d5cfdaf9 [INFO] running `Command { std: "docker" "start" "-a" "fc43b47361e1c5327452bfc1959f21ae1eba1033596679e2ca428ae2d5cfdaf9", kill_on_drop: false }` [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking bitreader v0.3.8 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking fallible_collections v0.4.9 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking test-assembler v0.1.6 [INFO] [stderr] Checking mp4parse v0.17.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking clap v3.2.25 [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lib.rs:2313:45 [INFO] [stdout] | [INFO] [stdout] 2313 | fn box_iter<'b>(&'b mut self) -> BoxIter> { [INFO] [stdout] | -- ^ this elided lifetime gets resolved as `'b` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'b` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lib.rs:2313:45 [INFO] [stdout] | [INFO] [stdout] 2313 | fn box_iter<'b>(&'b mut self) -> BoxIter> { [INFO] [stdout] | -- ^ this elided lifetime gets resolved as `'b` [INFO] [stdout] | | [INFO] [stdout] | lifetime `'b` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `AvifContext` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/public.rs:1162:16 [INFO] [stdout] | [INFO] [stdout] 1159 | for_strictness_result(path, |strictness, result| { [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1162 | Ok(context) if essential => assert_eq!( [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/public.rs:1229:11 [INFO] [stdout] | [INFO] [stdout] 1228 | let input = &mut File::open(AVIF_AVIS_MAJOR_NO_PITM).expect("Unknown file"); [INFO] [stdout] | ---------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1229 | match mp4::read_avif(input, ParseStrictness::Normal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/public.rs:1242:11 [INFO] [stdout] | [INFO] [stdout] 1241 | let input = &mut File::open(AVIF_AVIS_MAJOR_WITH_PITM_AND_ALPHA).expect("Unknown file"); [INFO] [stdout] | ---------------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1242 | match mp4::read_avif(input, ParseStrictness::Normal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/public.rs:1267:11 [INFO] [stdout] | [INFO] [stdout] 1266 | let input = &mut File::open(AVIF_AVIS_WITH_NO_PITM_NO_ILOC).expect("Unknown file"); [INFO] [stdout] | ----------------------------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1267 | match mp4::read_avif(input, ParseStrictness::Normal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/public.rs:1311:11 [INFO] [stdout] | [INFO] [stdout] 1310 | let input = &mut File::open(path).expect("Unknown file"); [INFO] [stdout] | --------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1311 | match mp4::read_avif(input, ParseStrictness::Normal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mp4parse` (test "public") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "fc43b47361e1c5327452bfc1959f21ae1eba1033596679e2ca428ae2d5cfdaf9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc43b47361e1c5327452bfc1959f21ae1eba1033596679e2ca428ae2d5cfdaf9", kill_on_drop: false }` [INFO] [stdout] fc43b47361e1c5327452bfc1959f21ae1eba1033596679e2ca428ae2d5cfdaf9