[INFO] fetching crate molt 0.3.1... [INFO] checking molt-0.3.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate molt 0.3.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate molt 0.3.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate molt 0.3.1 [INFO] finished tweaking crates.io crate molt 0.3.1 [INFO] tweaked toml for crates.io crate molt 0.3.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fcd8fbbd4065e7c89594217b11784217b44d79fb0eef4ef1e7a81d226c4f83fa [INFO] running `Command { std: "docker" "start" "-a" "fcd8fbbd4065e7c89594217b11784217b44d79fb0eef4ef1e7a81d226c4f83fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fcd8fbbd4065e7c89594217b11784217b44d79fb0eef4ef1e7a81d226c4f83fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcd8fbbd4065e7c89594217b11784217b44d79fb0eef4ef1e7a81d226c4f83fa", kill_on_drop: false }` [INFO] [stdout] fcd8fbbd4065e7c89594217b11784217b44d79fb0eef4ef1e7a81d226c4f83fa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1bee002752b33e5fa5de057daa45b82491c1d411c683d1d1d78673b229574a33 [INFO] running `Command { std: "docker" "start" "-a" "1bee002752b33e5fa5de057daa45b82491c1d411c683d1d1d78673b229574a33", kill_on_drop: false }` [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking molt v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `slice` is never used [INFO] [stdout] --> src/util.rs:179:8 [INFO] [stdout] | [INFO] [stdout] 177 | pub(crate) trait StringUtils { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] 178 | fn substring(&self, start: usize, len: usize) -> &str; [INFO] [stdout] 179 | fn slice(&self, range: impl RangeBounds) -> &str; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `as_any`, `as_any_mut`, and `into_any` are never used [INFO] [stdout] --> src/value.rs:1097:8 [INFO] [stdout] | [INFO] [stdout] 1096 | trait MoltAny: Any + Display + Debug { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 1097 | fn as_any(&self) -> &dyn Any; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 1098 | fn as_any_mut(&mut self) -> &mut dyn Any; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 1099 | fn into_any(self: Box) -> Box; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:928:24 [INFO] [stdout] | [INFO] [stdout] 913 | let mut exception = Exception::molt_err("error message".into()); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 928 | assert_eq!(data.error_info(), "error message\nfrom unit test".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:942:24 [INFO] [stdout] | [INFO] [stdout] 934 | let exception = Exception::molt_err2("CODE".into(), "error message".into()); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 942 | assert_eq!(data.error_code(), "CODE".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:964:24 [INFO] [stdout] | [INFO] [stdout] 949 | let exception = Exception::molt_return_err( [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 964 | assert_eq!(data.error_code(), "MYERR".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `value::Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:986:24 [INFO] [stdout] | [INFO] [stdout] 971 | let exception = Exception::molt_return_err( [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 986 | assert_eq!(data.error_code(), "MYERR".into()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Rc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1309:19 [INFO] [stdout] | [INFO] [stdout] 1301 | let dictval = Value::from(dict); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1304 | let dictval = Value::from("qrs xyz"); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1305 | let result = dictval.as_dict(); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1309 | if let Ok(rcdict) = result { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `IndexMap` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1322:19 [INFO] [stdout] | [INFO] [stdout] 1317 | let dictval = Value::from("qrs xyz"); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1318 | let result = dictval.to_dict(); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1322 | if let Ok(dict) = result { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Rc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:1442:19 [INFO] [stdout] | [INFO] [stdout] 1434 | let listval = Value::from(vec![Value::from("abc"), Value::from("def")]); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1437 | let listval = Value::from("qrs xyz"); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1438 | let result = listval.as_list(); [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1442 | if let Ok(rclist) = result { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `slice` is never used [INFO] [stdout] --> src/util.rs:179:8 [INFO] [stdout] | [INFO] [stdout] 177 | pub(crate) trait StringUtils { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] 178 | fn substring(&self, start: usize, len: usize) -> &str; [INFO] [stdout] 179 | fn slice(&self, range: impl RangeBounds) -> &str; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `as_any`, `as_any_mut`, and `into_any` are never used [INFO] [stdout] --> src/value.rs:1097:8 [INFO] [stdout] | [INFO] [stdout] 1096 | trait MoltAny: Any + Display + Debug { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] 1097 | fn as_any(&self) -> &dyn Any; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 1098 | fn as_any_mut(&mut self) -> &mut dyn Any; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 1099 | fn into_any(self: Box) -> Box; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `molt` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1bee002752b33e5fa5de057daa45b82491c1d411c683d1d1d78673b229574a33", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1bee002752b33e5fa5de057daa45b82491c1d411c683d1d1d78673b229574a33", kill_on_drop: false }` [INFO] [stdout] 1bee002752b33e5fa5de057daa45b82491c1d411c683d1d1d78673b229574a33