[INFO] fetching crate modular-native 0.1.1... [INFO] checking modular-native-0.1.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate modular-native 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate modular-native 0.1.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate modular-native 0.1.1 [INFO] finished tweaking crates.io crate modular-native 0.1.1 [INFO] tweaked toml for crates.io crate modular-native 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 85 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (available: v2.3.1) [INFO] [stderr] Adding event-listener v2.5.3 (available: v5.3.1) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding tower v0.4.13 (available: v0.5.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 37dcd6e82742cd8ca8112a3664a7ff970f96a549d5cd234d2490b7dd5630b0fa [INFO] running `Command { std: "docker" "start" "-a" "37dcd6e82742cd8ca8112a3664a7ff970f96a549d5cd234d2490b7dd5630b0fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "37dcd6e82742cd8ca8112a3664a7ff970f96a549d5cd234d2490b7dd5630b0fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37dcd6e82742cd8ca8112a3664a7ff970f96a549d5cd234d2490b7dd5630b0fa", kill_on_drop: false }` [INFO] [stdout] 37dcd6e82742cd8ca8112a3664a7ff970f96a549d5cd234d2490b7dd5630b0fa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 775e10a8e84f13beaf435f08b789449501e52b58352fea2d7bcb15c5a5b40918 [INFO] running `Command { std: "docker" "start" "-a" "775e10a8e84f13beaf435f08b789449501e52b58352fea2d7bcb15c5a5b40918", kill_on_drop: false }` [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking modular-sys v0.1.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking modular-rs v0.1.0 [INFO] [stderr] Checking modular-native v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module.rs:50:34 [INFO] [stdout] | [INFO] [stdout] 48 | let state = Box::from_raw(ptr.0 as *mut CModuleFutureState); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | [INFO] [stdout] 50 | if let Some(v) = state.data.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module.rs:62:34 [INFO] [stdout] | [INFO] [stdout] 60 | let state = Box::from_raw(ptr.0 as *mut CModuleFutureState); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | if let Some(v) = state.data.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module.rs:77:34 [INFO] [stdout] | [INFO] [stdout] 75 | let state = Box::from_raw(ptr.0 as *mut CModuleFutureState); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | [INFO] [stdout] 77 | if let Some(v) = state.data.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module.rs:86:34 [INFO] [stdout] | [INFO] [stdout] 84 | let state = Box::from_raw(ptr.0 as *mut CModuleFutureState); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | [INFO] [stdout] 86 | if let Some(v) = state.data.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module.rs:50:34 [INFO] [stdout] | [INFO] [stdout] 48 | let state = Box::from_raw(ptr.0 as *mut CModuleFutureState); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | [INFO] [stdout] 50 | if let Some(v) = state.data.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), SubscribeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:225:11 [INFO] [stdout] | [INFO] [stdout] 223 | let _guard = handle.enter(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | [INFO] [stdout] 225 | match modular.modular.subscribe(&topic, subscribe) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module.rs:62:34 [INFO] [stdout] | [INFO] [stdout] 60 | let state = Box::from_raw(ptr.0 as *mut CModuleFutureState); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | if let Some(v) = state.data.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module.rs:77:34 [INFO] [stdout] | [INFO] [stdout] 75 | let state = Box::from_raw(ptr.0 as *mut CModuleFutureState); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | [INFO] [stdout] 77 | if let Some(v) = state.data.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module.rs:86:34 [INFO] [stdout] | [INFO] [stdout] 84 | let state = Box::from_raw(ptr.0 as *mut CModuleFutureState); [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | [INFO] [stdout] 86 | if let Some(v) = state.data.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:348:26 [INFO] [stdout] | [INFO] [stdout] 343 | let RtModule { runtime, module } = (*(ptr.0 as *mut RtModule)).clone(); [INFO] [stdout] | ------- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | let data = Bytes::copy_from_slice(std::slice::from_raw_parts(data.data, data.len)); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | [INFO] [stdout] 348 | if let Some(v) = runtime.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), SubscribeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:225:11 [INFO] [stdout] | [INFO] [stdout] 223 | let _guard = handle.enter(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | [INFO] [stdout] 225 | match modular.modular.subscribe(&topic, subscribe) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:348:26 [INFO] [stdout] | [INFO] [stdout] 343 | let RtModule { runtime, module } = (*(ptr.0 as *mut RtModule)).clone(); [INFO] [stdout] | ------- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | let data = Bytes::copy_from_slice(std::slice::from_raw_parts(data.data, data.len)); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | [INFO] [stdout] 348 | if let Some(v) = runtime.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `modular-native` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `modular-native` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "775e10a8e84f13beaf435f08b789449501e52b58352fea2d7bcb15c5a5b40918", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "775e10a8e84f13beaf435f08b789449501e52b58352fea2d7bcb15c5a5b40918", kill_on_drop: false }` [INFO] [stdout] 775e10a8e84f13beaf435f08b789449501e52b58352fea2d7bcb15c5a5b40918