[INFO] fetching crate mining_proxy_sv2 0.1.1... [INFO] checking mining_proxy_sv2-0.1.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate mining_proxy_sv2 0.1.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate mining_proxy_sv2 0.1.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mining_proxy_sv2 0.1.1 [INFO] finished tweaking crates.io crate mining_proxy_sv2 0.1.1 [INFO] tweaked toml for crates.io crate mining_proxy_sv2 0.1.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate mining_proxy_sv2 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 36a9ad352fafc0c3dfc4492c5b5ac10bbf6818fc47587441695d7ff89244b91f [INFO] running `Command { std: "docker" "start" "-a" "36a9ad352fafc0c3dfc4492c5b5ac10bbf6818fc47587441695d7ff89244b91f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "36a9ad352fafc0c3dfc4492c5b5ac10bbf6818fc47587441695d7ff89244b91f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36a9ad352fafc0c3dfc4492c5b5ac10bbf6818fc47587441695d7ff89244b91f", kill_on_drop: false }` [INFO] [stdout] 36a9ad352fafc0c3dfc4492c5b5ac10bbf6818fc47587441695d7ff89244b91f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 32f133b4f72429251a32a77065555657d34ca007dcf7de83ed6a4d53b6916291 [INFO] running `Command { std: "docker" "start" "-a" "32f133b4f72429251a32a77065555657d34ca007dcf7de83ed6a4d53b6916291", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling bitcoin-internals v0.2.0 [INFO] [stderr] Checking hex-conservative v0.1.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling binary_codec_sv2 v1.0.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking bitcoin_hashes v0.13.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling derive_codec_sv2 v1.0.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Compiling secp256k1-sys v0.9.2 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Compiling secp256k1-sys v0.6.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking buffer_sv2 v1.0.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking bs58 v0.4.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking secp256k1 v0.28.2 [INFO] [stderr] Checking secp256k1 v0.24.3 [INFO] [stderr] Checking const_sv2 v1.0.0 [INFO] [stderr] Checking const_sv2 v0.1.3 [INFO] [stderr] Checking noise_sv2 v1.1.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking bitcoin v0.29.2 [INFO] [stderr] Compiling async-recursion v0.3.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking binary_sv2 v1.0.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking framing_sv2 v1.0.0 [INFO] [stderr] Checking template_distribution_sv2 v1.0.0 [INFO] [stderr] Checking job_declaration_sv2 v1.0.0 [INFO] [stderr] Checking common_messages_sv2 v1.0.0 [INFO] [stderr] Checking codec_sv2 v1.0.1 [INFO] [stderr] Checking mining_sv2 v1.0.0 [INFO] [stderr] Checking stratum-common v1.0.0 [INFO] [stderr] Checking roles_logic_sv2 v1.0.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking network_helpers_sv2 v2.0.0 [INFO] [stderr] Checking key-utils v1.0.0 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking mining_proxy_sv2 v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `async_channel::Sender, Slice>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:308:13 [INFO] [stdout] | [INFO] [stdout] 304 | self_mutex: Arc>, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let sender = self_mutex.safe_lock(|self_| self_.sender.clone()).unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, upstream_mining::UpstreamMiningNode>, roles_logic_sv2::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 230 | pub async fn next(self_mutex: Arc>, mut incoming: StdFrame) { [INFO] [stdout] | ---------- ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | let next_message_to_send = ParseDownstreamMiningMessages::handle_message_mining( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `async_channel::Sender, Slice>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:308:13 [INFO] [stdout] | [INFO] [stdout] 304 | self_mutex: Arc>, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let sender = self_mutex.safe_lock(|self_| self_.sender.clone()).unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, UpstreamMiningNode>, roles_logic_sv2::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/downstream_mining.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 230 | pub async fn next(self_mutex: Arc>, mut incoming: StdFrame) { [INFO] [stdout] | ---------- ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | let next_message_to_send = ParseDownstreamMiningMessages::handle_message_mining( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:337:13 [INFO] [stdout] | [INFO] [stdout] 336 | async fn receive(self_mutex: Arc>) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let mut connection = self_mutex [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter, DownstreamMiningNode>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:541:32 [INFO] [stdout] | [INFO] [stdout] 515 | self_mutex: Arc>, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 516 | to_send: Result, Error>, [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 517 | incoming: StdFrame, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 541 | for send_to in sends_to { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:337:13 [INFO] [stdout] | [INFO] [stdout] 336 | async fn receive(self_mutex: Arc>) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let mut connection = self_mutex [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter, DownstreamMiningNode>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:541:32 [INFO] [stdout] | [INFO] [stdout] 515 | self_mutex: Arc>, [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 516 | to_send: Result, Error>, [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 517 | incoming: StdFrame, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 541 | for send_to in sends_to { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:908:21 [INFO] [stdout] | [INFO] [stdout] 899 | remote: Option>>, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 908 | let remote = remote.unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mining_proxy_sv2` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Arc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib/upstream_mining.rs:908:21 [INFO] [stdout] | [INFO] [stdout] 899 | remote: Option>>, [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 908 | let remote = remote.unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mining_proxy_sv2` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "32f133b4f72429251a32a77065555657d34ca007dcf7de83ed6a4d53b6916291", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32f133b4f72429251a32a77065555657d34ca007dcf7de83ed6a4d53b6916291", kill_on_drop: false }` [INFO] [stdout] 32f133b4f72429251a32a77065555657d34ca007dcf7de83ed6a4d53b6916291