[INFO] fetching crate mini 0.0.4... [INFO] checking mini-0.0.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate mini 0.0.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate mini 0.0.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate mini 0.0.4 [INFO] finished tweaking crates.io crate mini 0.0.4 [INFO] tweaked toml for crates.io crate mini 0.0.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate mini 0.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fdd21761eba13dd4f02ab92df2bb7256ea468e878951d98e48c573bb32ff5748 [INFO] running `Command { std: "docker" "start" "-a" "fdd21761eba13dd4f02ab92df2bb7256ea468e878951d98e48c573bb32ff5748", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fdd21761eba13dd4f02ab92df2bb7256ea468e878951d98e48c573bb32ff5748", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fdd21761eba13dd4f02ab92df2bb7256ea468e878951d98e48c573bb32ff5748", kill_on_drop: false }` [INFO] [stdout] fdd21761eba13dd4f02ab92df2bb7256ea468e878951d98e48c573bb32ff5748 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4364bc78b4c827edfa7128a7d2ad2c5e9aaa6b00f20cc7f7b3e91e442f3a1b18 [INFO] running `Command { std: "docker" "start" "-a" "4364bc78b4c827edfa7128a7d2ad2c5e9aaa6b00f20cc7f7b3e91e442f3a1b18", kill_on_drop: false }` [INFO] [stderr] Checking mini v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aio/net.rs:233:15 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn connect_to_host(host: &str, port: &str, event_loop: &mut Loop, mut connection_notify: NOTIFY) -> Option [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aio/net.rs:695:11 [INFO] [stdout] | [INFO] [stdout] 686 | fn manage_connection(event_loop: &mut Loop, mut connection: TcpConnection, mut connection_notify: Box, [INFO] [stdout] | -------------- --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 695 | match event_loop.try_add_raw_fd(fd, Mode::ReadWrite) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aio/net.rs:233:15 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn connect_to_host(host: &str, port: &str, event_loop: &mut Loop, mut connection_notify: NOTIFY) -> Option [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/getopts.rs:422:24 [INFO] [stdout] | [INFO] [stdout] 421 | pub fn usage_with_format) -> String>(&self, mut formatter: F) -> String { [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 422 | formatter(&mut self.usage_items()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/aio/net.rs:695:11 [INFO] [stdout] | [INFO] [stdout] 686 | fn manage_connection(event_loop: &mut Loop, mut connection: TcpConnection, mut connection_notify: Box, [INFO] [stdout] | -------------- --------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 695 | match event_loop.try_add_raw_fd(fd, Mode::ReadWrite) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `CString::from_raw` that must be used [INFO] [stdout] --> src/aio/net.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | CString::from_raw(hostname as *mut _); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 307 | let _ = CString::from_raw(hostname as *mut _); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `CString::from_raw` that must be used [INFO] [stdout] --> src/aio/net.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 308 | CString::from_raw(service as *mut _); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 308 | let _ = CString::from_raw(service as *mut _); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mini` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Box>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/getopts.rs:422:24 [INFO] [stdout] | [INFO] [stdout] 421 | pub fn usage_with_format) -> String>(&self, mut formatter: F) -> String { [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 422 | formatter(&mut self.usage_items()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `CString::from_raw` that must be used [INFO] [stdout] --> src/aio/net.rs:307:9 [INFO] [stdout] | [INFO] [stdout] 307 | CString::from_raw(hostname as *mut _); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 307 | let _ = CString::from_raw(hostname as *mut _); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `CString::from_raw` that must be used [INFO] [stdout] --> src/aio/net.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 308 | CString::from_raw(service as *mut _); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(from_raw(ptr))` if you intend to drop the `CString` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 308 | let _ = CString::from_raw(service as *mut _); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mini` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4364bc78b4c827edfa7128a7d2ad2c5e9aaa6b00f20cc7f7b3e91e442f3a1b18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4364bc78b4c827edfa7128a7d2ad2c5e9aaa6b00f20cc7f7b3e91e442f3a1b18", kill_on_drop: false }` [INFO] [stdout] 4364bc78b4c827edfa7128a7d2ad2c5e9aaa6b00f20cc7f7b3e91e442f3a1b18