[INFO] fetching crate metrics-dashboard 0.2.2... [INFO] checking metrics-dashboard-0.2.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate metrics-dashboard 0.2.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate metrics-dashboard 0.2.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate metrics-dashboard 0.2.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate metrics-dashboard 0.2.2 [INFO] tweaked toml for crates.io crate metrics-dashboard 0.2.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate metrics-dashboard 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 86f86f80c5d102edf3b53f5f0e569f889c8ce760a45f938f55576b18fed42b49 [INFO] running `Command { std: "docker" "start" "-a" "86f86f80c5d102edf3b53f5f0e569f889c8ce760a45f938f55576b18fed42b49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "86f86f80c5d102edf3b53f5f0e569f889c8ce760a45f938f55576b18fed42b49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86f86f80c5d102edf3b53f5f0e569f889c8ce760a45f938f55576b18fed42b49", kill_on_drop: false }` [INFO] [stdout] 86f86f80c5d102edf3b53f5f0e569f889c8ce760a45f938f55576b18fed42b49 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aff7cc6b16ecc4c098e4883f4fdc6aa26325a44a096e962d8956832973e44c72 [INFO] running `Command { std: "docker" "start" "-a" "aff7cc6b16ecc4c098e4883f4fdc6aa26325a44a096e962d8956832973e44c72", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling rust-embed-utils v8.5.0 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling prometheus v0.13.4 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Checking ordered-float v4.2.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking headers-core v0.3.0 [INFO] [stderr] Checking metrics v0.22.3 [INFO] [stderr] Checking sketches-ddsketch v0.2.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking rfc7239 v0.1.1 [INFO] [stderr] Checking headers v0.4.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking quanta v0.12.3 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking metrics-util v0.16.3 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking wildmatch v2.3.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling rust-embed-impl v8.5.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling poem-derive v2.0.1 [INFO] [stderr] Checking rust-embed v8.5.0 [INFO] [stderr] Compiling async-trait v0.1.82 [INFO] [stderr] Compiling sealed v0.5.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking metrics-prometheus v0.6.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking poem v2.0.1 [INFO] [stderr] Checking metrics-dashboard v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `RwLockWriteGuard<'_, DashboardStorage>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 217 | let mut metrics = self.metrics.write().expect("Should ok"); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | / self.storage [INFO] [stdout] 232 | | .write() [INFO] [stdout] 233 | | .expect("Should lock") [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockWriteGuard<'_, DashboardStorage>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 240 | let mut metrics = self.metrics.write().expect("Should ok"); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | / self.storage [INFO] [stdout] 255 | | .write() [INFO] [stdout] 256 | | .expect("Should lock") [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockWriteGuard<'_, DashboardStorage>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 263 | let mut metrics = self.metrics.write().expect("Should ok"); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | / self.storage [INFO] [stdout] 278 | | .write() [INFO] [stdout] 279 | | .expect("Should lock") [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metrics-dashboard` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `RwLockWriteGuard<'_, DashboardStorage>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 217 | let mut metrics = self.metrics.write().expect("Should ok"); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | / self.storage [INFO] [stdout] 232 | | .write() [INFO] [stdout] 233 | | .expect("Should lock") [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockWriteGuard<'_, DashboardStorage>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 240 | let mut metrics = self.metrics.write().expect("Should ok"); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 254 | / self.storage [INFO] [stdout] 255 | | .write() [INFO] [stdout] 256 | | .expect("Should lock") [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockWriteGuard<'_, DashboardStorage>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recorder.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 263 | let mut metrics = self.metrics.write().expect("Should ok"); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 277 | / self.storage [INFO] [stdout] 278 | | .write() [INFO] [stdout] 279 | | .expect("Should lock") [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `metrics-dashboard` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "aff7cc6b16ecc4c098e4883f4fdc6aa26325a44a096e962d8956832973e44c72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aff7cc6b16ecc4c098e4883f4fdc6aa26325a44a096e962d8956832973e44c72", kill_on_drop: false }` [INFO] [stdout] aff7cc6b16ecc4c098e4883f4fdc6aa26325a44a096e962d8956832973e44c72