[INFO] fetching crate memora 0.6.3... [INFO] checking memora-0.6.3 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate memora 0.6.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate memora 0.6.3 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate memora 0.6.3 [INFO] finished tweaking crates.io crate memora 0.6.3 [INFO] tweaked toml for crates.io crate memora 0.6.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate memora 0.6.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2a810e258462f086722e93da8076c41189a8f6e50c6091e026f0d097517dfa59 [INFO] running `Command { std: "docker" "start" "-a" "2a810e258462f086722e93da8076c41189a8f6e50c6091e026f0d097517dfa59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2a810e258462f086722e93da8076c41189a8f6e50c6091e026f0d097517dfa59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a810e258462f086722e93da8076c41189a8f6e50c6091e026f0d097517dfa59", kill_on_drop: false }` [INFO] [stdout] 2a810e258462f086722e93da8076c41189a8f6e50c6091e026f0d097517dfa59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3d3ebfdd92d22bd3959d961f11dd8d762d88053f34f6a7352e72cb631312d0b7 [INFO] running `Command { std: "docker" "start" "-a" "3d3ebfdd92d22bd3959d961f11dd8d762d88053f34f6a7352e72cb631312d0b7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling indexmap v1.8.2 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking tuple-transpose v0.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking file_diff v1.0.0 [INFO] [stderr] Compiling file-lock v2.1.4 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.24.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking mktemp v0.4.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking Inflector v0.11.4 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Compiling derivative v2.1.1 [INFO] [stderr] Checking serde_yaml v0.8.24 [INFO] [stderr] Checking serde-tuple-vec-map v1.0.0 [INFO] [stderr] Checking memora v0.6.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/git.rs:195:21 [INFO] [stdout] | [INFO] [stdout] 191 | fn first_ordered_object<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 195 | ) -> Result<&'a Object> { [INFO] [stdout] | ^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/git.rs:221:90 [INFO] [stdout] | [INFO] [stdout] 221 | pub fn youngest_object<'a>(&'a self, objects: &'a HashSet>) -> Result<&'a Object> { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/git.rs:227:88 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn oldest_object<'a>(&'a self, objects: &'a HashSet>) -> Result<&'a Object> { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/git.rs:195:21 [INFO] [stdout] | [INFO] [stdout] 191 | fn first_ordered_object<'a>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 195 | ) -> Result<&'a Object> { [INFO] [stdout] | ^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/git.rs:221:90 [INFO] [stdout] | [INFO] [stdout] 221 | pub fn youngest_object<'a>(&'a self, objects: &'a HashSet>) -> Result<&'a Object> { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/git.rs:227:88 [INFO] [stdout] | [INFO] [stdout] 227 | pub fn oldest_object<'a>(&'a self, objects: &'a HashSet>) -> Result<&'a Object> { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Command` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:179:15 [INFO] [stdout] | [INFO] [stdout] 168 | let ls_files = ls_files.unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 180 | | .cmd(&["diff-index", "--quiet", "HEAD", "--", path_str(&path)]) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/cache.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | #[derive(Deserialize, Debug, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Artifact` [INFO] [stdout] 24 | pub struct Artifact { [INFO] [stdout] | -------- `Artifact` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | #[derive(Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_SerdeArtifact` [INFO] [stdout] 33 | struct SerdeArtifact { [INFO] [stdout] | ------------- `SerdeArtifact` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config.rs:38:10 [INFO] [stdout] | [INFO] [stdout] 38 | #[derive(Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_SerdeManifest` [INFO] [stdout] 39 | struct SerdeManifest { [INFO] [stdout] | ------------- `SerdeManifest` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `memora` (lib) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Command` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:179:15 [INFO] [stdout] | [INFO] [stdout] 168 | let ls_files = ls_files.unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | match self [INFO] [stdout] | _______________^ [INFO] [stdout] 180 | | .cmd(&["diff-index", "--quiet", "HEAD", "--", path_str(&path)]) [INFO] [stdout] | |___________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/cache.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | #[derive(Deserialize, Debug, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Artifact` [INFO] [stdout] 24 | pub struct Artifact { [INFO] [stdout] | -------- `Artifact` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config.rs:32:10 [INFO] [stdout] | [INFO] [stdout] 32 | #[derive(Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_SerdeArtifact` [INFO] [stdout] 33 | struct SerdeArtifact { [INFO] [stdout] | ------------- `SerdeArtifact` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/config.rs:38:10 [INFO] [stdout] | [INFO] [stdout] 38 | #[derive(Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_SerdeManifest` [INFO] [stdout] 39 | struct SerdeManifest { [INFO] [stdout] | ------------- `SerdeManifest` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `memora` (lib test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3d3ebfdd92d22bd3959d961f11dd8d762d88053f34f6a7352e72cb631312d0b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d3ebfdd92d22bd3959d961f11dd8d762d88053f34f6a7352e72cb631312d0b7", kill_on_drop: false }` [INFO] [stdout] 3d3ebfdd92d22bd3959d961f11dd8d762d88053f34f6a7352e72cb631312d0b7