[INFO] fetching crate melodium-engine 0.8.0... [INFO] checking melodium-engine-0.8.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate melodium-engine 0.8.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate melodium-engine 0.8.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate melodium-engine 0.8.0 [INFO] finished tweaking crates.io crate melodium-engine 0.8.0 [INFO] tweaked toml for crates.io crate melodium-engine 0.8.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 82 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (available: v2.3.1) [INFO] [stderr] Adding event-listener v2.5.3 (available: v5.3.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 56a861af6a31e6e65a22362c074f9dad1932605222ae65170a68bccbcca2c739 [INFO] running `Command { std: "docker" "start" "-a" "56a861af6a31e6e65a22362c074f9dad1932605222ae65170a68bccbcca2c739", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "56a861af6a31e6e65a22362c074f9dad1932605222ae65170a68bccbcca2c739", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56a861af6a31e6e65a22362c074f9dad1932605222ae65170a68bccbcca2c739", kill_on_drop: false }` [INFO] [stdout] 56a861af6a31e6e65a22362c074f9dad1932605222ae65170a68bccbcca2c739 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 29d92b31e2c8059cb5ce2617ebf3837c23582d3b878cebbd7debdeb0fa6ceba0 [INFO] running `Command { std: "docker" "start" "-a" "29d92b31e2c8059cb5ce2617ebf3837c23582d3b878cebbd7debdeb0fa6ceba0", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking melodium-common v0.8.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-std v1.13.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking melodium-engine v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/building/model/designed.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut remastered_environment = GenesisEnvironment::new(); [INFO] [stdout] | -------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let descriptor = self.design.descriptor.upgrade().unwrap(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | / self.world [INFO] [stdout] 53 | | .upgrade() [INFO] [stdout] 54 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/building/model/designed.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 34 | let mut remastered_environment = GenesisEnvironment::new(); [INFO] [stdout] | -------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let descriptor = self.design.descriptor.upgrade().unwrap(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | / self.world [INFO] [stdout] 53 | | .upgrade() [INFO] [stdout] 54 | | .unwrap() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `TreatmentBuildMode` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/building/treatment/mod.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 16 | world: Arc, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | match descriptor.build_mode() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `TreatmentBuildMode` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/building/treatment/mod.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 16 | world: Arc, [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | match descriptor.build_mode() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option, LogicError, LogicError>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/designer/parameter.rs:182:15 [INFO] [stdout] | [INFO] [stdout] 180 | let parent_descriptor = self.parent_descriptor.upgrade().unwrap(); [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let parameter = parent_descriptor.parameters().get(&self.name); [INFO] [stdout] 182 | match parameter.map(|parameter| { [INFO] [stdout] | _______________^ [INFO] [stdout] 183 | | parameter [INFO] [stdout] 184 | | .described_type() [INFO] [stdout] 185 | | .as_defined(&self.parent_generics.read().unwrap()) [INFO] [stdout] ... | [INFO] [stdout] 194 | | }) [INFO] [stdout] 195 | | }) { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/designer/treatment.rs:232:44 [INFO] [stdout] | [INFO] [stdout] 219 | design_reference: Option>, [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | if let Some(model_instanciation) = self.model_instanciations.remove(actual_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/designer/treatment.rs:353:34 [INFO] [stdout] | [INFO] [stdout] 340 | design_reference: Option>, [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | if let Some(treatment) = self.treatments.remove(actual_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option, LogicError, LogicError>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/designer/parameter.rs:182:15 [INFO] [stdout] | [INFO] [stdout] 180 | let parent_descriptor = self.parent_descriptor.upgrade().unwrap(); [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | let parameter = parent_descriptor.parameters().get(&self.name); [INFO] [stdout] 182 | match parameter.map(|parameter| { [INFO] [stdout] | _______________^ [INFO] [stdout] 183 | | parameter [INFO] [stdout] 184 | | .described_type() [INFO] [stdout] 185 | | .as_defined(&self.parent_generics.read().unwrap()) [INFO] [stdout] ... | [INFO] [stdout] 194 | | }) [INFO] [stdout] 195 | | }) { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/designer/treatment.rs:232:44 [INFO] [stdout] | [INFO] [stdout] 219 | design_reference: Option>, [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | if let Some(model_instanciation) = self.model_instanciations.remove(actual_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/designer/treatment.rs:981:61 [INFO] [stdout] | [INFO] [stdout] 975 | let model_instanciation = model_instanciation.read().unwrap(); [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 981 | descriptor: Arc::downgrade(&model_instanciation.descriptor()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/designer/treatment.rs:1014:61 [INFO] [stdout] | [INFO] [stdout] 1008 | let treatment_instanciation = treatment_instanciation.read().unwrap(); [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1014 | descriptor: Arc::downgrade(&treatment_instanciation.descriptor()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/designer/treatment.rs:353:34 [INFO] [stdout] | [INFO] [stdout] 340 | design_reference: Option>, [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | if let Some(treatment) = self.treatments.remove(actual_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/designer/treatment.rs:981:61 [INFO] [stdout] | [INFO] [stdout] 975 | let model_instanciation = model_instanciation.read().unwrap(); [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 981 | descriptor: Arc::downgrade(&model_instanciation.descriptor()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/designer/treatment.rs:1014:61 [INFO] [stdout] | [INFO] [stdout] 1008 | let treatment_instanciation = treatment_instanciation.read().unwrap(); [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1014 | descriptor: Arc::downgrade(&treatment_instanciation.descriptor()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/world/track.rs:44:23 [INFO] [stdout] | [INFO] [stdout] 44 | NotAllOk(TrackId, Vec), [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 44 | NotAllOk(TrackId, ()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/world/track.rs:44:23 [INFO] [stdout] | [INFO] [stdout] 44 | NotAllOk(TrackId, Vec), [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 44 | NotAllOk(TrackId, ()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `melodium-engine` (lib test) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `melodium-engine` (lib) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "29d92b31e2c8059cb5ce2617ebf3837c23582d3b878cebbd7debdeb0fa6ceba0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29d92b31e2c8059cb5ce2617ebf3837c23582d3b878cebbd7debdeb0fa6ceba0", kill_on_drop: false }` [INFO] [stdout] 29d92b31e2c8059cb5ce2617ebf3837c23582d3b878cebbd7debdeb0fa6ceba0