[INFO] fetching crate maomi 0.5.0... [INFO] checking maomi-0.5.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate maomi 0.5.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate maomi 0.5.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate maomi 0.5.0 [INFO] finished tweaking crates.io crate maomi 0.5.0 [INFO] tweaked toml for crates.io crate maomi 0.5.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding toml v0.7.8 (available: v0.8.19) [INFO] [stderr] Adding toml_edit v0.19.15 (available: v0.22.22) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (available: v0.6.20) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ff4d69e0028fb7ebd1d6d400d5349a05a982c6851f86febd33bd1335d56b4e19 [INFO] running `Command { std: "docker" "start" "-a" "ff4d69e0028fb7ebd1d6d400d5349a05a982c6851f86febd33bd1335d56b4e19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ff4d69e0028fb7ebd1d6d400d5349a05a982c6851f86febd33bd1335d56b4e19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff4d69e0028fb7ebd1d6d400d5349a05a982c6851f86febd33bd1335d56b4e19", kill_on_drop: false }` [INFO] [stdout] ff4d69e0028fb7ebd1d6d400d5349a05a982c6851f86febd33bd1335d56b4e19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c077a4ecd470d8f99c80c00c415e456b98d01e94603548c380013a723277a78 [INFO] running `Command { std: "docker" "start" "-a" "8c077a4ecd470d8f99c80c00c415e456b98d01e94603548c380013a723277a78", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling utf8parse v0.2.2 [INFO] [stderr] Compiling colorchoice v1.0.2 [INFO] [stderr] Compiling is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling anstyle v1.0.8 [INFO] [stderr] Compiling anstyle-query v1.1.1 [INFO] [stderr] Compiling clap_lex v0.7.2 [INFO] [stderr] Checking maomi-tree v0.5.0 [INFO] [stderr] Compiling anstyle-parse v0.2.5 [INFO] [stderr] Compiling anstream v0.6.15 [INFO] [stderr] Compiling clap_builder v4.5.18 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling clap v4.5.18 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling serde_spanned v0.6.8 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling toml v0.7.8 [INFO] [stderr] Compiling maomi-tools v0.5.0 [INFO] [stderr] Compiling maomi-skin v0.5.0 [INFO] [stderr] Compiling maomi-macro v0.5.0 [INFO] [stderr] Checking maomi v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `BackendContext` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/context.rs:205:14 [INFO] [stdout] | [INFO] [stdout] 203 | let mut root = self.backend.root_mut(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | MountPoint::attach( [INFO] [stdout] 205 | &BackendContext { [INFO] [stdout] | ______________^ [INFO] [stdout] 206 | | inner: self.ctx.as_ref().unwrap().upgrade().unwrap(), [INFO] [stdout] 207 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `BackendContext` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/context.rs:220:14 [INFO] [stdout] | [INFO] [stdout] 216 | prerendering_data: PrerenderingData, [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | ) -> Result, Error> { [INFO] [stdout] 218 | let mut root = self.backend.root_mut(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | MountPoint::attach( [INFO] [stdout] 220 | &BackendContext { [INFO] [stdout] | ______________^ [INFO] [stdout] 221 | | inner: self.ctx.as_ref().unwrap().upgrade().unwrap(), [INFO] [stdout] 222 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, BorrowMutError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:594:31 [INFO] [stdout] | [INFO] [stdout] 587 | update_fn: Box, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 594 | if let Ok(mut comp) = self.component().try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, BorrowMutError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:631:31 [INFO] [stdout] | [INFO] [stdout] 626 | update_fn: Box, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 631 | if let Ok(mut comp) = self.component().try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:345:15 [INFO] [stdout] | [INFO] [stdout] 341 | fn remove(&mut self, _: K) -> Result { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | match self.kc.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `BackendContext` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/context.rs:205:14 [INFO] [stdout] | [INFO] [stdout] 203 | let mut root = self.backend.root_mut(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | MountPoint::attach( [INFO] [stdout] 205 | &BackendContext { [INFO] [stdout] | ______________^ [INFO] [stdout] 206 | | inner: self.ctx.as_ref().unwrap().upgrade().unwrap(), [INFO] [stdout] 207 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `BackendContext` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backend/context.rs:220:14 [INFO] [stdout] | [INFO] [stdout] 216 | prerendering_data: PrerenderingData, [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | ) -> Result, Error> { [INFO] [stdout] 218 | let mut root = self.backend.root_mut(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | MountPoint::attach( [INFO] [stdout] 220 | &BackendContext { [INFO] [stdout] | ______________^ [INFO] [stdout] 221 | | inner: self.ctx.as_ref().unwrap().upgrade().unwrap(), [INFO] [stdout] 222 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, BorrowMutError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:594:31 [INFO] [stdout] | [INFO] [stdout] 587 | update_fn: Box, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 594 | if let Ok(mut comp) = self.component().try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/prop.rs:441:20 [INFO] [stdout] | [INFO] [stdout] 441 | self.inner.into_iter() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 441 | self.inner.iter() [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 441 | IntoIterator::into_iter(self.inner) [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, BorrowMutError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/component.rs:631:31 [INFO] [stdout] | [INFO] [stdout] 626 | update_fn: Box, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 631 | if let Ok(mut comp) = self.component().try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `maomi` (lib test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:345:15 [INFO] [stdout] | [INFO] [stdout] 341 | fn remove(&mut self, _: K) -> Result { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | match self.kc.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this method call resolves to `<&Box<[T]> as IntoIterator>::into_iter` (due to backwards compatibility), but will resolve to ` as IntoIterator>::into_iter` in Rust 2024 [INFO] [stdout] --> src/prop.rs:441:20 [INFO] [stdout] | [INFO] [stdout] 441 | self.inner.into_iter() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: `#[warn(boxed_slice_into_iter)]` on by default [INFO] [stdout] help: use `.iter()` instead of `.into_iter()` to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 441 | self.inner.iter() [INFO] [stdout] | ~~~~ [INFO] [stdout] help: or use `IntoIterator::into_iter(..)` instead of `.into_iter()` to explicitly iterate by value [INFO] [stdout] | [INFO] [stdout] 441 | IntoIterator::into_iter(self.inner) [INFO] [stdout] | ++++++++++++++++++++++++ ~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `maomi` (lib) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "8c077a4ecd470d8f99c80c00c415e456b98d01e94603548c380013a723277a78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c077a4ecd470d8f99c80c00c415e456b98d01e94603548c380013a723277a78", kill_on_drop: false }` [INFO] [stdout] 8c077a4ecd470d8f99c80c00c415e456b98d01e94603548c380013a723277a78