[INFO] fetching crate loirc 0.2.0... [INFO] checking loirc-0.2.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate loirc 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate loirc 0.2.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate loirc 0.2.0 [INFO] finished tweaking crates.io crate loirc 0.2.0 [INFO] tweaked toml for crates.io crate loirc 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 585f00b6b6e643efb68df9e68dcc510461b33773f2088c7981b5f92940d0928a [INFO] running `Command { std: "docker" "start" "-a" "585f00b6b6e643efb68df9e68dcc510461b33773f2088c7981b5f92940d0928a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "585f00b6b6e643efb68df9e68dcc510461b33773f2088c7981b5f92940d0928a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "585f00b6b6e643efb68df9e68dcc510461b33773f2088c7981b5f92940d0928a", kill_on_drop: false }` [INFO] [stdout] 585f00b6b6e643efb68df9e68dcc510461b33773f2088c7981b5f92940d0928a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6505c8151023e587a81286eac3110b4eb5e5a92138d32ee1f529f57a4a29add2 [INFO] running `Command { std: "docker" "start" "-a" "6505c8151023e587a81286eac3110b4eb5e5a92138d32ee1f529f57a4a29add2", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking loirc v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/connection.rs:247:60 [INFO] [stdout] | [INFO] [stdout] 247 | fn reconnect(address: &str, handle: &Writer) -> io::Result<(BufReader)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 247 - fn reconnect(address: &str, handle: &Writer) -> io::Result<(BufReader)> { [INFO] [stdout] 247 + fn reconnect(address: &str, handle: &Writer) -> io::Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/connection.rs:248:18 [INFO] [stdout] | [INFO] [stdout] 248 | let stream = try!(TcpStream::connect(address)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/connection.rs:249:33 [INFO] [stdout] | [INFO] [stdout] 249 | let reader = BufReader::new(try!(stream.try_clone())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/connection.rs:251:8 [INFO] [stdout] | [INFO] [stdout] 251 | Ok((reader)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 251 - Ok((reader)) [INFO] [stdout] 251 + Ok(reader) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/connection.rs:360:18 [INFO] [stdout] | [INFO] [stdout] 360 | let stream = try!(TcpStream::connect(address.as_ref())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/connection.rs:361:33 [INFO] [stdout] | [INFO] [stdout] 361 | let reader = BufReader::new(try!(stream.try_clone())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/connection.rs:247:60 [INFO] [stdout] | [INFO] [stdout] 247 | fn reconnect(address: &str, handle: &Writer) -> io::Result<(BufReader)> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 247 - fn reconnect(address: &str, handle: &Writer) -> io::Result<(BufReader)> { [INFO] [stdout] 247 + fn reconnect(address: &str, handle: &Writer) -> io::Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/connection.rs:248:18 [INFO] [stdout] | [INFO] [stdout] 248 | let stream = try!(TcpStream::connect(address)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/connection.rs:249:33 [INFO] [stdout] | [INFO] [stdout] 249 | let reader = BufReader::new(try!(stream.try_clone())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/connection.rs:251:8 [INFO] [stdout] | [INFO] [stdout] 251 | Ok((reader)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 251 - Ok((reader)) [INFO] [stdout] 251 + Ok(reader) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/connection.rs:360:18 [INFO] [stdout] | [INFO] [stdout] 360 | let stream = try!(TcpStream::connect(address.as_ref())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/connection.rs:361:33 [INFO] [stdout] | [INFO] [stdout] 361 | let reader = BufReader::new(try!(stream.try_clone())); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/message.rs:35:30 [INFO] [stdout] | [INFO] [stdout] 35 | let mut state = line.trim_right_matches("\r\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 35 | let mut state = line.trim_end_matches("\r\n"); [INFO] [stdout] | ~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, ConnectionStatus>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activity_monitor.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 90 | fn periodic_checker(state: State, handle: Writer, settings: MonitorSettings) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | loop { [INFO] [stdout] 92 | let mut conn_status = state.connection_status(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `loirc` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated method `core::str::::trim_right_matches`: superseded by `trim_end_matches` [INFO] [stdout] --> src/message.rs:35:30 [INFO] [stdout] | [INFO] [stdout] 35 | let mut state = line.trim_right_matches("\r\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace the use of the deprecated method [INFO] [stdout] | [INFO] [stdout] 35 | let mut state = line.trim_end_matches("\r\n"); [INFO] [stdout] | ~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MutexGuard<'_, ConnectionStatus>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/activity_monitor.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 90 | fn periodic_checker(state: State, handle: Writer, settings: MonitorSettings) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | loop { [INFO] [stdout] 92 | let mut conn_status = state.connection_status(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `loirc` (lib test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6505c8151023e587a81286eac3110b4eb5e5a92138d32ee1f529f57a4a29add2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6505c8151023e587a81286eac3110b4eb5e5a92138d32ee1f529f57a4a29add2", kill_on_drop: false }` [INFO] [stdout] 6505c8151023e587a81286eac3110b4eb5e5a92138d32ee1f529f57a4a29add2