[INFO] fetching crate libside 0.3.0... [INFO] checking libside-0.3.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate libside 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate libside 0.3.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libside 0.3.0 [INFO] finished tweaking crates.io crate libside 0.3.0 [INFO] tweaked toml for crates.io crate libside 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate libside 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a898c1c830ef4957bbb9445a3ea24f0ea2322e62e4e5cca4e21acbfd251b9c82 [INFO] running `Command { std: "docker" "start" "-a" "a898c1c830ef4957bbb9445a3ea24f0ea2322e62e4e5cca4e21acbfd251b9c82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a898c1c830ef4957bbb9445a3ea24f0ea2322e62e4e5cca4e21acbfd251b9c82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a898c1c830ef4957bbb9445a3ea24f0ea2322e62e4e5cca4e21acbfd251b9c82", kill_on_drop: false }` [INFO] [stdout] a898c1c830ef4957bbb9445a3ea24f0ea2322e62e4e5cca4e21acbfd251b9c82 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 352f343b5b88f045a4fa6e84e9dc9153002bf0d7532be215b3890e2713df60d1 [INFO] running `Command { std: "docker" "start" "-a" "352f343b5b88f045a4fa6e84e9dc9153002bf0d7532be215b3890e2713df60d1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling syn v1.0.85 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling rand_core v0.4.2 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling cc v1.0.72 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling serde_derive v1.0.133 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling pkg-config v0.3.24 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling serde v1.0.133 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking getrandom v0.2.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling openssl-sys v0.9.72 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_jitter v0.1.4 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking traitobject v0.1.0 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling serde_json v1.0.75 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling openssl v0.10.38 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking block-buffer v0.10.0 [INFO] [stderr] Checking crypto-common v0.1.1 [INFO] [stderr] Checking unsafe-any v0.4.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Checking digest v0.10.1 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling uuid v0.7.4 [INFO] [stderr] Checking keccak v0.1.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking sha3 v0.10.0 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking typemap v0.3.3 [INFO] [stderr] Checking etc-passwd v0.1.1 [INFO] [stderr] Compiling paste v1.0.6 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Compiling gensym v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling libside-procmacro v0.1.0 [INFO] [stderr] Compiling concat-idents v1.1.5 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking libside v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Deserialize`, `MapAccess`, `Visitor`, and `ser::SerializeMap` [INFO] [stdout] --> src/requirements.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | de::{DeserializeOwned, MapAccess, Visitor}, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^ [INFO] [stdout] 4 | ser::SerializeMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 5 | Deserialize, Serialize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Debug`, `Display`, `error::Error`, and `marker::PhantomData` [INFO] [stdout] --> src/requirements.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | error::Error, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 9 | fmt::{Debug, Display}, [INFO] [stdout] | ^^^^^ ^^^^^^^ [INFO] [stdout] 10 | marker::PhantomData, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `requirements::Supports` [INFO] [stdout] --> src/graph.rs:549:9 [INFO] [stdout] | [INFO] [stdout] 549 | requirements::Supports, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Deserialize`, `MapAccess`, `Visitor`, and `ser::SerializeMap` [INFO] [stdout] --> src/requirements.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | de::{DeserializeOwned, MapAccess, Visitor}, [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^ [INFO] [stdout] 4 | ser::SerializeMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 5 | Deserialize, Serialize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Debug`, `Display`, `error::Error`, and `marker::PhantomData` [INFO] [stdout] --> src/requirements.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | error::Error, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 9 | fmt::{Debug, Display}, [INFO] [stdout] | ^^^^^ ^^^^^^^ [INFO] [stdout] 10 | marker::PhantomData, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SystemState<::Requirement>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:458:21 [INFO] [stdout] | [INFO] [stdout] 424 | builder: B, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 458 | let current_state = current.load_install::(system); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/builder/mysql.rs:95:56 [INFO] [stdout] | [INFO] [stdout] 95 | pub struct RunningMySqlService<'a>(GraphNodeReference, &'a ()); [INFO] [stdout] | ------------------- field in this struct ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libside` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `SystemState<::Requirement>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:458:21 [INFO] [stdout] | [INFO] [stdout] 424 | builder: B, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 458 | let current_state = current.load_install::(system); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/builder/mysql.rs:95:56 [INFO] [stdout] | [INFO] [stdout] 95 | pub struct RunningMySqlService<'a>(GraphNodeReference, &'a ()); [INFO] [stdout] | ------------------- field in this struct ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `__reqNodeTy` should have a snake case name [INFO] [stdout] --> src/requirements.rs:26:24 [INFO] [stdout] | [INFO] [stdout] 26 | mod_name = __req, $name { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `__req_node_ty` [INFO] [stdout] | [INFO] [stdout] ::: src/graph.rs:1169:9 [INFO] [stdout] | [INFO] [stdout] 1169 | crate::requirements!(NodeTy = Foo, AlwaysFail); [INFO] [stdout] | ---------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] = note: this warning originates in the macro `crate::requirements` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `__reqR` should have a snake case name [INFO] [stdout] --> src/requirements.rs:26:24 [INFO] [stdout] | [INFO] [stdout] 26 | mod_name = __req, $name { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `__req_r` [INFO] [stdout] ... [INFO] [stdout] 512 | requirements!(R = Foo, Bar, Baz); [INFO] [stdout] | -------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `requirements` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `__reqR1` should have a snake case name [INFO] [stdout] --> src/requirements.rs:26:24 [INFO] [stdout] | [INFO] [stdout] 26 | mod_name = __req, $name { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `__req_r1` [INFO] [stdout] ... [INFO] [stdout] 519 | requirements!(R1 = Baz, Foo, Bar); [INFO] [stdout] | --------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `requirements` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `__reqR2` should have a snake case name [INFO] [stdout] --> src/requirements.rs:26:24 [INFO] [stdout] | [INFO] [stdout] 26 | mod_name = __req, $name { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `__req_r2` [INFO] [stdout] ... [INFO] [stdout] 523 | requirements!(R2 = Bar, Baz, Foo); [INFO] [stdout] | --------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `requirements` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `__reqR3` should have a snake case name [INFO] [stdout] --> src/requirements.rs:26:24 [INFO] [stdout] | [INFO] [stdout] 26 | mod_name = __req, $name { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `__req_r3` [INFO] [stdout] ... [INFO] [stdout] 527 | requirements!(R3 = Foo, Bar, Baz); [INFO] [stdout] | --------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `requirements` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `__reqR` should have a snake case name [INFO] [stdout] --> src/requirements.rs:26:24 [INFO] [stdout] | [INFO] [stdout] 26 | mod_name = __req, $name { [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `__req_r` [INFO] [stdout] ... [INFO] [stdout] 534 | requirements!(R = Foo, Bar, Baz); [INFO] [stdout] | -------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `requirements` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libside` (lib test) due to 2 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "352f343b5b88f045a4fa6e84e9dc9153002bf0d7532be215b3890e2713df60d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "352f343b5b88f045a4fa6e84e9dc9153002bf0d7532be215b3890e2713df60d1", kill_on_drop: false }` [INFO] [stdout] 352f343b5b88f045a4fa6e84e9dc9153002bf0d7532be215b3890e2713df60d1