[INFO] fetching crate libreda-db 0.0.12... [INFO] checking libreda-db-0.0.12 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate libreda-db 0.0.12 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate libreda-db 0.0.12 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libreda-db 0.0.12 [INFO] finished tweaking crates.io crate libreda-db 0.0.12 [INFO] tweaked toml for crates.io crate libreda-db 0.0.12 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding hash32 v0.2.1 (available: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (available: v0.8.0) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding num-derive v0.3.3 (available: v0.4.2) [INFO] [stderr] Adding portrait v0.2.3 (available: v0.3.0) [INFO] [stderr] Adding portrait-codegen v0.2.3 (available: v0.3.0) [INFO] [stderr] Adding portrait-framework v0.2.1 (available: v0.3.0) [INFO] [stderr] Adding rstar v0.9.3 (available: v0.12.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f8342c920f9f1ca9caeef3328ec24bb8ca3c3e85bf2ee4df33f855575a74e240 [INFO] running `Command { std: "docker" "start" "-a" "f8342c920f9f1ca9caeef3328ec24bb8ca3c3e85bf2ee4df33f855575a74e240", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f8342c920f9f1ca9caeef3328ec24bb8ca3c3e85bf2ee4df33f855575a74e240", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8342c920f9f1ca9caeef3328ec24bb8ca3c3e85bf2ee4df33f855575a74e240", kill_on_drop: false }` [INFO] [stdout] f8342c920f9f1ca9caeef3328ec24bb8ca3c3e85bf2ee4df33f855575a74e240 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27c45f871655a76e2a733b88519b7c47a13e08d5e823d41ecd5fbfd5a447a04b [INFO] running `Command { std: "docker" "start" "-a" "27c45f871655a76e2a733b88519b7c47a13e08d5e823d41ecd5fbfd5a447a04b", kill_on_drop: false }` [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking libreda-splay v0.1.1 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Checking rstar v0.9.3 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking iron-shapes v0.1.1 [INFO] [stderr] Compiling ppv-lite86 v0.2.20 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking iron-shapes-booleanop v0.1.0 [INFO] [stderr] Compiling portrait-framework v0.2.1 [INFO] [stderr] Compiling portrait-codegen v0.2.3 [INFO] [stderr] Checking portrait v0.2.3 [INFO] [stderr] Checking libreda-db v0.0.12 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option<::NetId>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netlist/traits.rs:196:13 [INFO] [stdout] | [INFO] [stdout] 195 | self.for_each_pin_instance(circuit_instance, |i| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | self.net_of_pin_instance(&i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option<::NetId>, Option<::NetId>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netlist/util.rs:349:69 [INFO] [stdout] | [INFO] [stdout] 344 | .filter_map(|old_pin| { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | if let (Some(outer_net), Some(inner_old_net)) = (outer_net, inner_old_net) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<::NetId>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netlist/traits.rs:196:13 [INFO] [stdout] | [INFO] [stdout] 195 | self.for_each_pin_instance(circuit_instance, |i| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | self.net_of_pin_instance(&i) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option<::NetId>, Option<::NetId>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netlist/util.rs:349:69 [INFO] [stdout] | [INFO] [stdout] 344 | .filter_map(|old_pin| { [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | if let (Some(outer_net), Some(inner_old_net)) = (outer_net, inner_old_net) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockWriteGuard<'_, H>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rw_reference_access/hierarchy_reference_access.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn remove_cell(&self, cell: CellRef) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | self.write().remove_cell(&cell.id) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockWriteGuard<'_, H>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rw_reference_access/hierarchy_reference_access.rs:109:9 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn remove_cell(&self, cell: CellRef) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | self.write().remove_cell(&cell.id) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/profile.rs:105:38 [INFO] [stdout] | [INFO] [stdout] 105 | #[derive(Copy, Clone, PartialEq, Eq, ToPrimitive, FromPrimitive, Debug)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `ToPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_ToPrimitive_FOR_FnName` [INFO] [stdout] 106 | #[allow(non_camel_case_types, missing_docs)] [INFO] [stdout] 107 | pub enum FnName { [INFO] [stdout] | ------ `FnName` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `ToPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/profile.rs:105:51 [INFO] [stdout] | [INFO] [stdout] 105 | #[derive(Copy, Clone, PartialEq, Eq, ToPrimitive, FromPrimitive, Debug)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_FnName` [INFO] [stdout] 106 | #[allow(non_camel_case_types, missing_docs)] [INFO] [stdout] 107 | pub enum FnName { [INFO] [stdout] | ------ `FnName` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/profile.rs:105:38 [INFO] [stdout] | [INFO] [stdout] 105 | #[derive(Copy, Clone, PartialEq, Eq, ToPrimitive, FromPrimitive, Debug)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `ToPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_ToPrimitive_FOR_FnName` [INFO] [stdout] 106 | #[allow(non_camel_case_types, missing_docs)] [INFO] [stdout] 107 | pub enum FnName { [INFO] [stdout] | ------ `FnName` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `ToPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/profile.rs:105:51 [INFO] [stdout] | [INFO] [stdout] 105 | #[derive(Copy, Clone, PartialEq, Eq, ToPrimitive, FromPrimitive, Debug)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_FnName` [INFO] [stdout] 106 | #[allow(non_camel_case_types, missing_docs)] [INFO] [stdout] 107 | pub enum FnName { [INFO] [stdout] | ------ `FnName` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libreda-db` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libreda-db` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "27c45f871655a76e2a733b88519b7c47a13e08d5e823d41ecd5fbfd5a447a04b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27c45f871655a76e2a733b88519b7c47a13e08d5e823d41ecd5fbfd5a447a04b", kill_on_drop: false }` [INFO] [stdout] 27c45f871655a76e2a733b88519b7c47a13e08d5e823d41ecd5fbfd5a447a04b