[INFO] fetching crate libdoh 0.9.11... [INFO] checking libdoh-0.9.11 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate libdoh 0.9.11 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate libdoh 0.9.11 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libdoh 0.9.11 [INFO] finished tweaking crates.io crate libdoh 0.9.11 [INFO] tweaked toml for crates.io crate libdoh 0.9.11 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 120 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding h2 v0.3.26 (available: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding hpke v0.11.0 (available: v0.12.0) [INFO] [stderr] Adding http v0.2.12 (available: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (available: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (available: v1.4.1) [INFO] [stderr] Adding rustls v0.21.12 (available: v0.23.13) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (available: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (available: v0.102.8) [INFO] [stderr] Adding tokio-rustls v0.24.1 (available: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7142cc9bcec48ff490d72c75f16804196e4b00492b3cbaee89097a1137d9340f [INFO] running `Command { std: "docker" "start" "-a" "7142cc9bcec48ff490d72c75f16804196e4b00492b3cbaee89097a1137d9340f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7142cc9bcec48ff490d72c75f16804196e4b00492b3cbaee89097a1137d9340f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7142cc9bcec48ff490d72c75f16804196e4b00492b3cbaee89097a1137d9340f", kill_on_drop: false }` [INFO] [stdout] 7142cc9bcec48ff490d72c75f16804196e4b00492b3cbaee89097a1137d9340f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60523178a2b54f6e7bb4cf99917d096d646c749d075bf7a8cb3ff972d4a3e48d [INFO] running `Command { std: "docker" "start" "-a" "60523178a2b54f6e7bb4cf99917d096d646c749d075bf7a8cb3ff972d4a3e48d", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking hpke v0.11.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking odoh-rs v1.0.3 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking libdoh v0.9.11 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:150:14 [INFO] [stdout] | [INFO] [stdout] 150 | let (tls_acceptor_sender, tls_acceptor_receiver) = mpsc::channel(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 166 | join!(https_service, cert_service).0 [INFO] [stdout] | ---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `tokio::sync::mpsc::Sender` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:150:14 [INFO] [stdout] | [INFO] [stdout] 150 | let (tls_acceptor_sender, tls_acceptor_receiver) = mpsc::channel(1); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 166 | join!(https_service, cert_service).0 [INFO] [stdout] | ---------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `bytes::Bytes` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odoh.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 53 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let odoh_query = ObliviousDoHMessage::deserialize(&mut bytes::Bytes::from(encrypted_query)) [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok((query.into_msg().to_vec(), context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Guard>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odoh.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 129 | let key = Arc::clone(&self.key); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Arc::clone(&key.load()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `bytes::Bytes` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odoh.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 53 | self, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let odoh_query = ObliviousDoHMessage::deserialize(&mut bytes::Bytes::from(encrypted_query)) [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok((query.into_msg().to_vec(), context)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Guard>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/odoh.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 129 | let key = Arc::clone(&self.key); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Arc::clone(&key.load()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libdoh` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libdoh` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "60523178a2b54f6e7bb4cf99917d096d646c749d075bf7a8cb3ff972d4a3e48d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60523178a2b54f6e7bb4cf99917d096d646c749d075bf7a8cb3ff972d4a3e48d", kill_on_drop: false }` [INFO] [stdout] 60523178a2b54f6e7bb4cf99917d096d646c749d075bf7a8cb3ff972d4a3e48d