[INFO] fetching crate libblobd-direct 0.5.4... [INFO] checking libblobd-direct-0.5.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate libblobd-direct 0.5.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate libblobd-direct 0.5.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate libblobd-direct 0.5.4 [INFO] finished tweaking crates.io crate libblobd-direct 0.5.4 [INFO] tweaked toml for crates.io crate libblobd-direct 0.5.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 143 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding croaring v0.8.1 (available: v2.1.0) [INFO] [stderr] Adding croaring-sys v0.8.1 (available: v4.1.4) [INFO] [stderr] Adding dashmap v5.5.3 (available: v6.1.0) [INFO] [stderr] Adding heck v0.4.1 (available: v0.5.0) [INFO] [stderr] Adding io-uring v0.6.4 (available: v0.7.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding matchers v0.1.0 (available: v0.2.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (available: v0.50.1) [INFO] [stderr] Adding num-derive v0.3.3 (available: v0.4.2) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding strum v0.24.1 (available: v0.26.3) [INFO] [stderr] Adding strum_macros v0.24.3 (available: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09e0e1d373f66aaebb60ed70d7b3ef86d7f4de57734f58938ce4ca8f621064da [INFO] running `Command { std: "docker" "start" "-a" "09e0e1d373f66aaebb60ed70d7b3ef86d7f4de57734f58938ce4ca8f621064da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09e0e1d373f66aaebb60ed70d7b3ef86d7f4de57734f58938ce4ca8f621064da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09e0e1d373f66aaebb60ed70d7b3ef86d7f4de57734f58938ce4ca8f621064da", kill_on_drop: false }` [INFO] [stdout] 09e0e1d373f66aaebb60ed70d7b3ef86d7f4de57734f58938ce4ca8f621064da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4204d9112994f3776c955c2094dc49ed4371ed1c9e2a8ffb27979688aeca67f [INFO] running `Command { std: "docker" "start" "-a" "f4204d9112994f3776c955c2094dc49ed4371ed1c9e2a8ffb27979688aeca67f", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling cc v1.1.22 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling croaring-sys v0.8.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling io-uring v0.6.4 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling struct-name v0.0.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking roaring v0.10.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking croaring v0.8.1 [INFO] [stderr] Checking bufpool v0.2.4 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking signal-future v0.1.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling struct-name-macro v0.0.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling tracing-test-macro v0.2.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking stochastic-queue v0.2.0 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking tracing-test v0.2.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking off64 v0.6.0 [INFO] [stderr] Checking tinybuf v0.3.0 [INFO] [stderr] Checking libblobd-direct v0.5.4 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `uring::Request` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backing_store/uring.rs:199:16 [INFO] [stdout] | [INFO] [stdout] 190 | let mut completion = unsafe { ring.completion_shared() }; [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let (req, started) = pending.remove(&id).unwrap().1; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `uring::Request` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/backing_store/uring.rs:199:16 [INFO] [stdout] | [INFO] [stdout] 190 | let mut completion = unsafe { ring.completion_shared() }; [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let (req, started) = pending.remove(&id).unwrap().1; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/object/mod.rs:28:45 [INFO] [stdout] | [INFO] [stdout] 28 | #[derive(PartialEq, Eq, Clone, Copy, Debug, FromPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_ObjectState` [INFO] [stdout] 29 | #[repr(u8)] [INFO] [stdout] 30 | pub(crate) enum ObjectState { [INFO] [stdout] | ----------- `ObjectState` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/object/mod.rs:28:45 [INFO] [stdout] | [INFO] [stdout] 28 | #[derive(PartialEq, Eq, Clone, Copy, Debug, FromPrimitive)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `FromPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_FromPrimitive_FOR_ObjectState` [INFO] [stdout] 29 | #[repr(u8)] [INFO] [stdout] 30 | pub(crate) enum ObjectState { [INFO] [stdout] | ----------- `ObjectState` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `FromPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `libblobd-direct` (lib test) due to 2 previous errors; 1 warning emitted [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `libblobd-direct` (lib) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f4204d9112994f3776c955c2094dc49ed4371ed1c9e2a8ffb27979688aeca67f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4204d9112994f3776c955c2094dc49ed4371ed1c9e2a8ffb27979688aeca67f", kill_on_drop: false }` [INFO] [stdout] f4204d9112994f3776c955c2094dc49ed4371ed1c9e2a8ffb27979688aeca67f