[INFO] fetching crate lemgine 0.2.1... [INFO] checking lemgine-0.2.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate lemgine 0.2.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate lemgine 0.2.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lemgine 0.2.1 [INFO] finished tweaking crates.io crate lemgine 0.2.1 [INFO] tweaked toml for crates.io crate lemgine 0.2.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate lemgine 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 87e45b7bddf2f1a448a430a0eb3ae49855da2626052178620172a2c25a5a16fb [INFO] running `Command { std: "docker" "start" "-a" "87e45b7bddf2f1a448a430a0eb3ae49855da2626052178620172a2c25a5a16fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "87e45b7bddf2f1a448a430a0eb3ae49855da2626052178620172a2c25a5a16fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87e45b7bddf2f1a448a430a0eb3ae49855da2626052178620172a2c25a5a16fb", kill_on_drop: false }` [INFO] [stdout] 87e45b7bddf2f1a448a430a0eb3ae49855da2626052178620172a2c25a5a16fb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e16bbb05158a65d5e6aade319b1d40f70e9e4306826aa4706e31e332947ccaa6 [INFO] running `Command { std: "docker" "start" "-a" "e16bbb05158a65d5e6aade319b1d40f70e9e4306826aa4706e31e332947ccaa6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling xml-rs v0.8.4 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling pkg-config v0.3.20 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking libloading v0.7.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking ttf-parser v0.6.2 [INFO] [stderr] Compiling crossbeam-queue v0.3.2 [INFO] [stderr] Compiling nix v0.18.0 [INFO] [stderr] Checking dlib v0.5.0 [INFO] [stderr] Checking minimal-lexical v0.1.3 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.4 [INFO] [stderr] Checking instant v0.1.11 [INFO] [stderr] Checking libloading v0.6.7 [INFO] [stderr] Compiling nom v7.0.0 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Compiling winit v0.25.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling cc v1.0.70 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking gimli v0.25.0 [INFO] [stderr] Checking object v0.26.2 [INFO] [stderr] Checking rustc-demangle v0.1.21 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking takeable-option v0.5.0 [INFO] [stderr] Compiling wayland-sys v0.28.6 [INFO] [stderr] Compiling x11-dl v2.19.1 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking owned_ttf_parser v0.6.0 [INFO] [stderr] Compiling wayland-scanner v0.28.6 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking rusttype v0.9.2 [INFO] [stderr] Checking andrew v0.3.1 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Compiling backtrace v0.3.61 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking memmap2 v0.1.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Compiling glutin_glx_sys v0.1.7 [INFO] [stderr] Compiling glutin_egl_sys v0.1.5 [INFO] [stderr] Compiling glium v0.30.2 [INFO] [stderr] Checking mio-misc v1.2.1 [INFO] [stderr] Compiling wayland-client v0.28.6 [INFO] [stderr] Compiling wayland-protocols v0.28.6 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Checking addr2line v0.16.0 [INFO] [stderr] Checking wayland-commons v0.28.6 [INFO] [stderr] Checking calloop v0.6.5 [INFO] [stderr] Checking wayland-cursor v0.28.6 [INFO] [stderr] Checking wayland-egl v0.28.6 [INFO] [stderr] Checking smithay-client-toolkit v0.12.3 [INFO] [stderr] Checking glutin v0.27.0 [INFO] [stderr] Checking winit_input_helper v0.10.0 [INFO] [stderr] Checking lemgine v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Ref<'_, takeable_option::Takeable>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 85 | display: Display, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | size: display.gl_window().window().inner_size().to_logical::(1.0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/engine.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 82 | / pub fn new( [INFO] [stdout] 83 | | vertex_shader: String, [INFO] [stdout] 84 | | fragment_shader: String, [INFO] [stdout] 85 | | display: Display, [INFO] [stdout] 86 | | renderer: Renderer, [INFO] [stdout] 87 | | ) -> WindowDrawer { [INFO] [stdout] | |_____________________- move the `impl` block outside of this associated function `new` [INFO] [stdout] 88 | implement_vertex!(Vertex, position); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Vertex` is not local [INFO] [stdout] | `Vertex` is not local [INFO] [stdout] | [INFO] [stdout] = note: the macro `implement_vertex` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the macro `implement_vertex` may come from an old version of the `glium` crate, try updating your dependency with `cargo update -p glium` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the macro `implement_vertex` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, takeable_option::Takeable>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 85 | display: Display, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | size: display.gl_window().window().inner_size().to_logical::(1.0), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lemgine` (lib test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/engine.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 82 | / pub fn new( [INFO] [stdout] 83 | | vertex_shader: String, [INFO] [stdout] 84 | | fragment_shader: String, [INFO] [stdout] 85 | | display: Display, [INFO] [stdout] 86 | | renderer: Renderer, [INFO] [stdout] 87 | | ) -> WindowDrawer { [INFO] [stdout] | |_____________________- move the `impl` block outside of this associated function `new` [INFO] [stdout] 88 | implement_vertex!(Vertex, position); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Vertex` is not local [INFO] [stdout] | `Vertex` is not local [INFO] [stdout] | [INFO] [stdout] = note: the macro `implement_vertex` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the macro `implement_vertex` may come from an old version of the `glium` crate, try updating your dependency with `cargo update -p glium` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the macro `implement_vertex` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lemgine` (lib) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "e16bbb05158a65d5e6aade319b1d40f70e9e4306826aa4706e31e332947ccaa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e16bbb05158a65d5e6aade319b1d40f70e9e4306826aa4706e31e332947ccaa6", kill_on_drop: false }` [INFO] [stdout] e16bbb05158a65d5e6aade319b1d40f70e9e4306826aa4706e31e332947ccaa6