[INFO] fetching crate legion-core 0.2.4... [INFO] checking legion-core-0.2.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate legion-core 0.2.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate legion-core 0.2.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate legion-core 0.2.4 [INFO] finished tweaking crates.io crate legion-core 0.2.4 [INFO] tweaked toml for crates.io crate legion-core 0.2.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 100 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (available: v0.1.0) [INFO] [stderr] Adding crossbeam-channel v0.4.4 (available: v0.5.13) [INFO] [stderr] Adding crossbeam-queue v0.2.3 (available: v0.3.11) [INFO] [stderr] Adding crossbeam-utils v0.7.2 (available: v0.8.20) [INFO] [stderr] Adding erased-serde v0.3.31 (available: v0.4.5) [INFO] [stderr] Adding itertools v0.8.2 (available: v0.13.0) [INFO] [stderr] Adding lock_api v0.3.4 (available: v0.4.12) [INFO] [stderr] Adding matchers v0.0.1 (available: v0.2.0) [INFO] [stderr] Adding metrics v0.12.1 (available: v0.23.0) [INFO] [stderr] Adding parking_lot v0.10.2 (available: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.7.3 (available: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.1.57 (available: v0.5.6) [INFO] [stderr] Adding regex-automata v0.1.10 (available: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding tracing-log v0.1.4 (available: v0.2.0) [INFO] [stderr] Adding tracing-subscriber v0.2.25 (available: v0.3.18) [INFO] [stderr] Adding uuid v0.8.2 (available: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aefc0436f8a529bd26e188f95a7cf666e177eefd8703debfa08f42c6bcf5c7a5 [INFO] running `Command { std: "docker" "start" "-a" "aefc0436f8a529bd26e188f95a7cf666e177eefd8703debfa08f42c6bcf5c7a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aefc0436f8a529bd26e188f95a7cf666e177eefd8703debfa08f42c6bcf5c7a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aefc0436f8a529bd26e188f95a7cf666e177eefd8703debfa08f42c6bcf5c7a5", kill_on_drop: false }` [INFO] [stdout] aefc0436f8a529bd26e188f95a7cf666e177eefd8703debfa08f42c6bcf5c7a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 30fc25187be391ac6ee25e3dca3ad86196db9ebf7e0af43a8f2b64fdcea0ef19 [INFO] running `Command { std: "docker" "start" "-a" "30fc25187be391ac6ee25e3dca3ad86196db9ebf7e0af43a8f2b64fdcea0ef19", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking parking_lot_core v0.7.3 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Compiling type-uuid-derive v0.1.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking type-uuid v0.1.2 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking legion-core v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/storage.rs:1234:37 [INFO] [stdout] | [INFO] [stdout] 1232 | pub(crate) fn iter_data_slice<'a, T: Component>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 1233 | &'a self, [INFO] [stdout] 1234 | ) -> impl Iterator> + 'a { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/storage.rs:1234:38 [INFO] [stdout] | [INFO] [stdout] 1232 | pub(crate) fn iter_data_slice<'a, T: Component>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 1233 | &'a self, [INFO] [stdout] 1234 | ) -> impl Iterator> + 'a { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/storage.rs:1245:40 [INFO] [stdout] | [INFO] [stdout] 1243 | pub(crate) unsafe fn iter_data_slice_unchecked_mut<'a, T: Component>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 1244 | &'a self, [INFO] [stdout] 1245 | ) -> impl Iterator> + 'a { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/storage.rs:1245:41 [INFO] [stdout] | [INFO] [stdout] 1243 | pub(crate) unsafe fn iter_data_slice_unchecked_mut<'a, T: Component>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] 1244 | &'a self, [INFO] [stdout] 1245 | ) -> impl Iterator> + 'a { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicIsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/borrow.rs:78:34 [INFO] [stdout] | [INFO] [stdout] 78 | if self.borrow_state.compare_and_swap( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicIsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/borrow.rs:143:18 [INFO] [stdout] | [INFO] [stdout] 143 | .compare_and_swap(0, -1, std::sync::atomic::Ordering::SeqCst); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde v1.0.210 [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterator.rs:159:30 [INFO] [stdout] | [INFO] [stdout] 158 | fn split(mut self) -> (Self, Self, usize) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | if let Some(value) = self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/world.rs:1061:43 [INFO] [stdout] | [INFO] [stdout] 1061 | archetype_data: archetype_data.deref(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `ArchetypeData` does not implement `Deref`, so calling `deref` on `&ArchetypeData` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 1061 - archetype_data: archetype_data.deref(), [INFO] [stdout] 1061 + archetype_data: archetype_data, [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `ArchetypeData`, implement `Clone` for it [INFO] [stdout] --> src/storage.rs:620:1 [INFO] [stdout] | [INFO] [stdout] 620 + #[derive(Clone)] [INFO] [stdout] 621 | pub struct ArchetypeData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `legion-core` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "30fc25187be391ac6ee25e3dca3ad86196db9ebf7e0af43a8f2b64fdcea0ef19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30fc25187be391ac6ee25e3dca3ad86196db9ebf7e0af43a8f2b64fdcea0ef19", kill_on_drop: false }` [INFO] [stdout] 30fc25187be391ac6ee25e3dca3ad86196db9ebf7e0af43a8f2b64fdcea0ef19