[INFO] fetching crate ledb 0.4.0... [INFO] checking ledb-0.4.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate ledb 0.4.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ledb 0.4.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ledb 0.4.0 [INFO] finished tweaking crates.io crate ledb 0.4.0 [INFO] tweaked toml for crates.io crate ledb 0.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 47 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (available: v0.22.1) [INFO] [stderr] Adding bitflags v0.9.1 (available: v2.6.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding dirs v2.0.2 (available: v5.0.1) [INFO] [stderr] Adding dirs-sys v0.3.7 (available: v0.4.1) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding ordered-float v1.1.1 (available: v4.3.0) [INFO] [stderr] Adding ron v0.6.6 (available: v0.8.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6a07c659ae2e03f1f7af2cf2d2e7900d29711ef513b7dfbe305511c768ff27d6 [INFO] running `Command { std: "docker" "start" "-a" "6a07c659ae2e03f1f7af2cf2d2e7900d29711ef513b7dfbe305511c768ff27d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6a07c659ae2e03f1f7af2cf2d2e7900d29711ef513b7dfbe305511c768ff27d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a07c659ae2e03f1f7af2cf2d2e7900d29711ef513b7dfbe305511c768ff27d6", kill_on_drop: false }` [INFO] [stdout] 6a07c659ae2e03f1f7af2cf2d2e7900d29711ef513b7dfbe305511c768ff27d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 443a68f4f875461fec367dd84af2c58057809712b0e88e29760b45edaf671c19 [INFO] running `Command { std: "docker" "start" "-a" "443a68f4f875461fec367dd84af2c58057809712b0e88e29760b45edaf671c19", kill_on_drop: false }` [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking supercow v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Compiling liblmdb-sys v0.2.2 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Compiling ledb-derive v0.4.0 [INFO] [stderr] Checking lmdb-zero v0.4.4 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking ron v0.6.6 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking ledb-types v0.4.0 [INFO] [stderr] Checking ledb v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ledb_derive::*` [INFO] [stdout] --> src/lib.rs:367:9 [INFO] [stdout] | [INFO] [stdout] 367 | pub use ledb_derive::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `macros::*` [INFO] [stdout] --> src/lib.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 373 | pub use macros::*; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ledb_derive::*` [INFO] [stdout] --> src/lib.rs:367:9 [INFO] [stdout] | [INFO] [stdout] 367 | pub use ledb_derive::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `macros::*` [INFO] [stdout] --> src/lib.rs:373:9 [INFO] [stdout] | [INFO] [stdout] 373 | pub use macros::*; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection.rs:658:30 [INFO] [stdout] | [INFO] [stdout] 657 | pub(crate) fn req_index>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 658 | if let Some(index) = self.get_index(&path)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:246:32 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn new>(path: P, opts: Options) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | if let Some(storage) = Pool::get(&path)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/pool.rs:24:38 [INFO] [stdout] | [INFO] [stdout] 24 | if let Some(storages) = unsafe { &STORAGES } { [INFO] [stdout] | ^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 24 | if let Some(storages) = unsafe { &raw const STORAGES } { [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ledb` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/collection.rs:658:30 [INFO] [stdout] | [INFO] [stdout] 657 | pub(crate) fn req_index>(&self, path: P) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 658 | if let Some(index) = self.get_index(&path)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:246:32 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn new>(path: P, opts: Options) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | if let Some(storage) = Pool::get(&path)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/pool.rs:24:38 [INFO] [stdout] | [INFO] [stdout] 24 | if let Some(storages) = unsafe { &STORAGES } { [INFO] [stdout] | ^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `&raw const` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 24 | if let Some(storages) = unsafe { &raw const STORAGES } { [INFO] [stdout] | ~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:809:52 [INFO] [stdout] | [INFO] [stdout] 809 | #[derive(Debug, Clone, Serialize, Deserialize, Document)] [INFO] [stdout] | ^------- [INFO] [stdout] | | [INFO] [stdout] | `Document` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DOCUMENT_FOR_RootDoc` [INFO] [stdout] 810 | struct RootDoc { [INFO] [stdout] | ------- `RootDoc` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Document` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Document` may come from an old version of the `ledb_derive` crate, try updating your dependency with `cargo update -p ledb_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Document` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:824:52 [INFO] [stdout] | [INFO] [stdout] 824 | #[derive(Debug, Clone, Serialize, Deserialize, Document)] [INFO] [stdout] | ^------- [INFO] [stdout] | | [INFO] [stdout] | `Document` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DOCUMENT_FOR_MetaData` [INFO] [stdout] 825 | #[document(nested)] [INFO] [stdout] 826 | struct MetaData { [INFO] [stdout] | -------- `MetaData` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Document` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Document` may come from an old version of the `ledb_derive` crate, try updating your dependency with `cargo update -p ledb_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Document` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:833:52 [INFO] [stdout] | [INFO] [stdout] 833 | #[derive(Debug, Clone, Serialize, Deserialize, Document)] [INFO] [stdout] | ^------- [INFO] [stdout] | | [INFO] [stdout] | `Document` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DOCUMENT_FOR_LinkData` [INFO] [stdout] 834 | #[document(nested)] [INFO] [stdout] 835 | struct LinkData { [INFO] [stdout] | -------- `LinkData` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Document` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Document` may come from an old version of the `ledb_derive` crate, try updating your dependency with `cargo update -p ledb_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Document` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ledb` (lib test) due to 3 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "443a68f4f875461fec367dd84af2c58057809712b0e88e29760b45edaf671c19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "443a68f4f875461fec367dd84af2c58057809712b0e88e29760b45edaf671c19", kill_on_drop: false }` [INFO] [stdout] 443a68f4f875461fec367dd84af2c58057809712b0e88e29760b45edaf671c19