[INFO] fetching crate launchdarkly-server-sdk-evaluation 2.0.0... [INFO] checking launchdarkly-server-sdk-evaluation-2.0.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate launchdarkly-server-sdk-evaluation 2.0.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate launchdarkly-server-sdk-evaluation 2.0.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate launchdarkly-server-sdk-evaluation 2.0.0 [INFO] finished tweaking crates.io crate launchdarkly-server-sdk-evaluation 2.0.0 [INFO] tweaked toml for crates.io crate launchdarkly-server-sdk-evaluation 2.0.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 130 packages to latest compatible versions [INFO] [stderr] Adding base16ct v0.1.1 (available: v0.2.0) [INFO] [stderr] Adding base64 v0.13.1 (available: v0.22.1) [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding num v0.1.42 (available: v0.4.3) [INFO] [stderr] Adding num-bigint v0.1.44 (available: v0.4.6) [INFO] [stderr] Adding num-complex v0.1.43 (available: v0.4.6) [INFO] [stderr] Adding num-rational v0.1.42 (available: v0.4.2) [INFO] [stderr] Adding proc-macro2 v0.4.30 (available: v1.0.86) [INFO] [stderr] Adding proptest-derive v0.3.0 (available: v0.5.0) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding quote v0.6.13 (available: v1.0.37) [INFO] [stderr] Adding rand v0.4.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding serde_with v2.3.3 (available: v3.9.0) [INFO] [stderr] Adding serde_with_macros v2.3.3 (available: v3.9.0) [INFO] [stderr] Adding syn v0.15.44 (available: v2.0.79) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] [stderr] Adding test-case v2.2.2 (available: v3.3.1) [INFO] [stderr] Adding test-case-macros v2.2.2 (available: v3.3.1) [INFO] [stderr] Adding unicode-xid v0.1.0 (available: v0.2.6) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9817a0e3afa40ea9a64caaf6f8a4d5b5a98666daab6494c6960ef8dbe11b2485 [INFO] running `Command { std: "docker" "start" "-a" "9817a0e3afa40ea9a64caaf6f8a4d5b5a98666daab6494c6960ef8dbe11b2485", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9817a0e3afa40ea9a64caaf6f8a4d5b5a98666daab6494c6960ef8dbe11b2485", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9817a0e3afa40ea9a64caaf6f8a4d5b5a98666daab6494c6960ef8dbe11b2485", kill_on_drop: false }` [INFO] [stdout] 9817a0e3afa40ea9a64caaf6f8a4d5b5a98666daab6494c6960ef8dbe11b2485 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64dab96665a4dd55394c2efaf45afeb2579a830be62a27f26da75ab6f6d61108 [INFO] running `Command { std: "docker" "start" "-a" "64dab96665a4dd55394c2efaf45afeb2579a830be62a27f26da75ab6f6d61108", kill_on_drop: false }` [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking tempfile v3.13.0 [INFO] [stderr] Checking base16ct v0.1.1 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling test-case-macros v2.2.2 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking test-case v2.2.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking spectral v0.6.0 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling proptest-derive v0.3.0 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v2.3.3 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking serde_with v2.3.3 [INFO] [stderr] Checking assert-json-diff v2.0.2 [INFO] [stderr] Checking launchdarkly-server-sdk-evaluation v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:328:15 [INFO] [stdout] | [INFO] [stdout] 317 | pub fn try_map(self, f: F, default: U, e: Error) -> Detail [INFO] [stdout] | ---- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | match f(self.value.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option, std::option::Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:401:11 [INFO] [stdout] | [INFO] [stdout] 399 | f: F, [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 400 | ) -> bool { [INFO] [stdout] 401 | match (lhs.as_semver(), rhs.as_semver()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `launchdarkly-server-sdk-evaluation` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/eval.rs:328:15 [INFO] [stdout] | [INFO] [stdout] 317 | pub fn try_map(self, f: F, default: U, e: Error) -> Detail [INFO] [stdout] | ---- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | match f(self.value.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option, std::option::Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:401:11 [INFO] [stdout] | [INFO] [stdout] 399 | f: F, [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 400 | ) -> bool { [INFO] [stdout] 401 | match (lhs.as_semver(), rhs.as_semver()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::hash_map::IntoIter<&str, AttributeTestCase>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:858:34 [INFO] [stdout] | [INFO] [stdout] 856 | let mut evaluation_stack = EvaluationStack::default(); [INFO] [stdout] | -------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 857 | [INFO] [stdout] 858 | for (attr, test_case) in tests { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/rule.rs:153:25 [INFO] [stdout] | [INFO] [stdout] 153 | #[cfg_attr(test, derive(proptest_derive::Arbitrary))] [INFO] [stdout] | ^------------------------- [INFO] [stdout] | | [INFO] [stdout] | `Arbitrary` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_ARBITRARY_FOR_Op` [INFO] [stdout] 154 | #[serde(rename_all = "camelCase")] [INFO] [stdout] 155 | enum Op { [INFO] [stdout] | -- `Op` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `proptest_derive::Arbitrary` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `proptest_derive::Arbitrary` may come from an old version of the `proptest_derive` crate, try updating your dependency with `cargo update -p proptest_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `proptest_derive::Arbitrary` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `launchdarkly-server-sdk-evaluation` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "64dab96665a4dd55394c2efaf45afeb2579a830be62a27f26da75ab6f6d61108", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64dab96665a4dd55394c2efaf45afeb2579a830be62a27f26da75ab6f6d61108", kill_on_drop: false }` [INFO] [stdout] 64dab96665a4dd55394c2efaf45afeb2579a830be62a27f26da75ab6f6d61108