[INFO] fetching crate lalrpop 0.21.0... [INFO] checking lalrpop-0.21.0 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate lalrpop 0.21.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate lalrpop 0.21.0 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lalrpop 0.21.0 [INFO] finished tweaking crates.io crate lalrpop 0.21.0 [INFO] tweaked toml for crates.io crate lalrpop 0.21.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate lalrpop 0.21.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 42f623416126e95fa089d170bad1443baea22cf0fbc7e1eb00bc9991c4bdb1cf [INFO] running `Command { std: "docker" "start" "-a" "42f623416126e95fa089d170bad1443baea22cf0fbc7e1eb00bc9991c4bdb1cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "42f623416126e95fa089d170bad1443baea22cf0fbc7e1eb00bc9991c4bdb1cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42f623416126e95fa089d170bad1443baea22cf0fbc7e1eb00bc9991c4bdb1cf", kill_on_drop: false }` [INFO] [stdout] 42f623416126e95fa089d170bad1443baea22cf0fbc7e1eb00bc9991c4bdb1cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a57d8f3c3f4dace0befd58dea453bf2153545b3ba360c5f5c2f08fa83d61c55b [INFO] running `Command { std: "docker" "start" "-a" "a57d8f3c3f4dace0befd58dea453bf2153545b3ba360c5f5c2f08fa83d61c55b", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Checking precomputed-hash v0.1.1 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking bit-vec v0.7.0 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking ena v0.14.3 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking unicode-xid v0.2.4 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking bit-set v0.6.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking phf_shared v0.10.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking string_cache v0.8.7 [INFO] [stderr] Checking ascii-canvas v3.0.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking lalrpop-util v0.21.0 [INFO] [stderr] Checking lalrpop v0.21.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lr1/lane_table/table/mod.rs:46:75 [INFO] [stdout] | [INFO] [stdout] 45 | impl<'grammar> LaneTable<'grammar> { [INFO] [stdout] | -------- lifetime `'grammar` declared here [INFO] [stdout] 46 | pub fn new(grammar: &'grammar Grammar, conflicts: usize) -> LaneTable<'_> { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'grammar` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/lr1/lane_table/table/mod.rs:46:75 [INFO] [stdout] | [INFO] [stdout] 45 | impl<'grammar> LaneTable<'grammar> { [INFO] [stdout] | -------- lifetime `'grammar` declared here [INFO] [stdout] 46 | pub fn new(grammar: &'grammar Grammar, conflicts: usize) -> LaneTable<'_> { [INFO] [stdout] | ^^ this elided lifetime gets resolved as `'grammar` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ConflictClassification` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lr1/error/test.rs:35:11 [INFO] [stdout] | [INFO] [stdout] 16 | let _tls = Tls::test(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let grammar = normalized_grammar( [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let _lr1_tls = Lr1Tls::install(grammar.terminals.clone()); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | let err = build_states(&grammar, nt("Ty")).unwrap_err(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let mut cx = ErrorReportingCx::new(&grammar, &err.states, &err.conflicts); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let conflicts = super::token_conflicts(&err.conflicts); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | match cx.classify(conflict) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ConflictClassification` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lr1/error/test.rs:77:11 [INFO] [stdout] | [INFO] [stdout] 57 | let _tls = Tls::test(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let grammar = normalized_grammar( [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let _lr1_tls = Lr1Tls::install(grammar.terminals.clone()); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let err = build_states(&grammar, nt("Expr")).unwrap_err(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let mut cx = ErrorReportingCx::new(&grammar, &err.states, &err.conflicts); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let conflicts = super::token_conflicts(&err.conflicts); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | match cx.classify(conflict) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ConflictClassification` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lr1/error/test.rs:109:11 [INFO] [stdout] | [INFO] [stdout] 85 | let _tls = Tls::test(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let grammar = normalized_grammar( [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let _lr1_tls = Lr1Tls::install(grammar.terminals.clone()); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let err = build_states(&grammar, nt("E")).unwrap_err(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let mut cx = ErrorReportingCx::new(&grammar, &err.states, &err.conflicts); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let conflicts = super::token_conflicts(&err.conflicts); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | match cx.classify(conflict) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `ConflictClassification` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lr1/error/test.rs:153:11 [INFO] [stdout] | [INFO] [stdout] 128 | let _tls = Tls::test(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let grammar = normalized_grammar( [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | let _lr1_tls = Lr1Tls::install(grammar.terminals.clone()); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let err = build_states(&grammar, nt("ImportDecl")).unwrap_err(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | let mut cx = ErrorReportingCx::new(&grammar, &err.states, &err.conflicts); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | let conflicts = super::token_conflicts(&err.conflicts); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | match cx.classify(conflict) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/lrgrammar.rs:19895:7 [INFO] [stdout] | [INFO] [stdout] 19892 | (_, p, _): (usize, Path, usize), [INFO] [stdout] | --------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19895 | match p.as_id() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/normalize/resolve/test.rs:18:11 [INFO] [stdout] | [INFO] [stdout] 6 | let expected_err = Regex::new(expected_err).unwrap(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | match super::resolve(parsed_grammar) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(parse_tree::MatchMapping, &str)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/normalize/token_check/test.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 20 | let parsed_grammar = validate_grammar(grammar).expect("validate"); [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let actual_user_name = [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parse_tree::NonterminalString` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/normalize/tyinfer/test.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 17 | let grammar = token_check::validate(grammar).unwrap(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let types = infer_types(&grammar).unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let id = NonterminalString(Atom::from(nt_id)); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lalrpop` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/lrgrammar.rs:19895:7 [INFO] [stdout] | [INFO] [stdout] 19892 | (_, p, _): (usize, Path, usize), [INFO] [stdout] | --------- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19895 | match p.as_id() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lalrpop` (lib test) due to 9 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "a57d8f3c3f4dace0befd58dea453bf2153545b3ba360c5f5c2f08fa83d61c55b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a57d8f3c3f4dace0befd58dea453bf2153545b3ba360c5f5c2f08fa83d61c55b", kill_on_drop: false }` [INFO] [stdout] a57d8f3c3f4dace0befd58dea453bf2153545b3ba360c5f5c2f08fa83d61c55b