[INFO] fetching crate lag 0.1.1... [INFO] checking lag-0.1.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate lag 0.1.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate lag 0.1.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate lag 0.1.1 [INFO] finished tweaking crates.io crate lag 0.1.1 [INFO] tweaked toml for crates.io crate lag 0.1.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate lag 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7623487807cc53656370a49e4a6f57c9cd9f65f208b6a574bc772035fd924a5b [INFO] running `Command { std: "docker" "start" "-a" "7623487807cc53656370a49e4a6f57c9cd9f65f208b6a574bc772035fd924a5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7623487807cc53656370a49e4a6f57c9cd9f65f208b6a574bc772035fd924a5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7623487807cc53656370a49e4a6f57c9cd9f65f208b6a574bc772035fd924a5b", kill_on_drop: false }` [INFO] [stdout] 7623487807cc53656370a49e4a6f57c9cd9f65f208b6a574bc772035fd924a5b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dabcacd1014ea79c92560015810dc92ee13edd8cbfe8efb3054cc2d47840cda6 [INFO] running `Command { std: "docker" "start" "-a" "dabcacd1014ea79c92560015810dc92ee13edd8cbfe8efb3054cc2d47840cda6", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking smallvec v1.2.0 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking lock_api v0.3.3 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.10 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling proc-macro-error v0.4.10 [INFO] [stderr] Checking lazysort v0.2.1 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking parking_lot_core v0.7.0 [INFO] [stderr] Checking getrandom v0.1.14 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking parking_lot v0.10.0 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking signal-hook v0.1.13 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking crossterm v0.14.2 [INFO] [stderr] Checking crossterm v0.16.0 [INFO] [stderr] Checking backtrace v0.3.44 [INFO] [stderr] Checking tui v0.8.0 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling structopt-derive v0.4.2 [INFO] [stderr] Checking failure v0.1.6 [INFO] [stderr] Checking structopt v0.3.9 [INFO] [stderr] Checking serde_json v1.0.48 [INFO] [stderr] Checking lag v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/app.rs:112:10 [INFO] [stdout] | [INFO] [stdout] 106 | impl<'a> AnnotatedLine<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 112 | ) -> AnnotatedLine { [INFO] [stdout] | ^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/app.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | (0..self.lines.len()) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - (0..self.lines.len()) [INFO] [stdout] 209 + 0..self.lines.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/app.rs:112:10 [INFO] [stdout] | [INFO] [stdout] 106 | impl<'a> AnnotatedLine<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 112 | ) -> AnnotatedLine { [INFO] [stdout] | ^^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/app.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | (0..self.lines.len()) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - (0..self.lines.len()) [INFO] [stdout] 209 + 0..self.lines.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/replay.rs:24:10 [INFO] [stdout] | [INFO] [stdout] 24 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_KeyData` [INFO] [stdout] 25 | enum KeyData { [INFO] [stdout] | ------- `KeyData` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/replay.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_KeyData` [INFO] [stdout] 25 | enum KeyData { [INFO] [stdout] | ------- `KeyData` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `description` is never read [INFO] [stdout] --> src/chart.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 189 | struct ZoomTestCase { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 190 | description: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ZoomTestCase` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/replay.rs:24:10 [INFO] [stdout] | [INFO] [stdout] 24 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_KeyData` [INFO] [stdout] 25 | enum KeyData { [INFO] [stdout] | ------- `KeyData` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/replay.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_KeyData` [INFO] [stdout] 25 | enum KeyData { [INFO] [stdout] | ------- `KeyData` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.44s [INFO] running `Command { std: "docker" "inspect" "dabcacd1014ea79c92560015810dc92ee13edd8cbfe8efb3054cc2d47840cda6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dabcacd1014ea79c92560015810dc92ee13edd8cbfe8efb3054cc2d47840cda6", kill_on_drop: false }` [INFO] [stdout] dabcacd1014ea79c92560015810dc92ee13edd8cbfe8efb3054cc2d47840cda6