[INFO] fetching crate ksni 0.2.2... [INFO] checking ksni-0.2.2 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate ksni 0.2.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ksni 0.2.2 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ksni 0.2.2 [INFO] finished tweaking crates.io crate ksni 0.2.2 [INFO] tweaked toml for crates.io crate ksni 0.2.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate ksni 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 651b4dc66bfe16bd01b0dc91026a2fbe763c4ea58dc915c050af348801ce14bb [INFO] running `Command { std: "docker" "start" "-a" "651b4dc66bfe16bd01b0dc91026a2fbe763c4ea58dc915c050af348801ce14bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "651b4dc66bfe16bd01b0dc91026a2fbe763c4ea58dc915c050af348801ce14bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "651b4dc66bfe16bd01b0dc91026a2fbe763c4ea58dc915c050af348801ce14bb", kill_on_drop: false }` [INFO] [stdout] 651b4dc66bfe16bd01b0dc91026a2fbe763c4ea58dc915c050af348801ce14bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6821da2903059dc3ccb18bfb0449cad4f73efb30e92341d2a6562d038293388e [INFO] running `Command { std: "docker" "start" "-a" "6821da2903059dc3ccb18bfb0449cad4f73efb30e92341d2a6562d038293388e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling unicode-width v0.1.11 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling ansi_term v0.12.1 [INFO] [stderr] Compiling xml-rs v0.8.20 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling libdbus-sys v0.2.5 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking dbus v0.9.7 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking dbus-tree v0.9.2 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling dbus-codegen v0.9.1 [INFO] [stderr] Compiling ksni v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `menu::RawMenuItem` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 122 | fn from(item: StandardItem) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `menu::RawMenuItem` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:207:15 [INFO] [stdout] | [INFO] [stdout] 196 | fn from(item: SubMenu) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `menu::RawMenuItem` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:289:15 [INFO] [stdout] | [INFO] [stdout] 269 | fn from(item: CheckmarkItem) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RawMenuItem` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 122 | fn from(item: StandardItem) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RawMenuItem` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:207:15 [INFO] [stdout] | [INFO] [stdout] 196 | fn from(item: SubMenu) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RawMenuItem` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:289:15 [INFO] [stdout] | [INFO] [stdout] 269 | fn from(item: CheckmarkItem) -> Self { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 289 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `register_status_notifier_host`, `registered_status_notifier_items`, `is_status_notifier_host_registered`, and `protocol_version` are never used [INFO] [stdout] --> /opt/rustwide/target/debug/build/ksni-b41360181a6a8a78/out/dbus_interfaces.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub trait StatusNotifierWatcher { [INFO] [stdout] | --------------------- methods in this trait [INFO] [stdout] 9 | fn register_status_notifier_item(&self, service: &str) -> Result<(), dbus::Error>; [INFO] [stdout] 10 | fn register_status_notifier_host(&self, service: &str) -> Result<(), dbus::Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 11 | fn registered_status_notifier_items(&self) -> Result, dbus::Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | fn is_status_notifier_host_registered(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 13 | fn protocol_version(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `register_status_notifier_host`, `registered_status_notifier_items`, `is_status_notifier_host_registered`, and `protocol_version` are never used [INFO] [stdout] --> /opt/rustwide/target/debug/build/ksni-b41360181a6a8a78/out/dbus_interfaces.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub trait StatusNotifierWatcher { [INFO] [stdout] | --------------------- methods in this trait [INFO] [stdout] 9 | fn register_status_notifier_item(&self, service: &str) -> Result<(), dbus::Error>; [INFO] [stdout] 10 | fn register_status_notifier_host(&self, service: &str) -> Result<(), dbus::Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 11 | fn registered_status_notifier_items(&self) -> Result, dbus::Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | fn is_status_notifier_host_registered(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 13 | fn protocol_version(&self) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/service.rs:969:9 [INFO] [stdout] | [INFO] [stdout] 968 | fn gen_dbusmenu_tree_empty() { [INFO] [stdout] | ---------------------------- move the `impl` block outside of this function `gen_dbusmenu_tree_empty` [INFO] [stdout] 969 | impl Tray for () {} [INFO] [stdout] | ^^^^^----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Tray` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ksni` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ksni` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6821da2903059dc3ccb18bfb0449cad4f73efb30e92341d2a6562d038293388e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6821da2903059dc3ccb18bfb0449cad4f73efb30e92341d2a6562d038293388e", kill_on_drop: false }` [INFO] [stdout] 6821da2903059dc3ccb18bfb0449cad4f73efb30e92341d2a6562d038293388e