[INFO] fetching crate kaon 0.1.4... [INFO] checking kaon-0.1.4 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate kaon 0.1.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate kaon 0.1.4 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate kaon 0.1.4 [INFO] finished tweaking crates.io crate kaon 0.1.4 [INFO] tweaked toml for crates.io crate kaon 0.1.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 77 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (available: v0.8.11) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding criterion v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (available: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 712f4f2b4354239bf20b02455709a9048ebc4d68aef0124138b59f4c92b8ad09 [INFO] running `Command { std: "docker" "start" "-a" "712f4f2b4354239bf20b02455709a9048ebc4d68aef0124138b59f4c92b8ad09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "712f4f2b4354239bf20b02455709a9048ebc4d68aef0124138b59f4c92b8ad09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "712f4f2b4354239bf20b02455709a9048ebc4d68aef0124138b59f4c92b8ad09", kill_on_drop: false }` [INFO] [stdout] 712f4f2b4354239bf20b02455709a9048ebc4d68aef0124138b59f4c92b8ad09 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 33756b7cd1827c588b060ec3cc871e2696ec9334bcbcc1e3689b5b92e9f187ae [INFO] running `Command { std: "docker" "start" "-a" "33756b7cd1827c588b060ec3cc871e2696ec9334bcbcc1e3689b5b92e9f187ae", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking kaon v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `V` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/value.rs:186:23 [INFO] [stdout] | [INFO] [stdout] 185 | Rc::new(Box::new(move |_vm: &mut Vm, mut args: Vec| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | self(&mut V::from_value(args.pop().unwrap()).unwrap()).to_value() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/compiler/ast.rs:57:22 [INFO] [stdout] | [INFO] [stdout] 57 | pub struct StmtBlock(SmallVec<[Stmt; 4]>, Span); [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^^ ^^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/runtime/vm.rs:311:56 [INFO] [stdout] | [INFO] [stdout] 311 | self.stack.push(data.value.as_ref().borrow().clone()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Value` does not implement `Borrow`, so calling `borrow` on `&Value` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 311 - self.stack.push(data.value.as_ref().borrow().clone()); [INFO] [stdout] 311 + self.stack.push(data.value.as_ref().clone()); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Value`, implement `Clone` for it [INFO] [stdout] --> src/common/value.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 + #[derive(Clone)] [INFO] [stdout] 20 | pub enum Value { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/runtime/vm.rs:585:52 [INFO] [stdout] | [INFO] [stdout] 585 | upvalue.closed = upvalue.value.as_ref().borrow().clone(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Value` does not implement `Borrow`, so calling `borrow` on `&Value` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 585 - upvalue.closed = upvalue.value.as_ref().borrow().clone(); [INFO] [stdout] 585 + upvalue.closed = upvalue.value.as_ref().clone(); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Value`, implement `Clone` for it [INFO] [stdout] --> src/common/value.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 + #[derive(Clone)] [INFO] [stdout] 20 | pub enum Value { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.borrow()` on a reference in this situation does nothing [INFO] [stdout] --> src/runtime/vm.rs:588:74 [INFO] [stdout] | [INFO] [stdout] 588 | self.open_upvalues = upvalue.next.as_ref().map(|v| v.as_ref().borrow().clone()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Upvalue` does not implement `Borrow`, so calling `borrow` on `&Upvalue` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 588 - self.open_upvalues = upvalue.next.as_ref().map(|v| v.as_ref().borrow().clone()); [INFO] [stdout] 588 + self.open_upvalues = upvalue.next.as_ref().map(|v| v.as_ref().clone()); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `Upvalue`, implement `Clone` for it [INFO] [stdout] --> src/common/value.rs:832:1 [INFO] [stdout] | [INFO] [stdout] 832 + #[derive(Clone)] [INFO] [stdout] 833 | pub struct Upvalue { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kaon` (lib) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "33756b7cd1827c588b060ec3cc871e2696ec9334bcbcc1e3689b5b92e9f187ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33756b7cd1827c588b060ec3cc871e2696ec9334bcbcc1e3689b5b92e9f187ae", kill_on_drop: false }` [INFO] [stdout] 33756b7cd1827c588b060ec3cc871e2696ec9334bcbcc1e3689b5b92e9f187ae