[INFO] fetching crate join_impl 0.3.1... [INFO] checking join_impl-0.3.1 against try#c387b04bf028733cd561d62128c8a5eee4bc1458+rustflags=-Dtail_expr_drop_order for pr-130930 [INFO] extracting crate join_impl 0.3.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate join_impl 0.3.1 on toolchain c387b04bf028733cd561d62128c8a5eee4bc1458 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate join_impl 0.3.1 [INFO] finished tweaking crates.io crate join_impl 0.3.1 [INFO] tweaked toml for crates.io crate join_impl 0.3.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.79) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f63b3218fbec58f4067826980acdb580c9b6f2738a541e658d68337dc46bfc3b [INFO] running `Command { std: "docker" "start" "-a" "f63b3218fbec58f4067826980acdb580c9b6f2738a541e658d68337dc46bfc3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f63b3218fbec58f4067826980acdb580c9b6f2738a541e658d68337dc46bfc3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f63b3218fbec58f4067826980acdb580c9b6f2738a541e658d68337dc46bfc3b", kill_on_drop: false }` [INFO] [stdout] f63b3218fbec58f4067826980acdb580c9b6f2738a541e658d68337dc46bfc3b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:6252d7ea7fb8caaf7af6d800c5fb250a9cd862b9a7f9508afb3c54fa7fe1102e" "/opt/rustwide/cargo-home/bin/cargo" "+c387b04bf028733cd561d62128c8a5eee4bc1458" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a88094637c834d64f347cd40f470144e978bdd2261bdd56f015e3e87ae1f8ca3 [INFO] running `Command { std: "docker" "start" "-a" "a88094637c834d64f347cd40f470144e978bdd2261bdd56f015e3e87ae1f8ca3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-ident v1.0.13 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking join_impl v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `TokenStream2` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/join/join_output.rs:251:21 [INFO] [stdout] | [INFO] [stdout] 231 | let await_handler = if is_async { [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | let call_handler = [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `TokenStream2` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/join/join_output.rs:410:17 [INFO] [stdout] | [INFO] [stdout] 301 | let (def_streams, step_streams): (Vec<_>, Vec<_>) = self.chains [INFO] [stdout] | ----------- ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | let joiner = if self.active_step_branch_count(step_number) > 1 { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 410 | let join_results = joiner [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 414 | / quote! { [INFO] [stdout] 415 | | #( #def_streams )* [INFO] [stdout] 416 | | let #step_results_name = #join_results; [INFO] [stdout] 417 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 427 | / quote! { [INFO] [stdout] 428 | | #thread_builders [INFO] [stdout] 429 | | #( #def_streams )* [INFO] [stdout] 430 | | let #step_results_name = #joiner(#( #step_streams ),*); [INFO] [stdout] 431 | | #spawn_joiners [INFO] [stdout] 432 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/join/join_output.rs:468:22 [INFO] [stdout] | [INFO] [stdout] 444 | step_stream: TokenStream, [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 451 | let next_step_stream = next_step_stream.into(); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 462 | let extracted_results = [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 463 | self.extract_results_tuple(&step_results_name, result_pats, None, step_number); [INFO] [stdout] 464 | let err_to_err = quote! { Err(err) => Err(err) }; [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 468 | let (is_result_successful, result_vars_matcher): (Vec<_>, Vec<_>) = result_vars [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 487 | / quote! { [INFO] [stdout] 488 | | #step_stream [INFO] [stdout] 489 | | #extracted_results [INFO] [stdout] 490 | | if let Some(__fail_index) = [#( #is_result_successful ),*].iter().position(|#value_name| !#value_name) { [INFO] [stdout] ... | [INFO] [stdout] 497 | | } [INFO] [stdout] 498 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 517 | / quote! { [INFO] [stdout] 518 | | let #step_results_name = (#(# ok_result_vars ),*); [INFO] [stdout] 519 | | #extracted_results [INFO] [stdout] 520 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 571 | / quote! { [INFO] [stdout] 572 | | match #step_results_name { [INFO] [stdout] 573 | | Ok(#step_results_name) => { [INFO] [stdout] 574 | | #extracted_results [INFO] [stdout] ... | [INFO] [stdout] 578 | | } [INFO] [stdout] 579 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling join_impl v0.3.1 [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `join_impl` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a88094637c834d64f347cd40f470144e978bdd2261bdd56f015e3e87ae1f8ca3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a88094637c834d64f347cd40f470144e978bdd2261bdd56f015e3e87ae1f8ca3", kill_on_drop: false }` [INFO] [stdout] a88094637c834d64f347cd40f470144e978bdd2261bdd56f015e3e87ae1f8ca3